Repository navigation
[PR] ci: rebalance core test matrix to /3 shards across all combos (#4351) - #4355
Merged
Merged
Conversation
The suite grew ~399 -> ~860 files in three weeks while the core matrix shape stayed frozen at its ~650-file design point (#3295), so its heaviest legs became the per-PR wall-clock floor: the ubuntu-24 single-leg whole suite measured ~21 min and the windows 2-shard halves ~13-17 min (up to ~35 min tails on flake re-runs). All three core combos now shard /3. partitionAll stays total for any i/N, so the union of shards is still every file — zero coverage loss; the wall drops to the slowest shard (~7-12 min instead of 20-25). The win node-24 legs stay FULL-scope only. Check-run names are unchanged (explicit job name template), and all nine core leg names already sit in master's required-checks list.
Contributor
📦 Built Package ArtifactBranch: Option A — Install this exact build (recommended)npm install -g billion-context@0.0.5167-pr.4355.7fe4ae0This exact version is immutable and reproducible. The rolling Option B — Download artifact
tar xzf billion-context-pr4355.tgz
npm install -g packageInstall instructions are refreshed on each push. |
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #4351 — the decision-free part: re-sharding the core matrix. The remaining items there (coverage downsampling, bigger runners) wait on owner calls.
What & why
Measured per-leg wall from recent runs shows the core matrix IS the bottleneck:
test (ubuntu-latest, 24, shard 1)— whole suite on ONE legtest (windows-latest, 22, *)— suite in 2 halvestest (ubuntu-latest, 22, *)— already 3-shardThe shape was designed at ~656 files (#3143/#3295, Oct 15); the suite has since grown to ~860 files. Fix: shard ALL THREE core combos at /3 —
partitionAllstays total for any i/N, so union of shards == every file: zero coverage loss. These are exactly the per-combo shard shapes the FULL matrix already runs every cron tick, so no new code path.Expected wall: ~10–12 min instead of 20–25 min typical (35–70 min with tails). This PR's own CI run exercises the new matrix end-to-end as live proof.
Behavior changes (disclosed)
name:template); all nine core-produced names already sit in master's required-checks list (which still carries 12 legacy FULL names — the win node-24 ×3 appear only in FULL scope). No protection-config change needed here (enforce_admins is off today anyway).Verification
pull_requestevent →scope=core, testMatrix = 9 legs, valid JSON outputs.