Repository navigation
refactor: delegate session-handoff rendering to acp-kernel - #435
ranxianglei wants to merge 1 commit into
Conversation
[bot] 🏷 Investigated PR #435. Status: blocked on an upstream dependency — not a code problem. Dependency state (verified just now):
Code review (against the #183 pre-release): the delegation is correct and byte-identical:
Next: I'm running the PR branch against Unblocking needs (human/CI): merge acp-kernel#183 → publish acp-kernel |
[bot] 🏷 Validation results — ran the PR branch locally against the #183 pre-release
So the code is merge-ready: it will go green the moment One thing to note for the unblock step: the pushed branch changed only Remaining (human/CI only, I can't do these):
Nothing to fix in the PR itself. Standing by for the dependency to land. |
Removes the duplicated session-handoff markdown logic from the proxy by delegating to the kernel's shared renderer (acp-kernel PR #183), so the proxy and
billion-context-pino longer each carry a copy ofrenderHandoff/renderMessage/matchSession(requested in ranxianglei/billion-context-pi#271).Changes (
src/export.ts)s.lastMessages) now delegates the whole doc — metadata header + folded (prune) / full conversation — to kernelrenderHandoff({coreMessages, state, full, meta}), with protocol / upstream / requests injected viameta.extraBullets.blockContentsoriginals) is unchanged and stays byte-identical.matchSessionnow comes from the kernel (label accessor =s.meta.label).acp-kernel0.0.47→0.0.49(the release that ships the handoff exports).package-lock.jsonis refreshed once0.0.49is on npm.Verification (local pre-validation against acp-kernel#183's build,
0.0.48-pr.183.36)npm run typecheck— cleannpm test— 892 pass, 0 fail (incl.tests/cli-export.test.ts, which asserts the v2-fallback output is byte-identical, andtests/export-uncompressed.test.tsfor the v3 path)npm run build— successfull=falseandfull=true.Dependency / merge order
Blocked on acp-kernel#183 merging + acp-kernel 0.0.49 publishing. Until then CI is red at
npm ci(cannot resolve 0.0.49). After 0.0.49 is live, runnpm installto refresh the lockfile and the PR goes green.