Skip to content

[PR] test(logger): synchronize late registration with proven delivery - #4303

Merged
ranxianglei merged 1 commit into
ranxianglei:masterfrom
ReineLan:2026-10-22_logger-live-test
Oct 24, 2026
Merged

ranxianglei merged 1 commit into
ranxianglei:masterfrom
ReineLan:2026-10-22_logger-live-test

Conversation

@ReineLan

Copy link
Copy Markdown
Contributor

Closes #4301

Category K — CI/test infrastructure.

The late-registration logger test used non-empty file size as proof that the logger had processed its write completion callback. On Windows CI the bytes can become visible before that callback runs, so the test registers during the unproven interval and incorrectly expects the hook to fire synchronously.

Wait for the logger's proven-delivery hook before replacing it with the late subscriber. Keep the immediate synchronous assertion, clear the hook in finally, and await logger teardown before deleting its directory. Only the test fixture changes.

Validation against current master 94f75cce:

  • Deterministic before/after control: a temporary preload delays only WriteStream completion callbacks by 75 ms. Original test: 3 pass / 1 fail with the same 0 !== 1 assertion as PR [PR] fix(diagnostics): enforce final UTF-8 byte cap on 4xx dumps #4299's Windows Node 22 job 119802057572. Fixed test: 4/4 pass under the identical probe.
  • Negative control: temporarily disabling the production immediate-registration branch still fails at the intended synchronous assertion; production source restored and diff verified.
  • All six logger suites: 17/17 pass.
  • npm run typecheck, npm run build, and git diff --check: pass.
  • Two manual review passes checked hook replacement, failure cleanup, unchanged production code, and retained regression sensitivity.

The full-suite verdict remains the remote CI test lanes on this pushed head.

@ranxianglei ranxianglei changed the title test(logger): synchronize late registration with proven delivery [PR] test(logger): synchronize late registration with proven delivery Oct 22, 2026
@ranxianglei
ranxianglei merged commit 0630a56 into ranxianglei:master Oct 24, 2026
42 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

📦 Merged Build Published

This merge to master was published as 0.0.806-master.0630a56 (rolling master tag).

npm install -g billion-context@0.0.806-master.0630a56  # this exact build
npm install -g billion-context@master  # always the newest merged build

npm view billion-context@master prints the current version at any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] Logger late-registration test races the write completion callback

2 participants