Repository navigation
[PR] test(logger): synchronize late registration with proven delivery - #4303
Merged
ranxianglei merged 1 commit intoOct 24, 2026
Merged
Conversation
Contributor
📦 Merged Build PublishedThis merge to master was published as npm install -g billion-context@0.0.806-master.0630a56 # this exact build
npm install -g billion-context@master # always the newest merged build
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4301
Category K — CI/test infrastructure.
The late-registration logger test used non-empty file size as proof that the logger had processed its write completion callback. On Windows CI the bytes can become visible before that callback runs, so the test registers during the unproven interval and incorrectly expects the hook to fire synchronously.
Wait for the logger's proven-delivery hook before replacing it with the late subscriber. Keep the immediate synchronous assertion, clear the hook in finally, and await logger teardown before deleting its directory. Only the test fixture changes.
Validation against current master
94f75cce:0 !== 1assertion as PR [PR] fix(diagnostics): enforce final UTF-8 byte cap on 4xx dumps #4299's Windows Node 22 job 119802057572. Fixed test: 4/4 pass under the identical probe.npm run typecheck,npm run build, andgit diff --check: pass.The full-suite verdict remains the remote CI test lanes on this pushed head.