Skip to content

[PR] fix(#4295): mark critical update ready only when disk carries all critical fixes - #4296

Closed
ranxianglei wants to merge 1 commit into
masterfrom
2026-10-22_4295-update-ready-decision
Closed

ranxianglei wants to merge 1 commit into
masterfrom
2026-10-22_4295-update-ready-decision

Conversation

@ranxianglei

@ranxianglei ranxianglei commented Oct 22, 2026 •

Copy link
Copy Markdown
Owner

(ai: vllm-qwen/qwen3.8-27b)

Closes #4295

What

The web banner (/__bili/status + /__bili/overview updateReady), the /acp panel line and the acp_status section each branched on raw pendingRestart (disk > running). With running 0.1.178 / disk 0.1.179 / notes [0.1.180 critical, 0.1.181 routine], all three claimed a restart would deliver the critical fix — while a restart loads 0.1.179, which does not contain it. The banner associated disk 0.1.179 with 0.1.180's summary; the panel line named the span tail (0.1.181); acp_status instructed restart.

Fix: one shared decision — updateDecision() in src/update-notes.ts — rendered by all three surfaces:

  • ready iff disk ≥ every critical version in the span (a restart now provably delivers all critical fixes); version = the ACTUAL disk version;
  • available otherwise, naming the minimum version carrying the FIRST STILL-UNINSTALLED critical fix (partial installs skip criticals already on disk).

Raw pendingRestart stays on UpdateVisibility untouched (physical fact preserved); quiet routine/recommended-only spans stay silent (#1977).

Behavior changes (intended)

State Old New Why
Partial install (disk newer than running but below some critical) READY on all three surfaces, naming an unfixed disk version / span tail AVAILABLE ≥ first still-uninstalled critical restart does not deliver the fix yet — claiming ready is the #4295 defect
acp_status AVAILABLE headline "release with a critical-tier fix on the channel" "critical fix ships in V or newer" (names the minimum fixed version, same V as banner/panel) one decision across surfaces; actionable version instead of prose
READY wording when notes lag behind disk panel line named the span tail (an older version than what restart actually loads) names the actual disk version the restart delivers the disk bytes, not the notes tail

Unchanged: ready payload shape on the wire ({kind,version,summary}), i18n strings, marker prefixes (CRITICAL UPDATE READY/AVAILABLE (instance-level): ), quiet states, advisory surface (#1481 family).

Tests

New in tests/update-notes.test.ts: unit matrix for the issue scenario verbatim, multiple criticals (disk between them / at exactly the lower one), notes-lagging-disk, equal/rollback/unknown/invalid disk, quiet + clean states; plus a surface-level regression asserting acp_status and the /acp panel render AVAILABLE (never READY) in the partial-install state. Pre-existing #1870/#1977 byte-stability assertions pass unmodified.

Local: tests/update-notes.test.ts 8/8 green, npm run typecheck clean. Full-suite verdict: remote CI on this head.

查重: 无(open+closed 全量按失败签名检索;#1870/#1873、#1977、#2079/#2085、#2153 相关但覆盖原始可见性政策与 advisory 展示面,非本错配)。

…tical fixes

The banner, /acp panel line and acp_status each branched on raw
pendingRestart (disk > running), so a partially installed span rendered
"ready" for a disk version that does not contain the critical fix, and
the ready wording could name versions the restart would not deliver
(span tail on the panel line, an unfixed disk version on banner/status).

Share one decision across all three surfaces (updateDecision in
src/update-notes.ts):
- ready     iff disk >= every critical version in the span; names the
              actual disk version;
- available otherwise, naming the minimum version carrying the first
              still-uninstalled critical fix (partial installs skip
              criticals already on disk).

Behavior changes (intended, #4295):
- partial-install state now reads AVAILABLE (was READY) on all three
  surfaces;
- acp_status AVAILABLE headline now names the minimum fixed version
  ("critical fix ships in V or newer", was "release with a critical-tier
  fix on the channel");
- READY now names the actual disk version even when release notes lag
  behind the installed version (panel line previously named the span
  tail).
Raw pendingRestart fact and quiet (routine/recommended-only) states are
unchanged.
@ranxianglei ranxianglei changed the title fix(#4295): mark critical update ready only when disk carries all critical fixes [PR] fix(#4295): mark critical update ready only when disk carries all critical fixes Oct 22, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📦 Built Package Artifact

Branch: 2026-10-22_4295-update-ready-decision (67b0437)

Option A — Install this exact build (recommended)

npm install -g billion-context@0.0.5107-pr.4296.f8dfa25

This exact version is immutable and reproducible. The rolling pr tag tracks the newest test build across all PRs.

Option B — Download artifact

  1. Download the artifact from the Actions run
  2. Extract the tarball and install:
tar xzf billion-context-pr4296.tgz
npm install -g package

Install instructions are refreshed on each push.

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

(ai: vllm-qwen/qwen3.8-27b)

查重: 不重复。 这是 #4295 的修复 PR(单 commit 67b043770,base 即 issue 分析所用的 master 94f75cc);#4295 线程内已做过 open+closed 全量失败签名查重(open+closed 按 ready×diskVersion×pendingRestart 检索无第二命中),本 PR 不另起条目。

标签: bug + scope/ci + p2(与 #4295 一致——自更新面状态展示缺陷,误导用户以为重启即得 critical 修复;非数据丢失/缓存泄露类,故 p2)。

处理计划:拉取 PR head 核对代码(updateDecision 共享决策是否真的被三个面共用、raw pendingRestart 是否保留、quiet 态是否不受影响)→ 定向本地跑 tests/update-notes.test.ts → 核对远端 CI → 按八问体例给结论。CI 红或发现回归才动手改,否则只审不改。

@ranxianglei

Copy link
Copy Markdown
Owner Author

(ai: vllm-qwen/qwen3.8-27b)

Superseded by PR #4298 (owner-authored fix for the same issue #4295). The owner posted #4298 as the deliverable; per the one-issue-one-PR discipline this parallel PR is closed rather than left to conflict on the same lines (src/update-notes.ts / src/acp-status.ts).

Independent review of #4298 verified its correctness: the shared updateBannerPayload decision matches the expected behavior (ready iff disk >= every critical version in the span, naming the actual disk version; available otherwise at the first still-uninstalled critical), and all 37 targeted tests (update-notes, web-update-banner, acp-status, acp-status-marker-block, plugin-status-provenance) pass on its head locally. Reopen if you prefer this implementation instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working p2 scope/ci

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[update-ux] Critical update marked ready before its fix is installed

1 participant