Repository navigation
Conversation
Pre-ranxianglei#1145 installs managed mcp.servers.bili as a `bili mcp` shim (command bili/bili.exe, args ["mcp"]) instead of pointing at dist/zcode/mcp-entry.js. isOursZcodeMcpServer() only matched the current dist path, so the entry this installer itself wrote was classified as foreign: - inspectLanePresence() and zcodeStatus() reported "hook present, MCP face missing" for a lane that is merely stale; - applyZcodeManagedConfig() threw "already defines mcp.servers.bili owned by something else — refusing to overwrite", so `bili plugin install zcode` could never repair its own leftover. The only fix was hand-editing ~/.zcode/cli/config.json, which is exactly what an upgrade should avoid. Recognize the legacy shim as ours for OWNERSHIP (install replaces it in place with a note, remove strips it) while keeping the HEALTH check on the current dist face, so status still surfaces the stale shim with an actionable pointer. A user-authored "bili" server (other command or other args) still throws. Tests: tests/zcode-legacy-mcp-face.test.ts — upgrade in place, stale-face status, remove, foreign server refused, lookalike args refused.
Contributor
Author
|
Withdrawing this PR: the implementation in question is the reporter's own, so it is being removed to avoid duplicating/claiming it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removed