Repository navigation
[PR] fix: verif solver-less entry guard must return — clean skip instead of skip-with-error - #4272
Conversation
…e body run into skip-with-error node:test's t.skip() only marks the test skipped; it does not stop the test body. The two verif harnesses that used a bare t.skip() in their entry guard therefore kept executing after the skip and threw at the first real solveSmt2 call, emitting a hybrid 'not ok … # SKIP' TAP line with an uncaught error stack (#4140 instance-3 malformed line) even though the tally counted them as skipped. Add the missing return at both guards, matching the idiom already used by the other seven solver-gated verif tests. Solver-present runs are byte-identical (guard is true, body path untouched). Closes #4270
072a9ee to
1b8e651
Compare
(ai: vllm-qwen/qwen3.8-27b) 查重: 不重复。 本 PR 修 #4270(#4140 instance-3 家族的入口守卫面)。与兄弟单机制不同、互补:#4195(win32 双盘路径 join,df5e82412 已合入 master)、#4269(测试中段 solver 丢失加固,open PR,hunk 与本 PR 不重叠)。近期无其他 PR 触碰同一对 guard 行。 标签: bug + scope/ci + p3(测试脚手架日志形状缺陷:无求解器时产出 skip-with-error 混合条目;仅影响降级路径,有效覆盖两种环境下都不变。) 独立复审结论(非复读 issue): 验证过什么
行为变更披露(旧→新):仅无求解器环境——混合 skip+error 条目(本地 failing-tests 段 / CI 八问
与 #4269 的关系确认:两者 hunk 不重叠(本 PR:generic 入口 :50 / ingress 入口 :52;#4269:generic 中段 ~:141+),合并顺序相互独立,#4195 已在 master 就位——三个凑齐即该家族闭环。 状态:rebased head |
📦 Built Package ArtifactBranch: Option A — Install this exact build (recommended)npm install -g billion-context@0.0.5079-pr.4272.d3e1fddThis exact version is immutable and reproducible. The rolling Option B — Download artifact
tar xzf billion-context-pr4272.tgz
npm install -g packageInstall instructions are refreshed on each push. |
(ai: vllm-qwen/qwen3.8-27b) 来源: PR #4272 (#4272) 分析 CI 失败时发现 新实例 — issue1452 socket-hardening 的 kat-reap 子测试墙钟截止被高负载击穿现象:run 39735646915(PR #4272 head 证据链(负载误报,非 reap 缺失):
家族归属:与 #3420/#3449/#1607/#1697/#1770 同族(issue1452 文件内墙钟假设在高负载 Windows runner 上被击穿)。#3421+#3435 已把先中招的 retired-stall-guard 子测试(:411+,首字节等待)改为事件循环 tick 计数(对「runner 冻结时墙钟预算与 round-trip 一起冻结」免疫),但本文件的其余墙钟预算仍未转换——本次命中的 :281(kat-reap 6000ms 与本 PR 无关性:PR #4272 仅给两个 verif 测试入口守卫补 建议修复方向(排期由 owner 定):按 #3435 同款做法把 kat-reap 子测试(:265–283)的等待从墙钟 |
(ai: vllm-qwen/qwen3.8-27b) CI 终审跟进(上条 review 承诺的绿确认):
最终判定:可合并。 代码面 2 files × 1 line(回归清点见首条 review);行为变更仅降级路径日志形态(solver-less 环境由 skip+error 混合条目 → 干净 skip 行,solver-present 字节级不变);无新配置/缓存/设计方向变化。合并按规则留给人工:#4272 |
📦 Merged Build PublishedThis merge to master was published as npm install -g billion-context@0.0.748-master.d5fc17b # this exact build
npm install -g billion-context@master # always the newest merged build
|
Closes #4270. Part of the #4140 instance-3 family (solver-less runs emitting malformed TAP lines).
Problem
node:test's
t.skip()only marks the test skipped — it does not stop the test body. The two verif harnesses that used a baret.skip(...)in their entry guard therefore kept executing after the skip and threw at the first realsolveSmt2call:# SKIPline + correct# fail 0 / # skipped Ntally, AND a trailing✖ failing tests:section listing the same test with an uncaught stack;not ok … # SKIP no SMT solver available— the malformed line that falls out of every tally bucket (Windows CI test shards go red randomly: two flake signatures (cleanup rmdir race in #1952 lease test, egress-fuse e2e hang in #4079) #4140 instance 3).The throw is not itself a path bug: it is simply the first consequence of the body continuing to run (locally: missing build artifact; on windows CI: doubled-drive ENOENT per #4195; in this repro:
no solver available).Fix
2 lines: add the missing
returnat both entry guards, matching the idiom already used by the other seven solver-gated verif tests (verif-bug3691-oscillation:36,verif-symbolic-smoke:42/58/81,verif-bug3676-wire-reorder:106,verif-induction-append-stability:51,verif-bug3769-orphan-window:53):tests/verif-generic-append-stability.test.ts:50tests/verif-responses-ingress.test.ts:52Behavior changes (old → new)
ok … # SKIP no SMT solver available,# fail 0 / # skipped 2) instead of a hybrid skip+error entry. Intended log-shape fix in the degraded path only; effective coverage is unchanged either way (the bodies were never actually running there).Relationship to sibling tickets
verif/symbolic.tsloadModule/loadImportGraph): different mechanism — even with the path fixed, the body would still continue into a missing solver and emit skip-with-error. Both fixes are needed; this PR owns the guard return.Verification (local, targeted)
not ok … # SKIPplus an uncaughtno solver availablestack attests/verif-generic-append-stability.test.ts:141andtests/verif-responses-ingress.test.ts:157.ok … # SKIP no SMT solver available×2, no error block,# fail 0 / # skipped 2.npm run typecheckgreen. Full-suite verdict = remote CI.No new config/env/CLI surface. Test-harness-only change.