Repository navigation
[PR] feat: DSH shell.overlay upstream-unavailable pill (#4254) - #4267
Closed
ranxianglei wants to merge 2 commits into
Closed
ranxianglei wants to merge 2 commits into
ranxianglei wants to merge 2 commits into
Conversation
Defect 2 render half of #4254, pairing with the GET /__bili/upstreams read surface shipped in #4257. bili's DSH client registers a frame-level shell.overlay slot that polls /__bili/upstreams every 10s and renders one row per unreachable upstream (host:port, kind, errno code, consecutive-failure tally, and a retry ETA while the circuit is open); it returns null while every upstream is reachable, so the banner auto-dismisses when circuits close + alerts clear. - Display identity is the forwarded host:port (bili is a transparent pipe); provider/model reverse lookup stays host-side (DSH reads its own baseURL). - Defensive parse of the report never throws: a broken health report cannot break the DSH client. - Purely additive UI, no request-path changes; deferred injection is fail-open on hosts whose build lacks the shell.overlay slot. - i18n zh/en in sync; deterministic render test (populated / healthy / multi-host).
Contributor
📦 Built Package ArtifactBranch: Option A — Install this exact build (recommended)npm install -g billion-context@0.0.5073-pr.4267.fa758a8This exact version is immutable and reproducible. The rolling Option B — Download artifact
tar xzf billion-context-pr4267.tgz
npm install -g packageInstall instructions are refreshed on each push. |
Owner
Author
…rse gate The 'defensive parse never throws' claim had no negative test row — only the empty-report case. Add a mixed garbage list (non-object entry, host-less entry, empty-host entry alongside one valid entry) asserting the banner keeps only the well-formed row and counts it in its header.
Owner
Author
(ai: vllm-qwen/qwen3.8-27b) 标签: Review 结论(独立审过 diff、跨 PR 契约与 CI,未照抄 PR 描述)审过的既有行为清单及结论:
顺手小修(已直接提交到本分支):「defensive parse never throws」这个降级门原来只有正向用例(空报告),缺负向断言行——按 #3617 双向断言纪律补了一行混合垃圾列表(非对象条目 / 无 host 条目 / 空 host 条目 + 1 条合法数据),断言只有合法行存活且 header 只数幸存者。commit 未验证项(作者已声明,我确认属实): live dsh 构建里的最终视觉验证(slot 契约 + 措辞)需要 reporter 确认——本环境无 live dsh,不冒认。 结构化八问
判定:可合并。 顺序上建议 #4257 先合(横幅依赖其端点;早于它合入也安全——inert 不误报)。合并由人来执行。 |
Owner
Author
This was referenced Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defect ② render half of #4254 (the DSH-side banner), pairing with the read surface shipped in #4257.
What
bili's DSH client (
src/agent/dsh-native-client.ts) now registers a frame-levelshell.overlayslot that:GET /__bili/upstreams([PR] Make upstream-failure egress diagnosable (#4254): informative error, 503+Retry-After on circuit-open #4257) every 10s;host:port · kind [errno] ×count · ~Ns until retry(the retry ETA appears only while that host's circuit is OPEN);Division of labor (per the #4254 design thread): the frame-level banner says which upstream is down; the in-conversation error (#4257 defect ①) says why yours failed this time. Both coexist.
Boundaries / decisions
baseURL); this draft deliberately does NOT attempt it.shell.overlayslot (same discipline as the existing session Context tab).Deps / sequencing
Depends on #4257 (the endpoint). The banner is inert until that lands (a 404 → empty report → null). Safe to review now; merge after #4257.
Behavior changes
Additive only — one new optional slot registration plus one loopback-gated read route consumed client-side. No existing behavior, wire shape, config, or persistence changes. Config surface: None.
Tests
Deterministic render test added to
tests/dsh-settings-ui.test.ts(populated / healthy-auto-dismiss / multi-host), exercising the real bundled client through the existing vm harness. Typecheck + fulldsh-settings-uisuite (17/17) + production build all green locally on this head.Not verified here
The final visual check in a live dsh build (slot contract + wording) is the reporter's to confirm — this environment has no live dsh. Flagging explicitly rather than claiming it.
Part of #4254 (renders the ② half; pairs with #4257).