Repository navigation
[PR] fix: merge gates no longer block on twice-drained CI shards (#3665 round 3, #4212) - #4213
Conversation
📦 Built Package ArtifactBranch: Option A — Install this exact build (recommended)npm install -g billion-context@0.0.5006-pr.4213.39eec5aThis exact version is immutable and reproducible. The rolling Option B — Download artifact
tar xzf billion-context-pr4213.tgz
npm install -g packageInstall instructions are refreshed on each push. |
|
(ai: zhipuai-lb/glm-5.3) 本 PR 的 CI 自己完成了端到端验证: job 最终 success(42/42 全绿)。对照:同样的两次-drain 形态在修复前(昨天 PR #4206 与 master 44409dd)一律 exit 1 卡死合并门。也就是说——修门禁的这个 PR 差点被它要修的问题卡红,而它自己的新路径把它放行了,警告注释里点名了未跑完的测试。 供 review 时参考:改动面就两个脚本 + 一个测试文件 + .d.mts;分类/放行全部纯函数化并有双向单测;push/schedule/dispatch 与本地行为不变。 |
(ai: vllm-qwen/qwen3.8-27b) 先答两条未回应的评论,再给独立复核结论。 Floor 1(github-actions 构建产物通知):标准的每次 push 生成的不可变构建说明( Floor 2(GLM 的端到端验证声明):已独立核实,属实。我拉了分支 查重:不重复。本 PR 修 #4212(#3665 round 3);#4206 是被它卡红的受害者(release PR),不是并列修复;仓库内无其它改 CI 门禁脚本的在途 PR。 结构化八问(独立复核,非复读 issue/Floor 2)我逐行读了
行为变更披露复核:OP 已披露旧( 判定可合(human merge)。改动面小且聚焦(2 脚本 + 一处非阻断观察(不拦、不另开 issue): |
b31f766 to
03a8598
Compare
|
已 rebase 到 master@07888d74(2026-10-23)。冲突两处,均为合并保留:
|
Fixes #4212 (#3665 round 3)
问题
A CI shard whose only losses are event-loop-drain cancellations (
fail 0 / cancelled N, zero assertion failures) goes red after the #3710 same-runner retry reproduces the drain — and nothing ever draws the "fresh runner" the closing message asks for. PR #4206 sat red ~40 min on exactly this (owner had to merge the release manually); the drain reproduced on 5 of 6 win22 machines over ~2h (incl. a fresh rerun machine at 17:40–17:57) while the overlapping 17:33 scheduled full matrix went green on the same code + same node v22.23.3 — a machine lottery the repo cannot fix (root cause stays open under #3665).修法
scripts/run-ci-tests.mjs: when the first phase AND the same-runner retry are BOTH the pure drain shape (existing classifier, unchanged) AND the run is a merge-gating event (GITHUB_EVENT_NAME=pull_request/merge_group), the phase passes with a loud::warningnaming the cancelled tests (DRAIN-PASS) instead ofexit 1. Availability first (§7.3): a zero-assertion-failure infrastructure flake must not block merges.Strictness preserved (nothing else changes):
push/schedule/workflow_dispatchkeep failing — each draws a fresh runner, so they are the cross-runner probe: a genuinely deterministic orphaned-promise regression that slips the PR gate goes red on the push run (minutes) or the 30-min scheduled cadence.GITHUB_EVENT_NAME) keep failing — unchanged behavior outside GitHub.shouldDrainPassis strict by construction).行为变更披露
exit 1(红),日志提示人工 rerun。::warning+DRAIN-PASS日志 +exit 0(绿,带警告)。config surface
无新增:读 runner 原生
GITHUB_EVENT_NAME,非新 env/config 面。测试
tests/ci-runner-failure-shapes.test.ts+6(每门双向断言,#3617):twice-drained×merge-gate 放行;probe 事件/本地严格;非 twice-drained 组合不放行;drain 测试名提取(concrete/swallowed 不匹配);describeDrainPass文案(双轮计数、点名、无 "genuine failure")。定向 19/19、release-ci-gate 16/16、unused-exports clean、typecheck clean;全量以本分支远程 CItestlanes 为准。