Skip to content

[PR] docs: refresh stale comments after #3900 / kernel 0.0.151 - #4203

Open
ranxianglei wants to merge 2 commits into
masterfrom
2026-10-21_stale-comments-3900
Open

ranxianglei wants to merge 2 commits into
masterfrom
2026-10-21_stale-comments-3900

Conversation

@ranxianglei

@ranxianglei ranxianglei commented Oct 21, 2026 •

Copy link
Copy Markdown
Owner

(ai: zai/glm-5.3)

Comment-only follow-up from the v0.1.204 release review (PR #4190). Re-scoped after the owner's #4198 revert of #3900 landed mid-review:

No behavior change (comments only); typecheck clean.

Fixes #4202

- budget.ts: the #453 output-budget clamp still runs only on the rebuilding
  lanes (openai/responses/google), but its old rationale ("Anthropic enforces
  its input limit independently of max_tokens") stopped being true with #3900's
  universal output-headroom reservation — reword to the current boundary.
- wire-drop-warn.ts: kernel floor is 0.0.151 in kernel/package.json, not 0.0.150.

Fixes #4202
@ranxianglei ranxianglei changed the title docs: refresh stale comments after #3900 / kernel 0.0.151 [PR] docs: refresh stale comments after #3900 / kernel 0.0.151 Oct 21, 2026
@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

📦 Built Package Artifact

Branch: 2026-10-21_stale-comments-3900 (f08bf3e)

Option A — Install this exact build (recommended)

npm install -g billion-context@0.0.4998-pr.4203.239d3d6

This exact version is immutable and reproducible. The rolling pr tag tracks the newest test build across all PRs.

Option B — Download artifact

  1. Download the artifact from the Actions run
  2. Extract the tarball and install:
tar xzf billion-context-pr4203.tgz
npm install -g package

Install instructions are refreshed on each push.

The original "Non-Anthropic only" rationale is accurate again now that
#3900's universal reservation was reverted in #4198 — keep that, and note
the revert so the history is traceable.
@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

(ai: vllm-qwen/qwen3.8-27b)

查重: 无。检索 open+closed issue/PR(关键词 stale comment / budget / wire-drop-warn / 0.0.150),无其他条目处理这两处注释漂移;本 PR 的立项依据就是 #4202,对应关系正确。

标签: pr + scope/wiring + p3(纯注释刷新,wire/请求管道域文件,无行为影响)。

这是 [PR] 类唤醒,未重做工作——拉取分支 2026-10-21_stale-comments-3900(head f08bf3e23)独立核对了代码与 CI。注意:issue 正文描述的是第一版措辞(按 #3900 已生效写的),分支上第二个 commit f08bf3e23 已在 #4198 revert #3900 之后把注释重新收回到当前边界;以下审核针对最终状态。

diff 事实核对(逐项对过代码,非照抄正文):

回归审查:触碰路径承担的既有行为清单为空(注释不参与运行);高危模式(语义漂移/fail-fast 变吞错/阈值时序输出格式变化)逐项不适用。注释内容与代码事实的一致性已按上面三项逐条钉住。

CI(head f08bf3e):除 test (windows-latest, 22, 1) 外全绿(typecheck/static-gates/kernel-guard/version-guard/lane-guard 等全过)。该红 job 日志显示 pass=3905 fail=0 cancelled=2,harness 自述「zero-assertion-failure drain signature ... persistent condition on this runner ... rerunning the job draws a fresh runner (#3665)」——是 #3665 类 Windows runner 挂死/排空抖动,零断言失败,与纯注释 diff 无关;且 master 自己的 windows 车道同样红(c87185a 上 test (windows-latest, 22, 3) failure),属存量 flaky。

基线:分支落后 master 4 个提交(v0.1.204 发版 bump + #4198 revert),这 4 个提交均不触碰本 PR 的两个文件,GitHub 判定 mergeable=True、可干净合并;注释级 PR 无需 rebase,合并时自然收敛。


结构化八问:

  1. 是什么问题:两处源码注释与现实脱节——budget.ts 的 plugin mode: no hard backstop when the agent ignores the compress nudge — context grows past the window and upstream 400s #453 clamp 理由还停留在 [BUG] acp-proxy upstream HTTP 400: Request with 1,198,269 tokens exceeds the model's 1,048,576 token limit, consistently | [BUG] acp-proxy upstream HTTP 400:请求 1,198,269 tokens 超过模型上限 1,048,576,一直复现——是插件压缩未生效,还是 DSH 的问题? #3900 之前的语义,wire-drop-warn.ts 引用的 kernel 下限停在 0.0.150(实际 0.0.151),读代码的人会被误导。
  2. 什么原因导致的:机制先行、文档没跟——[BUG] acp-proxy upstream HTTP 400: Request with 1,198,269 tokens exceeds the model's 1,048,576 token limit, consistently | [BUG] acp-proxy upstream HTTP 400:请求 1,198,269 tokens 超过模型上限 1,048,576,一直复现——是插件压缩未生效,还是 DSH 的问题? #3900 改变预留语义后又经 [PR] Revert "#3900: reserve output headroom on every wire (drop the Anthropic exemption)" (#4184) — unblock v0.1.204 #4198 回滚、kernel 版本推进到 0.0.151,注释在两次演进中都没同步(v0.1.204 发布评审发现的遗留)。
  3. 影响范围与严重程度:零用户面影响,仅内部可读性;误读注释可能让后续维护者对 clamp 适用车道产生错误预期,程度轻微(p3)。
  4. 怎么修复的:只改注释对齐当前边界——clamp 明确「重建车道 only + anthropic 豁免([PR] Revert "#3900: reserve output headroom on every wire (drop the Anthropic exemption)" (#4184) — unblock v0.1.204 #4198 后恢复)」,kernel 下限改 0.0.151;第二笔 commit 专门跟进 [PR] Revert "#3900: reserve output headroom on every wire (drop the Anthropic exemption)" (#4184) — unblock v0.1.204 #4198 revert 重新收口措辞。
  5. 是否有回归问题:无。无可执行代码变更;新注释的每一条事实主张(三个调用点、anthropic 不导入 clamp、shouldReserveOutputHeadroom 现值、kernel 版本号)都独立对照代码核实过。
  6. 是否破坏缓存:不涉及。
  7. 是否改了设计方向:不涉及。
  8. 是否引入了新的配置:不涉及。

判定:可合并。 唯一红 check 是 #3665 类 Windows runner 抖动(零断言失败,master 同车道亦红),不构成阻塞;如需洁癖绿,重跑该 job 即可。

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: stale comments after #3900 universal headroom + kernel 0.0.151 (budget.ts, wire-drop-warn.ts)

1 participant