Repository navigation
Conversation
(ai: vllm-qwen/qwen3.8-27b) 查重: 不重复。 open+closed 检索(open PR 提及 #4121 仅本 PR 一条;标题含 media 的在途 PR:#4075 是存储侧 media CAS 分片、#2614 是 kernel 侧 Google wire fileData/inlineData 识别——子系统和机制都不同)。原 issue #4121 自身已做过查重(失败签名 = bytes/4 原始字节口径 + oversize 本地拒 + 媒体/base64),本 PR 是该 issue 的唯一修复。 标签: 初审印象(深度 review 进行中,稍后按八问补完整结论):
正在本地跑定向测试(opencode-native / dsh-native / issue3654-health-probe-three-state)+ typecheck,随后给结构化八问结论。 |
(ai: vllm-qwen/qwen3.8-27b) Review 结论(PR #4158 → Fixes #4121)可合并 —— pushed head 结构化八问
测试有效性18 个新 route 测试满足 #3617 双向断言纪律:正向(三种 wire 形状 openai/responses/anthropic × 两种拒绝原因均放行)+ 负向(text / mixed / pasted-as-text / malformed 四类仍拒绝)。我独立做了修复前回放(pr4158^ == master 叠放 PR 测试文件):恰好六个 image 子测试失败、四个 guard case 全过——与 PR 描述一致,测试有牙,同时钉住修复前缺陷与修复后不变量。既有「proxy down + provably over window」route 测试继续通过。 diff 整洁度五个文件(+117/-54),每一行都服务于本目的;reference/architecture.md 按 AGENTS.md 模块图规则同步更新;无空白 churn、无无关改动。 其他核查
判定:可合并。 全部 CI 车道在 pushed head |
Fixes #4121
OpenCode V2's direct fallback counted inline media as text (
raw bytes / 4), so an image-heavy request could be refused locally while the proxy was unavailable or busy. Recheck would-refuse bodies using core-text bytes after subtracting structurally identified inline media.Move the existing DSH media-byte walker verbatim into a shared, dependency-free module and preserve its DSH export. Both OpenCode refusal branches use the corrected floor. The declared model window is unchanged: this does not introduce DSH's 1M-token floor. Over-window text, text mixed with media, pasted data URLs, malformed-body fallback, and original request bytes retain their existing behavior.
Validation:
opencode-native,dsh-native, andissue3654-health-probe-three-statetest files pass.npm run typecheck,npm run build, unused-export and test-import-graph gates pass.No kernel, configuration surface, persistence format, or wire payload changes. Real OpenCode/model-provider end-to-end testing was not run; full regression remains subject to upstream CI.