Repository navigation
[PR] fix(verif): anthropic round-trip harness red on every non-author machine (CI shards 5/6 failing) | verif anthropic 判官在作者机器之外必挂,修复 CI 红 - #4089
Closed
ranxianglei wants to merge 1 commit into
Conversation
- KP: repo-relative kernel/src/wire/anthropic.ts (was a hardcoded author-machine tmp path -> ENOENT on every other machine/runner) - both solver tests: sibling-style no-solver t.skip guard (they would otherwise throw 'no solver available' once the path resolves) - drop leftover debug scaffolding (console.log DBG blocks + dead helpers) - engine: inlineCall bound default params against innerState declared after the binding loop (TDZ ReferenceError when a defaulted param is omitted); declare innerState before param binding - simplify tautological 'fn.body ? : fn.body' to fn.body
Contributor
📦 Built Package ArtifactBranch: Option A — Install this exact build (recommended)npm install -g billion-context@0.0.4871-pr.4089.dd597b5This exact version is immutable and reproducible. The rolling Option B — Download artifact
tar xzf billion-context-pr4089.tgz
npm install -g packageInstall instructions are refreshed on each push. |
Owner
Author
|
还是失败 |
This was referenced Oct 21, 2026
Owner
Author
|
(ai: vllm-qwen/qwen3.8-27b) 状态同步:#4084(绝对路径修复 + anthropic haveSolver gate)已合入 master(现为 建议:rebase 到最新 master 解冲突。rebase 后本 PR 的独立增量 = |
This was referenced Oct 21, 2026
Closed
Owner
Author
|
(ai: zhipuai-lb/glm-5.3) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4088
The anthropic wire round-trip judge added today in d22508b (#4071 batch) cannot run on any machine other than the author's, which puts 5 of 6 ci:full test shards red on master @ 56a0f5a. One failure domain, three sub-defects:
KPpointed at a tmp checkout on the author's machine (/home/dog/tmp/bili-verif2/kernel/src/wire/anthropic.ts) → ENOENT on every other runner. Now repo-relative, matching the sibling-test convention (resolve(import.meta.dirname, "../kernel/src/wire/openai.ts"), cf. tests/verif-bug3676-wire-reorder.test.ts:26).t.skipprobe as tests/verif-symbolic-smoke.test.ts:41-42.inlineCallevaluated default-parameter initializers againstinnerState, whose declaration sat AFTER the param-binding loop →ReferenceError: Cannot access 'innerState' before initializationwhenever an inlined function has a defaulted param omitted at the call site (reachable through the real entryanthropicToCore; reproduced with a translation probe). Declaration moved before the loop. Incidental cleanup: tautologicalfn.body ? fn.body : fn.body→fn.body; leftover debug scaffolding in the test file (DBG console.log blocks + unreferenced helpers) removed.Verification (targeted, local):
node --import tsx --test tests/verif-wire-anthropic-roundtrip.test.ts: 3/3 pass — solver present locally, so the full UNSAT assertions actually rantests/verif-subset-guard.test.ts+tests/verif-symbolic-smoke.test.ts: 5/5 passnpm run typecheck: cleanBehavior changes: none for product code. Test-infra only: on solver-less environments the two solver tests now SKIP instead of throwing (previously: ENOENT crash). No config/persistence/wire surface touched.