Repository navigation
[PR] fix(ci): close store1 before dropping index.db in #3769 pooled-bare-load — Windows EBUSY - #4087
Merged
Merged
Conversation
…oad — Windows EBUSY The cold-restore simulation rmSync's index.db while store1's sqlite handle is still open; Windows refuses the unlink with EBUSY, failing the test on every windows shard (the half of the #4076 red that the #4077 pin could not fix). Close store1 first, same discipline as the plugin-fork cold restores; the finally block's closeQuietly() pass tolerates the double close.
Contributor
📦 Built Package ArtifactBranch: Option A — Install this exact build (recommended)npm install -g billion-context@0.0.4868-pr.4087.24f74e8This exact version is immutable and reproducible. The rolling Option B — Download artifact
tar xzf billion-context-pr4087.tgz
npm install -g packageInstall instructions are refreshed on each push. |
Owner
Author
|
(ai: zhipuai-lb/glm-5.3)
|
This was referenced Oct 21, 2026
Contributor
📦 Merged Build PublishedThis merge to master was published as npm install -g billion-context@0.0.701-master.9a97169 # this exact build
npm install -g billion-context@master # always the newest merged build
|
This was referenced Oct 21, 2026
Merged
Closed
Zhishulo
pushed a commit
to Zhishulo/billion-context
that referenced
this pull request
Oct 21, 2026
…4087 cleared the master red)
This was referenced Oct 21, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(ai: zhipuai-lb/glm-5.3)
#4077 的补完(它已合并,这是 post-merge supplement)。Fixes 的 #4076 家族残留:master windows 分片仍红。
现象
master(56a0f5a 起)与 #4084 的
test (windows-latest, 22, 1)红:根因
该测试模拟「index 丢失」时
rmSync(index.db/-wal/-shm),但store1的 sqlite 句柄还开着——Windows 拒绝 unlink 打开中的文件(EBUSY),Linux 无此限制所以本地/CI ubuntu 全绿。#4077 只修了 ubuntu 侧(存储模式钉 full)和 plugin-fork 侧(先 closeQuietly 再删),漏了这个文件的同类 rmSync——它就是 #4076 红的 windows 半边,一直没被发现是因为 ubuntu 半边先修掉后 windows 分片才单独暴露。改动(1 文件 3 行)
删库前先
store1.closeQuietly()(与 plugin-fork 冷恢复同款纪律;finally 里的统一 closeQuietly 容忍二次关闭)。验证
合并后 #4084(verif 修复)rerun 即应全绿。