Repository navigation
[PR] docs(dsh): document roster-conditionality of the four Web preset gate rows (#3962) - #4034
ranxianglei wants to merge 1 commit into
Conversation
📦 Built Package ArtifactBranch: Option A — Install this exact build (recommended)npm install -g billion-context@0.0.4969-pr.4034.074ef30This exact version is immutable and reproducible. The rolling Option B — Download artifact
tar xzf billion-context-pr4034.tgz
npm install -g packageInstall instructions are refreshed on each push. |
(ai: vllm-qwen/qwen3.8-27b) 查重: 不重复 —— 本 PR 即 #3962 的本仓文档切片(正文 标签: 当前状态:PR 与 master 冲突( |
… rows (#3962) dsh.bundle.patch.yml gates four Web presets (preset-standard / preset-ptc / preset-minimal / preset-cordis) on ids that exist only in the FACTORY roster. A profile that replaces them with its own ids matches none of the four rows and dsh logs `patch: entry <id> not found` at startup — buried in the loader logger, surfaced nowhere else. From the outside the rows read as "working" when they are silent no-ops. State the roster-conditionality in the patch file itself (the shipped artifact users inspect): the miss is NOT harmless — an ungated custom preset resolves by import order and may win the race against the overlay middleware register, leaving its compaction-basic AND command-compact rows armed (timing window; worst case a dsh checkpoint outside bili destroys the compression substrate, #3354/#1772/#1729). Mitigation: self-gate each custom preset entry with inject:[biliBasicCompactionPolicy]. Self-check: grep the dsh loader log for `patch: entry ... not found`. Do-not-delete note kept: factory-roster profiles get a real ordering fence from these rows. The launcher overlay carrier (writeDshAcpPatch) mirrors the same clause so the two carriers stay in sync (file's own discipline + #3354 carrier-agreement test). Comments/string-literal only — zero behavior change: no functional patch row is added, removed, or reworded. Rebased onto master after #3729 landed (gate moved to its own always-on bili-compaction-gate entry; structural matching + coverage telemetry shipped there). The four gate rows are unchanged on master, and structural matching widens WHICH entries the transform reaches but not WHEN the middleware registers relative to an ungated preset's resolution — the timing window this note documents persists, so the text needs no rewording. Targeted suites green locally: issue3354-dsh-compaction-disable (incl. two-carriers-agree), issue2605-dsh-retry-patch, issue4147-dsh-overlay-structural (16/16). Full typecheck/test on CI. References #3962
66567b9 to
41c1e31
Compare
(ai: vllm-qwen/qwen3.8-27b) 结论先行PR 方向正确、内容准确、零行为变更,可合(待 CI 全绿)。审核中发现 master 在 PR 切出后合入了 #3729(gate 入口重构),与 结构化八问
验证
判定:可合——CI 转绿后请人工合并。 |
(ai: vllm-qwen/qwen3.8-27b) CI 状态补充:新 head 对本 PR 的判定不受影响:改动为注释/字符串字面量级(零行为变更、零类型影响),本地定向套件 16/16 绿(含 two-carriers-agree 与 #4147 结构化解析验证)。若 owner 愿意在 CI 转绿前先行合并,风险面仅在于 CI 尚未背书;runner 空出来后队列会自动消化,届时结果会留在 PR 上可查。 |
(ai: vllm-qwen/qwen3.8-27b) 收尾汇总(本线程已有两条实质回复,此为最终状态确认): 做了什么
结果
等待人工合并。 |
|
(ai: zhipuai-lb/glm-5.3) 孤儿票清理:标题指向的 issue 已关闭,修复已由其他路径落地。关单;误判请 reopen。 |
What & why
dsh.bundle.patch.ymlgates four Web presets (preset-standard/preset-ptc/preset-minimal/preset-cordis) on ids that only exist in the factory roster. A profile that replaces those presets with its own ids (e.g. a desktop profile's twelve local presets) has none of them, so all four rows match nothing. dsh logspatch: entry <id> not foundat startup — buried in theloaderlogger, never surfaced in the plugin inventory / settings UI / any diagnostic. From the outside the four gate rows read as "working" when they are silently no-ops.#3962 reports this observability gap. This PR lands the decision-free in-repo slice: make the roster-conditionality visible in the patch file itself (the shipped artifact users inspect).
Change
dsh.bundle.patch.yml: add a comment block above the four gate rows stating they target the FACTORY roster ONLY; that a custom-roster profile skipping them is a correctness risk, not a harmless no-op (an ungated custom preset resolves by import order and may win the race against the overlay middleware register, leaving its compaction-basic AND command-compact rows armed — timing window; worst case a dsh checkpoint outside bili destroys the compression substrate, See how to integrate the plugin that automatically disables dsh compression. | 自动关闭 dsh 压缩的插件看如何集成 #3354/dsh.bundle.patch.yml禁用自动压缩在 web profile 下静默失效 #1772/nudge 死锁无检测:同一 session 交替收到两种结构互斥的请求流(巨型单消息 ↔ 多轮)时不告警 #1729); the mitigation (self-gate each custom preset entry withinject: [biliBasicCompactionPolicy]); why factory-roster profiles are unaffected (the real basic-compaction stand-down is the globalinternal/configmiddleware insrc/agent/dsh-compaction-disable.ts, id-independent; these rows add the ordering fence); and how to self-check (grep the dsh loader log forpatch: entry ... not found). Also notes "do not delete — factory-roster profiles get a real ordering fence from them."src/launcher.ts(writeDshAcpPatch): mirror a one-line clause into the launcher overlay carrier so the two carriers stay in sync (per the file's own keep-in-sync discipline and the See how to integrate the plugin that automatically disables dsh compression. | 自动关闭 dsh 压缩的插件看如何集成 #3354 carrier-agreement test).Comments / string-literal only — zero behavior change. No functional patch row is added, removed, or reworded.
Rebase note (post-#3729): rebased onto current master, where #3729 landed after this PR was cut (gate moved to its own always-on
bili-compaction-gateentry; structural matching + coverage telemetry shipped there). The four gate rows are unchanged on master; structural matching widens WHICH entries the transform reaches, not WHEN the middleware registers relative to an ungated preset's resolution — so the timing window documented here persists and the text needed no rewording. The wording evolution across the three pre-rebase commits (harmless no-op → correctness risk → timing window) is folded into the single final-state commit.Scope note (not closed by this PR)
The runtime signal the reporter actually wants — an aggregated per-bundle apply count in the dsh plugin inventory / a diagnostic command, or an
optional:marker the loader understands — lives in DSH's loader + UI (cross-repo) and needs owner approval before anything is submitted externally. That slice stays tracked in #3962 pending direction. This PR is deliberately scoped to what this repo can do unilaterally.Verification
tests/issue3354-dsh-compaction-disable.test.ts(including the two-carriers-agree assertion) +tests/issue2605-dsh-retry-patch.test.ts+tests/issue4147-dsh-overlay-structural.test.ts— 16/16 pass.References #3962