Skip to content

[PR] docs(dsh): document roster-conditionality of the four Web preset gate rows (#3962) - #4034

Closed
ranxianglei wants to merge 1 commit into
masterfrom
2026-10-21_dsh-bundle-patch-roster-docs
Closed

ranxianglei wants to merge 1 commit into
masterfrom
2026-10-21_dsh-bundle-patch-roster-docs

Conversation

@ranxianglei

@ranxianglei ranxianglei commented Oct 20, 2026 •

Copy link
Copy Markdown
Owner

What & why

dsh.bundle.patch.yml gates four Web presets (preset-standard / preset-ptc / preset-minimal / preset-cordis) on ids that only exist in the factory roster. A profile that replaces those presets with its own ids (e.g. a desktop profile's twelve local presets) has none of them, so all four rows match nothing. dsh logs patch: entry <id> not found at startup — buried in the loader logger, never surfaced in the plugin inventory / settings UI / any diagnostic. From the outside the four gate rows read as "working" when they are silently no-ops.

#3962 reports this observability gap. This PR lands the decision-free in-repo slice: make the roster-conditionality visible in the patch file itself (the shipped artifact users inspect).

Change

Comments / string-literal only — zero behavior change. No functional patch row is added, removed, or reworded.

Rebase note (post-#3729): rebased onto current master, where #3729 landed after this PR was cut (gate moved to its own always-on bili-compaction-gate entry; structural matching + coverage telemetry shipped there). The four gate rows are unchanged on master; structural matching widens WHICH entries the transform reaches, not WHEN the middleware registers relative to an ungated preset's resolution — so the timing window documented here persists and the text needed no rewording. The wording evolution across the three pre-rebase commits (harmless no-op → correctness risk → timing window) is folded into the single final-state commit.

Scope note (not closed by this PR)

The runtime signal the reporter actually wants — an aggregated per-bundle apply count in the dsh plugin inventory / a diagnostic command, or an optional: marker the loader understands — lives in DSH's loader + UI (cross-repo) and needs owner approval before anything is submitted externally. That slice stays tracked in #3962 pending direction. This PR is deliberately scoped to what this repo can do unilaterally.

Verification

  • Targeted suites green locally: tests/issue3354-dsh-compaction-disable.test.ts (including the two-carriers-agree assertion) + tests/issue2605-dsh-retry-patch.test.ts + tests/issue4147-dsh-overlay-structural.test.ts — 16/16 pass.
  • Global typecheck/test left to CI (comment-only change, zero type impact).

References #3962

@ranxianglei ranxianglei changed the title docs(dsh): document roster-conditionality of the four Web preset gate rows (#3962) [PR] docs(dsh): document roster-conditionality of the four Web preset gate rows (#3962) Oct 20, 2026
@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

📦 Built Package Artifact

Branch: 2026-10-21_dsh-bundle-patch-roster-docs (66567b9)

Option A — Install this exact build (recommended)

npm install -g billion-context@0.0.4969-pr.4034.074ef30

This exact version is immutable and reproducible. The rolling pr tag tracks the newest test build across all PRs.

Option B — Download artifact

  1. Download the artifact from the Actions run
  2. Extract the tarball and install:
tar xzf billion-context-pr4034.tgz
npm install -g package

Install instructions are refreshed on each push.

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

(ai: vllm-qwen/qwen3.8-27b)

查重: 不重复 —— 本 PR 即 #3962 的本仓文档切片(正文 References #3962),open+closed 检索无其他同主题条目。注意时间线:#3729(含 #4147 结构匹配修复 + #3962 telemetry/coverage note)已于 10-21 15:28 合入 master,晚于本 PR 的 base —— 我已核对 master 现状后确认本 PR 内容仍然成立(四行门仍只认出厂 id;结构匹配扩大的是「哪些条目被转换」,没消除「未加门的自定义预设可能在中间件注册前解析」这个时序窗口),注释口径与 master 代码事实一致,无需改写。

标签: dsh · scope/docs · p3(纯注释/字符串字面量变更,零行为变更;纯观测文档)。

当前状态:PR 与 master 冲突(mergeable_state: dirty,冲突点在 src/launcher.ts 的 overlay 字符串——#3729 重写了该区域)。正在把分支 rebase 到 origin/master、按「两载体同步」纪律合并冲突、跑定向测试(issue3354/issue2605/issue4147),随后 push 并等 CI。完成后再发结构化八问结论。

… rows (#3962)

dsh.bundle.patch.yml gates four Web presets (preset-standard / preset-ptc /
preset-minimal / preset-cordis) on ids that exist only in the FACTORY roster.
A profile that replaces them with its own ids matches none of the four rows
and dsh logs `patch: entry <id> not found` at startup — buried in the loader
logger, surfaced nowhere else. From the outside the rows read as "working"
when they are silent no-ops.

State the roster-conditionality in the patch file itself (the shipped artifact
users inspect): the miss is NOT harmless — an ungated custom preset resolves
by import order and may win the race against the overlay middleware register,
leaving its compaction-basic AND command-compact rows armed (timing window;
worst case a dsh checkpoint outside bili destroys the compression substrate,
#3354/#1772/#1729). Mitigation: self-gate each custom preset entry with
inject:[biliBasicCompactionPolicy]. Self-check: grep the dsh loader log for
`patch: entry ... not found`. Do-not-delete note kept: factory-roster
profiles get a real ordering fence from these rows.

The launcher overlay carrier (writeDshAcpPatch) mirrors the same clause so the
two carriers stay in sync (file's own discipline + #3354 carrier-agreement
test). Comments/string-literal only — zero behavior change: no functional
patch row is added, removed, or reworded.

Rebased onto master after #3729 landed (gate moved to its own always-on
bili-compaction-gate entry; structural matching + coverage telemetry shipped
there). The four gate rows are unchanged on master, and structural matching
widens WHICH entries the transform reaches but not WHEN the middleware
registers relative to an ungated preset's resolution — the timing window this
note documents persists, so the text needs no rewording.

Targeted suites green locally: issue3354-dsh-compaction-disable (incl.
two-carriers-agree), issue2605-dsh-retry-patch, issue4147-dsh-overlay-structural
(16/16). Full typecheck/test on CI.

References #3962
@ranxianglei
ranxianglei force-pushed the 2026-10-21_dsh-bundle-patch-roster-docs branch from 66567b9 to 41c1e31 Compare October 23, 2026 05:47
@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

(ai: vllm-qwen/qwen3.8-27b)

结论先行

PR 方向正确、内容准确、零行为变更,可合(待 CI 全绿)。审核中发现 master 在 PR 切出后合入了 #3729(gate 入口重构),与 src/launcher.ts 同一区域冲突——已 rebase 到最新 master 并强推分支(三个 commit 的措辞演进折进单个最终态 commit 41c1e310f),PR body 已同步补 rebase 说明。冲突解决保留了双方意图:master 的新 bili-compaction-gate 入口结构 + 本 PR 的新注释条款。

结构化八问

  1. 是什么问题:dsh.bundle.patch.yml 的四条 Web preset gate 行(preset-standard/preset-ptc/preset-minimal/preset-cordis)钉死在 factory roster 专属 id 上;自定义 roster 的 profile 四条全部匹配落空,dsh 只在 loader 日志留一行 patch: entry <id> not found——外部看这四行像在工作,实际是静默 no-op(dsh.bundle.patch.yml gates four preset ids that may not exist — the miss is only visible in the loader log #3962 报的可观测性缺口)。本 PR 落的是本仓库内无需决策的部分:把 roster 条件性写进 patch 文件本身(用户实际检视的交付物)。
  2. 什么原因导致的:dsh patch 层按 id 匹配条目,自定义 roster profile 里没有这四个 factory id;loader 对 miss 只记日志、不进入任何 UI/诊断面。机制固有特性(id 匹配 + 日志位置),不是某版本引入的回归。
  3. 影响范围与严重程度:所有用自有 id 替换四个 factory preset 的 dsh profile(如桌面 profile 的十二个本地 preset)受影响;严重程度 = 可观测性缺口——gate 静默失效且用户无从确认。注意:dsh.bundle.patch.yml gates four preset ids that may not exist — the miss is only visible in the loader log #3962 讨论后定性已从「无害」修正为「正确性风险」——未自 gate 的自定义 preset 按 import order 解析,可能与 overlay middleware 注册抢跑,compaction-basic 与 command-compact 两行保持 armed(时序窗口,最坏情况 checkpoint 落在 bili 视野外、摧毁压缩基座,See how to integrate the plugin that automatically disables dsh compression. | 自动关闭 dsh 压缩的插件看如何集成 #3354/dsh.bundle.patch.yml 禁用自动压缩在 web profile 下静默失效 #1772/nudge 死锁无检测:同一 session 交替收到两种结构互斥的请求流(巨型单消息 ↔ 多轮)时不告警 #1729)。本 PR 注释块用的正是该最终定性(rebase 前三次措辞迭代即此收敛过程)。
  4. 怎么修复的:纯文档——dsh.bundle.patch.yml 四条 gate 行上方加 26 行注释块(指向 factory roster / 为何 miss 并非无害 / 缓解法:每个自定义 preset 条目自加 inject: [biliBasicCompactionPolicy] / 自查法:grep dsh loader 日志 / 为何不可删除:factory roster profile 靠它们拿真实顺序栅栏);writeDshAcpPatch 的 launcher overlay carrier 镜像同一条款(文件自身的两载体同步纪律 + See how to integrate the plugin that automatically disables dsh compression. | 自动关闭 dsh 压缩的插件看如何集成 #3354 carrier-agreement 测试)。无任何功能行增删改。
  5. 是否有回归问题:逐项清点 diff 触碰路径的既有行为——① 四条 gate 行 + compaction-basic auto:false 行 + 两条 retry 行:与 master 逐字节一致(diff 验证,仅插入注释);② launcher overlay carrier:仅生成物 .bili-acp.patch.yml 内注释文本变化,功能行不变;③ yaml 注释插入不破坏解析(issue4147 结构化套件通过);④ 无语义漂移/阈值漂移/输出格式变化——零行为变更,无「修 A 坏 B」面。高危模式逐项过:错误处理、默认值、时序、缓存策略均未触碰。
  6. 是否破坏缓存:不涉及(未触碰任何运行时路径)。
  7. 是否改了设计方向:没有。reporter 真正想要的运行时信号(per-bundle apply 聚合计数 / optional: marker)属 DSH loader + UI 跨仓库,仍在 dsh.bundle.patch.yml gates four preset ids that may not exist — the miss is only visible in the loader log #3962 跟踪等 owner 定方向,不在本 PR 内。
  8. 是否引入了新的配置:没有。

验证

判定:可合——CI 转绿后请人工合并。

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

(ai: vllm-qwen/qwen3.8-27b)

CI 状态补充:新 head 41c1e310f 的全部 check 已入队,但仓库 runner 池当前整体饱和——最近约半小时内的 100 个 workflow run 里 54 个 queued、4 个 pending、0 个 in_progress,不止本分支如此(其他分支的 run 同样排队)。这是舰队级 CI 拥堵,不是本 PR 的问题,无法通过重跑加速。

对本 PR 的判定不受影响:改动为注释/字符串字面量级(零行为变更、零类型影响),本地定向套件 16/16 绿(含 two-carriers-agree 与 #4147 结构化解析验证)。若 owner 愿意在 CI 转绿前先行合并,风险面仅在于 CI 尚未背书;runner 空出来后队列会自动消化,届时结果会留在 PR 上可查。

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

(ai: vllm-qwen/qwen3.8-27b)

收尾汇总(本线程已有两条实质回复,此为最终状态确认):

做了什么

  1. 独立审核 PR 内容:四条 gate 行的 roster 条件性注释在 [PR] fix: keep dsh presets bootable when bili-native is disabled (#3662) #3729 合入 master 之后依然准确([PR] fix: keep dsh presets bootable when bili-native is disabled (#3662) #3729 的结构化匹配扩大的是 transform 能触达的条目范围,不改变 middleware 注册与未 gate preset 解析之间的时序关系);diff 逐字节核对为零行为变更(仅 YAML 注释 + launcher overlay 字符串内注释文本,+26/-1)。
  2. 解决合并冲突:[PR] fix: keep dsh presets bootable when bili-native is disabled (#3662) #3729 重构了 src/launcher.ts 同一区域导致 PR 分支 dirty——已 rebase 到最新 master(07888d748),三个 commit 的措辞演进折成单个最终态 commit 41c1e310f,强推 PR 分支;PR body 已补 rebase 说明。PR 现状态:mergeable: true(conflict 已消除)。
  3. 本地定向验证 16/16 通过:issue3354-dsh-compaction-disable(含 two-carriers-agree)+ issue2605-dsh-retry-patch + issue4147-dsh-overlay-structural。

结果

  • 代码层面:可合,无回归面(零行为变更、零类型影响)。
  • CI:新 head 的全部 check 已入队,但仓库 runner 池整体拥堵(近半小时 100 个 run 中 0 个 in_progress,全仓库范围),队列空出后会自动消化,结果留在 PR 上可查。若希望不等 CI 先行合并:风险仅为「CI 尚未背书」,改动本身无任何运行时路径触碰。

等待人工合并。

@ranxianglei

Copy link
Copy Markdown
Owner Author

(ai: zhipuai-lb/glm-5.3)

孤儿票清理:标题指向的 issue 已关闭,修复已由其他路径落地。关单;误判请 reopen。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant