Skip to content

[PR] test(#1839): pin the un-rescuable numberless overflow pass-through (G3b) - #4001

Closed
Zhishulo wants to merge 1 commit into
ranxianglei:masterfrom
Zhishulo:2026-10-20_g3-numberless-overflow-rescue
Closed

Zhishulo wants to merge 1 commit into
ranxianglei:masterfrom
Zhishulo:2026-10-20_g3-numberless-overflow-rescue

Conversation

@Zhishulo

@Zhishulo Zhishulo commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

What changed

While #1839 G3 was red on master, this PR started as a rewrite of G3 for the #3787 in-request rescue. Master then fixed G3 itself (901c62e5, merged in #3986), so the earlier revision is superseded and this branch is reduced to the one piece master does not pin:

G3b — the rescue-exhaustion path. With nothing foldable in the payload, the #3787 rescue cannot make progress and the numberless overflow must still pass through as a 400 with overflow-arm provenance — never billing-grade usage — and the next turn's nudge must keep using the armed value.

#1839 G3b: an un-rescuable numberless overflow passes through and keeps 'overflow-arm' provenance
  • Single-message fixture, no header, no window number in the 400 body.
  • Asserts 400 pass-through, lastInputTokensSource === 'overflow-arm', the arm is bounded by the declared window, armed emergency shrink at ~ is logged, the next turn's nudge is sized from that same armed value, and no preflight summary calls are spent on an unfixable turn.
  • No src/ change, no fixture subject change: the existing G1/G2/G3 fixtures are untouched.

This is the negative case requested in #3998's review checklist for sub-defect A ("rescue exhausted → 400 pass-through and the arm keeps its own provenance").

Verification

Base master @ e98ccda9; head a42746db (one commit, one test file, +34).

  • npx tsc --noEmit -p tsconfig.json: 0 errors (kernel built first).
  • node --test --experimental-test-isolation=none tmp/build3/tests/issue1839-ghost-denominator.test.js: 4 / 4 pass (G1, G2, G3 as updated by 901c62e5, and the new G3b).

Part of #3998 (ework #3997, sub-defect A). The G3 half of A is already fixed on master; this PR only adds the exhaustion coverage on top.

@ranxianglei ranxianglei changed the title test: #1839 G3 pins the #3787 numberless-overflow rescue; provenance stays on the un-rescuable case (#3998) [PR] test: #1839 G3 pins the #3787 numberless-overflow rescue; provenance stays on the un-rescuable case (#3998) Oct 20, 2026
@Zhishulo
Zhishulo force-pushed the 2026-10-20_g3-numberless-overflow-rescue branch from c686403 to bff671b Compare October 20, 2026 15:11
@Zhishulo
Zhishulo force-pushed the 2026-10-20_g3-numberless-overflow-rescue branch from bff671b to a42746d Compare October 20, 2026 15:17
@Zhishulo Zhishulo changed the title [PR] test: #1839 G3 pins the #3787 numberless-overflow rescue; provenance stays on the un-rescuable case (#3998) test(#1839): pin the un-rescuable numberless overflow pass-through (G3b) Oct 20, 2026
@ranxianglei ranxianglei changed the title test(#1839): pin the un-rescuable numberless overflow pass-through (G3b) [PR] test(#1839): pin the un-rescuable numberless overflow pass-through (G3b) Oct 20, 2026
@Zhishulo

Copy link
Copy Markdown
Contributor Author

(ai: deepseek/deepseek-v4.1-flash-1017)

CI on head a42746db: 25 green, 11 skipped, one failing shard - test (windows-latest, 22, 2) - and its only real failure is again

not ok 1846 - upgraded pre-fold-gate state keeps rotation-hidden orphans hidden end-to-end (#3769)
  expected: true
  actual: ~

(job 118716180712). That is sub-defect B from #3998, unrelated to the G3b case this PR adds: tests/issue1839-ghost-denominator.test.ts passes in every shard (G1/G2/G3/G3b locally 4/4). The same flake hit #3973 on a different shard.

This PR is test-only and already rebased on e98ccda9, so it is ready once master's #3769 flake is addressed.

@ranxianglei

Copy link
Copy Markdown
Owner

关闭:superseded by #3986。G3 修复本体已由 901c62e(#3986)落地于 master;本 PR diff 对 master 存在性 0.84,残留仅 4 行测试差异(修复已落地后的形态微调),不再单独追踪。长期跟踪单 #1839 已关闭。(孤儿 PR 扫描)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants