Repository navigation
[PR] fix: preserve Codex model capabilities through catalog outages - #3996
zhou1736948757-cpu wants to merge 2 commits into
Conversation
|
Initial CI triage: |
(ai: vllm-qwen/qwen3.8-27b) 查重:不重复——open+closed issue/PR 检索「Codex catalog 瞬断 → fallback 元数据降级」主题无匹配;#3994/#3995 是 lifecycle-ledger 修复,机制不同(CI 注册台账),仅作基线红背景相关。 独立审核完成,以下全部在 PR head 独立验证证据
结构化八问
发现(均不阻塞,按规则列出;本线程是 [PR] 自动镜像,按 loop guard 写评论等 owner 定夺,不单开 issue)
CI 状态:PR head 有 4 个 test shard 红;master head(56a0f5a46)同样有 5 个 test shard 红——test 车道基线红风暴早于本 PR(另有 PR 在修 CI),两头红的分布一致指向存量红而非本 PR 引入;本审核环境取不到 CI 日志,无法点名具体测试,但 guard/static/hermetic e2e 各车道在 PR head 均绿。 判定:代码质量高(diff 干净、双向测试、en/zh 文档同步,无需对齐重构);方向正确(疏不堵,修在坏状态生产者);未发现阻塞缺陷。按 §7.4,本 PR 触碰 wire 形状(新响应头、304→200 转换)+ fallback 行为(stale capability 最长 6h)+ 安全相关(凭据指纹磁盘持久化、circuit 快速失败旁路)→ 需人工 review。建议 rebase 最新 master、等 test 车道转绿后合并。 |
|
(ai: zhipuai-lb/glm-5.3) 已并入合并列车 #4525(master 6d7c587,合并方式 merge commit,提交保留原作者署名)。本 PR 关单收尾;若列车中对应提交出问题,回滚点为 #4525 单提交 revert。 感谢 @zhou1736948757-cpu 的贡献——你的提交以原作者署名随列车进入 master(合并方式为 merge commit),仓库贡献者列表可见。 |
Summary
Fixes #3993.
Preserve the last valid complete ChatGPT model catalog through temporary discovery outages, so Codex does not silently lose known context/tool capabilities and expose a very large eager tool catalog. Ported to native TypeScript on master 860e617 (package 0.1.202); the reporter's installed 0.1.147 local hook has already been verified separately.
This is a separate incident from the deferred-tool accounting fix in #2398 (already merged). Here the failed request had no deferred catalog to discount: catalog=visible ~249491, loaded=0. The supported boundary is model discovery, not subtracting eager tool definitions or increasing the context window.
Incident and upstream-client boundary
Unknown model gpt-6.1-sol is used. This will use fallback model metadata.after nearby catalog reset/cancellation.898 / loaded22742; upstream actual input was 62552, then 57120. These are different requests; the failed request's actual usage was never measured and its original body was not captured.Implementation
/backend-api/codex/models; inference POSTs and other providers remain on the existing transport path. This metadata side request is independent of plugin/proxy compression mode.Validation
npx tsc --noEmit --project tsconfig.json: passed.npm run build: passed, including dist import annotations and external-zod gates.node scripts/check-unused-exports.mjs: clean (five existing waivers).ACP_TEST_E2E_CODEX_CATALOG=1 E2E_CODEX_BIN=/path/to/codex node --import tsx --test tests/e2e/e2e-codex-catalog.test.ts.Config surface and review
No new config keys, CLI flags, production environment variables, model-window changes, version bumps or kernel/pi-subagents edits. Internal policy limits are explicit above. The six-hour bounded stale-capability tradeoff and credential-scoped persistence require human review; do not auto-merge. An account/credential rotation intentionally produces a cold miss. The protection needs a prior successful catalog fetch and cannot make inference work while the upstream network is down.
Initial CI status
The initial
lifecycle-ledger-guardfailure is reproduced on unchanged base 860e617: 148 readers / 128 active ledger entries / 16 identifiers exempt, with the same 22 missing registrations. This PR introduces no BILI_* production environment reads. The existing upstream issue #3994 and PR #3995 already track the baseline repair; their policy registrations are intentionally not duplicated in this fix. Other checks remain in progress/queued at submission.