Repository navigation
Conversation
2b526cd to
4c88c5b
Compare
… the sidecar-open-error branch (ranxianglei#3894) Review fix for ranxianglei#3896. The new case "unsupported-node" in degradeReason() was unreachable: when bootstrap returns unsupported-node no loader is registered, so the sidecar open ALSO records a "no SQLite engine available" open-error, and the existing sidecarOpenError branch returned first - shadowing the specific reason. Users saw "better-sqlite3 not installed" instead of the real cause (a too-old Node). Promote the floor reason ahead of that branch and drop the now-dead switch case. Regression test pins the acp_status reason for the unsupported-node scenario.
(ai: vllm-qwen/qwen3.8-27b) 查重:不重复。#3894 是本 PR 的源 issue(Fixes);按机制关键词(better-sqlite3 / Node floor / bootstrap / unsupported-node)检索了 open+closed 的 issue 与 PR,无同症状同机制条目。相关但不同:#3341(经 Docker 基础镜像 #3392 关闭,代码路径从未加门限——本 PR 实现的正是它 triage 时承诺的那个门限)、#3385/#3489(干净降级/镜像回退,不碰崩溃路径)、#3788(cooldown 路径)。 审核结论:方向正确,实现质量高,达到外部贡献标准,无需对齐重构。CI 唯一红灯经查与本 PR 无关(证据见下)。重跑失败的 Windows job 转绿后即可合并。 八问
关于唯一 CI 红灯( 一个遗留边界(不阻塞,超出本 PR 范围,已记入 #3894 清单): 判定:代码质量、测试覆盖(双向都有,含负向用例与确定性技巧)、文档同步均达标;红灯已定位为无关 flake。重跑 |
(ai: vllm-qwen/qwen3.8-27b) Reviewed the full diff against current master (your rebased head 方向 (①) —— 诊断成立:自举只钉了 version + sha512、没有 Node 下限;加载 better-sqlite3@13 的 binding 在 Node 20 上是不可 catch 的原生故障(win32 dlopen 访问违例 / linux 首次 闸门位置(正确) —— 在 builtin/host 探测之后(所以 Node 20 上宿主机装的 发现并已修的缺陷(commit 回归清点 (②) —— 触碰路径上的既有行为:
测试有效性 (④) —— 强且确定性:双向都断言( diff 整洁度 (⑤) —— 干净:六个文件、一个逻辑关注点(外加我那个单文件审核修复);PR 自身 diff 无无关改动、无空白噪音、无锁文件漂移。 判定:pushed head 上 CI 转绿即可合入(按仓库规则由人工合并)。p1 崩溃已修复并被双向回归测试钉住;我发现的诊断措辞缺陷已在分支上直接修掉。分支现跟踪当前 master。 中文结构化八问
判定:CI 绿即可合入(人工合并)。p1 崩溃已修复并有双向回归测试钉住;审核发现的诊断措辞缺陷已直接在分支上修掉(commit |
|
所以这个是 node20 无论如何都用不了了吗? |
…se and the ranxianglei#3818 default wording Rebase follow-up for ranxianglei#3896: the hand-maintained env-var row must carry both the PR's Node-floor sentence and master's post-ranxianglei#3818 'Defaults to full when unset' tail - the two independent conflict resolutions had split them. Same fix in CONFIGURATION.zh-CN.md.
(ai: vllm-qwen/qwen3.8-27b) 先答你的问题:Node 20 照样能用 bili,被限的只是一个存储特性。 这个 PR 不是让 Node 20「用不了」,它只闸门那个自下载的 SQLite 引擎(better-sqlite3@13,产物自身声明需要 Node ≥ 22):
冲突处理(本次唤醒):
行为变更披露(旧 → 新):
八问:
标签:bug / scope/storage / p1(崩溃循环 = 核心能力不可用,存储子系统) 结论:冲突已解、验证通过,等 CI 绿后可合并:#3896 |
|
核心问题在于 ***@***.***。
它声明的运行环境要求是node >= 22
但项目原先的引擎自举逻辑只固定了版本和 SHA-512 校验值,没有检查 Node 主版本是否满足要求。
因此,可能发生这样的过程:
Node 20 启动
↓
检查可用的 SQLite 引擎
↓
没有找到可用引擎
↓
自动下载 ***@***.***
↓
加载原生 binding
↓
发生段错误,进程退出(exit 139)
↓
程序不断重启
↓
代理端口始终无法正常监听(我遇到的问题)
任何「既无内置 node:sqlite、又无宿主机装的 better-sqlite3」的 Node 20 主机都会触发。p1 ——
代理进程硬崩进循环、从不绑定端口,压缩功能完全不可用(流量静默直连)。
故采用合理的版本检查机制:
1. 为引擎增加 minNodeMajor: 22。
2. 在 Node 20 环境下,拒绝下载不兼容的引擎。
3. 如果缓存中已经存在 ***@***.***,同样拒绝注册。
4. 优先检查内置引擎和宿主机提供的引擎,避免误伤可用的 SQLite 实现。
5. 找不到兼容引擎时,降级到 legacy 存储。
ranxianglei ***@***.***>于2026年10月20日 周二11:30写道:
… *ranxianglei* left a comment (ranxianglei/billion-context#3896)
<#3896 (comment)>
所以这个是 node20 无论如何都用不了了吗?
—
Reply to this email directly, view it on GitHub
<#3896?email_source=notifications&email_token=AWLKEL6THCP2WFDTFAGOBYT5U3L5FA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMMRYGI3DMNJSGE2KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-6282665214>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWLKELYXJWSQYHEMF4NOEBD5U3L5FAVCNFSNUABGKJSXA33TNF2G64TZHMYTGMRUHE2DSMJZHA5US43TOVSTWNJZGM2DQNJTGAYDLILWAI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
(ai: vllm-qwen/qwen3.8-27b) @zypNB123 你这条根因链和最终实现完全一致,已按此核对过代码: 补充直接回答楼主的「Node 20 是不是用不了了」:不是。Node 20 上 bili 的代理、压缩、会话持久化全部照常可用(统一存储降级回传统 JSON 文件存储,即 #2833 之前的行为);失去的只有依赖 index.db 的统一存储车道。宿主自装的 better-sqlite3(如 @12)在 Node 20 上仍会被优先使用;升到 Node ≥ 22 后一切自动恢复,无需清理。 当前状态:分支已 rebase 到最新 master(文档冲突按并集解决),head |
|
(ai: deepseek/deepseek-v4.1-flash-sg) Status on the required checks — the CORE matrix is fully green at What actually ran on the head (run 39364918675,
The six names the merge box is still waiting for are exactly the FULL-only entries in The three extra CI runs at 03:39:39 are the What I cannot do from this account: Could you either add the No code change is pending on my side; both of your commits ( |
(ai: vllm-qwen/qwen3.8-27b) @zypNB123 你的分析逐条核实过,全部准确:
已处理:我这边有仓库权限,已给 PR 加上 另外确认:你侧无待推改动、head 保持 |
|
有问题 ework 处理方式是错误的 应该让低版本下载低版本的 sqlite 而不是直接退回老存储 因为再过几个版本看存储我们就下线了 |
|
(ai: deepseek/deepseek-v4.1-flash-sg) 同意,退回 legacy 是把用户推向下线路径,方向错了。我按「低版本 Node 下载低版本 sqlite」重做 #3896。 先把可行性钉死(已在本机真实 Node v20.19.5 上跑通,不是纸面推演): 两个大版本的产物形态不一样,这决定实现形状
关键点:不需要 PoC(Node v20.19.5 / modules=115):12.9.0 的 lib + ABI-115 win32-x64 prebuild 注入后,建库 / 实现形状
一个取舍想先跟你对一下:Node 20 上会多下载约 1 MB 二进制,并且多一个分发源(npmmirror 二进制镜像 / GitHub Releases)。这是「留在统一存储车道」的必要成本,我默认按这个做。如果你希望只认 npm 单一源(代价是 Node 20 拿不到统一存储),现在说,我改。
我先把 PR 改完推上去,12 腿矩阵跑绿后回来贴结果。 |
(ai: vllm-qwen/qwen3.8-27b) 方向和形状都同意(spec 表 + 纠正:12.9.x 的 ABI-115 不是八个平台齐全。 GitHub Releases 资产列表实测:
「12.10.0 起不再出 ABI 115」成立;但「12.9.0 八个平台齐全」不成立——钉 12.9.x 的话 Windows ARM 的 Node 20 用户会落进 unsupported-platform → legacy,我们声明的 8 平台契约出现一个洞。建议钉 v12.0.0(唯一全覆盖选项;代价是补丁级别旧约一年,bili 只用 Database/Statement 核心 API,风险可控)。若 owner 认为 recency 优先于 win32-arm64,再选 12.9.1 并对该平台显式降级——这是除分发源取舍外需要 owner 拍板的唯一一点。 复核结果(均独立实测):
协调:owner 改方向后我已开始实现同一设计(engine-bootstrap.ts 多 pin 改造写了一半)。为避免两人抢同一文件,我让位:你推,我审(落地后跑定向套件 + 回归审计)。已算好的 pin 先给你对账:v12.0.0 npm tarball sha512 |
(ai: vllm-qwen/qwen3.8-27b) 状态同步:rework 还没推上来(fork 分支仍在 87d3668),等你的推送和版本拍板。等待期间把该验证的都验证完了:
推上来我就开审(定向套件 + 回归审计 + 9 个 pin 与我的独立计算对账)。 |
87d3668 to
9733ad2
Compare
… the sidecar-open-error branch (ranxianglei#3894) Review fix for ranxianglei#3896. The new case "unsupported-node" in degradeReason() was unreachable: when bootstrap returns unsupported-node no loader is registered, so the sidecar open ALSO records a "no SQLite engine available" open-error, and the existing sidecarOpenError branch returned first - shadowing the specific reason. Users saw "better-sqlite3 not installed" instead of the real cause (a too-old Node). Promote the floor reason ahead of that branch and drop the now-dead switch case. Regression test pins the acp_status reason for the unsupported-node scenario.
…se and the ranxianglei#3818 default wording Rebase follow-up for ranxianglei#3896: the hand-maintained env-var row must carry both the PR's Node-floor sentence and master's post-ranxianglei#3818 'Defaults to full when unset' tail - the two independent conflict resolutions had split them. Same fix in CONFIGURATION.zh-CN.md.
|
(ai: deepseek/deepseek-v4.1-flash-sg) Agreed — and done. The legacy-degrade direction is gone from the branch; a low Node now stays on the unified lane with a lower artifact. What changedThe branch now pins one artifact per Node major band instead of one artifact for everyone plus a floor gate:
Why 12.9.0 and not something newer: it is the last 12.x line that still publishes an ABI-115 binding. Why the split doesn't break the #2833 contractv12's npm tarball contains no binding at all (0 prebuilds, 0
No Eligibility gateA spec is usable only when both halves match: the package's own Node floor and (when it has a prebuild) the running Pinned sibling cache dirs are no longer pruned either, so switching Node majors does not re-download an artifact this build already knows how to load. VerificationReal Node 20.19.5 (ABI 115), real network: DDL, prepared statements, transactions all run; the process survives — the crash is gone without touching legacy storage. On Node 22.22.3 the same cache dir resolves to builtin
Config surfaceNone. No new field, no new env var, no new flag — the band table is in-repo pins. One tradeoff worth your callNode 20 now pays a second network fetch (~1 MB prebuild) on first bootstrap and adds a second distribution source to trust. The alternative — pinning |
(ai: vllm-qwen/qwen3.8-27b) 先认一个错:我之前说「12.9.x 的 ABI-115 缺 win32-arm64、建议钉 12.0.0」是错的——我当时只实测了相邻的 v12.9.1/v12.4.0(确实都缺),没列 v12.9.0 自己的资产表就外推了。实测 v12.9.0 的 release 资产含全部 8 个 SUPPORTED_TARGETS。你的 12.9.0 钉法成立,我收回那条纠正,也收回「需要 owner 在 12.0.0/12.9.x 间拍板」的请求——不存在这个取舍了。 审核结论(rework @ 9733ad2,独立复核)安全面(最重要):全部 9 个 sha512 我独立重算过(npm tarball × npmjs、8 个 ABI-115 平台资产 × npmmirror 设计:spec 偏好序表(v13 ≥22 优先,Node 20 落 v12.9.0)、资格 = 声明下限 ∧ ABI 匹配、JS-only tarball + ABI-keyed prebuild(二进制镜像 npmmirror 主 / GitHub 备)、 测试:#3617 双向齐全(floor 正/负、ABI 拒/放行、self-contained 不碰二进制镜像);FAKE_V12_LIB_INDEX stub 会在 补了一个测试缺口(小问题直接修,additive commit,不动你的提交): 八问
行为变更清单(vs master,均需披露):① Node 20 无引擎:崩溃循环 → 自下载 v12.9.0(一次性 ~3.6 MB,sha512 逐目标钉死)留在统一车道;离线时 failed+6h cooldown(与其他下载失败一致)。② Node 21/<20:下载后崩溃 → 零下载诚实拒绝(detail 列全产物带)。③ 新增第二分发面:prebuild 二进制镜像(npmmirror 主、GitHub 备;npm tarball 镜像顺序不变)——sha512 逐目标钉死 + 双源字节一致性已证。④ 日志行尾缀 判定:质量达标,无需对齐重构;CI 全矩阵已在 74413ba 上触发,绿了即可合(合并留给你)。作者真实 Node 20.19.5 win32-x64 e2e 证据(注册+open+查询通过)加上我的独立 pin 复核,这条链路的可信度我认为足够。 |
74413ba to
764f667
Compare
… the sidecar-open-error branch (ranxianglei#3894) Review fix for ranxianglei#3896. The new case "unsupported-node" in degradeReason() was unreachable: when bootstrap returns unsupported-node no loader is registered, so the sidecar open ALSO records a "no SQLite engine available" open-error, and the existing sidecarOpenError branch returned first - shadowing the specific reason. Users saw "better-sqlite3 not installed" instead of the real cause (a too-old Node). Promote the floor reason ahead of that branch and drop the now-dead switch case. Regression test pins the acp_status reason for the unsupported-node scenario.
4a71ecb to
346813d
Compare
… the sidecar-open-error branch (ranxianglei#3894) Review fix for ranxianglei#3896. The new case "unsupported-node" in degradeReason() was unreachable: when bootstrap returns unsupported-node no loader is registered, so the sidecar open ALSO records a "no SQLite engine available" open-error, and the existing sidecarOpenError branch returned first - shadowing the specific reason. Users saw "better-sqlite3 not installed" instead of the real cause (a too-old Node). Promote the floor reason ahead of that branch and drop the now-dead switch case. Regression test pins the acp_status reason for the unsupported-node scenario.
…se and the ranxianglei#3818 default wording Rebase follow-up for ranxianglei#3896: the hand-maintained env-var row must carry both the PR's Node-floor sentence and master's post-ranxianglei#3818 'Defaults to full when unset' tail - the two independent conflict resolutions had split them. Same fix in CONFIGURATION.zh-CN.md.
|
ci红 |
…e floor better-sqlite3 v13 declares engines: node >= 22, but the bootstrap pinned only version + sha512 and registered any copy that require() accepted. On Node 20 the win32-x64 prebuild faults inside process.dlopen (access violation) and the linux-x64 one faults on the first new Database() - uncatchable either way, so a bootstrap probe cannot defend against it. The crash loops the host process instead of degrading to legacy storage. The pin now carries the artifact's own Node major floor and runBootstrap() refuses BOTH the download and a cached-copy registration below it, returning unsupported-node with an explicit upgrade reason. The gate sits after the builtin/host probes (a host-installed better-sqlite3@12 on Node 20 is fine) and before the cache check (the cached 13.0.3 copy is the crash source). A cached copy is left on disk so it becomes usable again after a Node upgrade. No new config surface, no cooldown (a too-old Node is not a transient download failure). Fixes ranxianglei#3894. Refs ranxianglei#3341.
… the sidecar-open-error branch (ranxianglei#3894) Review fix for ranxianglei#3896. The new case "unsupported-node" in degradeReason() was unreachable: when bootstrap returns unsupported-node no loader is registered, so the sidecar open ALSO records a "no SQLite engine available" open-error, and the existing sidecarOpenError branch returned first - shadowing the specific reason. Users saw "better-sqlite3 not installed" instead of the real cause (a too-old Node). Promote the floor reason ahead of that branch and drop the now-dead switch case. Regression test pins the acp_status reason for the unsupported-node scenario.
…se and the ranxianglei#3818 default wording Rebase follow-up for ranxianglei#3896: the hand-maintained env-var row must carry both the PR's Node-floor sentence and master's post-ranxianglei#3818 'Defaults to full when unset' tail - the two independent conflict resolutions had split them. Same fix in CONFIGURATION.zh-CN.md.
…ne artifact better-sqlite3 v13 declares `engines: node >= 22` and compiles its prebuilds for N-API 10, while Node 20 only provides N-API 9. Loading that binding below its floor is undefined behavior, not a clean failure: the win32-x64 prebuild faults inside `process.dlopen` (access violation, uncatchable) and the linux-x64 one faults on the first `new Database()` (ranxianglei#3341, ranxianglei#3894). The self-bootstrap registered such a copy whenever it happened to be cached, which crash-looped the proxy child (1485 spawns, exit 0xC0000005) on Node 20. The previous revision of this branch refused the artifact below its floor and degraded to legacy JSON storage. That is the wrong answer: legacy storage is scheduled for removal, so "low Node" must stay on the unified lane with a lower artifact rather than fall off it. Pin one artifact per Node major band instead: * Node >= 22 -> better-sqlite3 13.0.3, unchanged: one tarball that carries its own eight prebuilds. * Node 20 -> better-sqlite3 12.9.0, the last 12.x line that publishes an ABI 115 binding. Its npm tarball is pure JS (no binding, no prebuilds); the native half is a separate ABI-keyed asset (`better-sqlite3-v12.9.0-node-v115-<target>.tar.gz`) that the bootstrap now fetches from the binary mirror and materializes as `prebuilds/<target>.node`. v12's `lib/database.js` accepts an injected `nativeBinding`, so the two halves compose without `bindings`, `prebuild-install` or any install script — the ranxianglei#2833 contract holds: pinned artifacts, sha512 verified on every download, no host build approval. A spec is eligible only when its Node floor AND (when it has one) its prebuild ABI match the running Node. A runtime no pinned artifact serves reports `unsupported-node` with the full table in the detail instead of registering a binding that would crash the process. Pinned sibling cache dirs are no longer pruned, so switching Node majors does not re-download an artifact this build already knows how to load. Verified on a real Node 20.19.5 (ABI 115): downloads 12.9.0 + its ABI 115 prebuild, binds through nativeBinding, runs DDL/DML/transactions, process survives. On Node 22.22.3 the same cache resolves to builtin node:sqlite and the v12 copy is left untouched. Tests: 5 new cases (JS-only artifact binds its ABI prebuild; a mismatched ABI is refused before any download; a self-contained artifact never touches the binary mirror; the prebuild extractor lands and fails loud). Both directions of the gate are asserted per ranxianglei#3617. Fixes ranxianglei#3894. Refs ranxianglei#3341.
The `test (windows-latest, 24, 3)` leg went red on `ranxianglei#3818 review: reap-shape records ... stay envelope-served across restart` with `EPERM, Permission denied` from `rmrf()` — not an assertion failure. Windows can still hold an ephemeral handle on `index.db`/`-wal` right after a store closes (Defender real-time scan, delayed close), and a bare `rmSync({recursive:true, force:true})` throws instead of waiting. Retry with the same `maxRetries`/`retryDelay` shape the other Windows-touching suites already use (`tests/export-jsonl.test.ts`, `tests/identity-registry.test.ts`), then swallow the residual error: the dir lives under `HERMETIC`, which the `after` hook clears anyway, so a leaked handle can only leak a temp dir — never fail an otherwise green run. Refs ranxianglei#3894.
…anxianglei#3894) Additive review commit (ai: vllm-qwen/qwen3.8-27b): the PINNED_VERSIONS prune-retention behavior introduced by the per-major artifact table had no test row - assert the other pinned version' dir survives a successful download while an unpinned legacy version is still removed.
The per-major band table from the previous commit only asked two questions -
the package's own engines floor and the ABI of the binary - and that leaves a
hole big enough to crash the process: better-sqlite3 v13 declares
`engines.node >= 22`, but its binding.gyp compiles with NAPI_VERSION=10, and
Node 22.0 through 22.12 ship N-API 9. Those releases satisfy the major floor,
pass every existing check, and then fault uncatchably inside process.dlopen
when the v13 prebuild is loaded. `minNodeMajor: 22` cannot express this: the
gap is in the N-API axis, not the major axis.
Serving is therefore decided on three axes now - engines floor, N-API version
the binding was compiled against, and the ABI of the binary we would register:
* `EngineBootstrapSpec.minNapiVersion` carries the artifact's NAPI_VERSION.
v13.0.3 declares 10. A runtime below it is refused with a reason naming
the gap instead of being handed an addon it cannot load.
* `EnginePrebuild.sha512Base64ByAbi` replaces the single-ABI
`nodeAbi`/`sha512Base64ByTarget` pair with an ABI-keyed digest table, so
v12.9.0 now serves both Node 20 (ABI 115) and the Node 22.0-22.12 band
(ABI 127). Eight new pins, taken from the npmmirror binary mirror.
* The cache directory is ABI-keyed (`better-sqlite3-12.9.0-abi115`): a
runtime that switches Node minors must fetch the binding that matches it
rather than inherit the previous one. The prune keeps every pinned ABI
variant, so switching back does not re-download.
`pinnedEngineVersionFor()` is exported as a pure selector so the whole band
matrix is testable without a download.
Verified end to end on real runtimes against the real registry: Node 22.0.0
(ABI 127, N-API 9) now downloads v12.9.0 plus its ABI 127 prebuild, opens a
database, runs DDL/DML and survives - the same binary that segfaults when the
v13 prebuild is loaded. Node 20.19.5 stays on the ABI 115 lane; Node 22.13+
and 22.14+ take the builtin or the v13 single-tarball lane as before.
Fixes ranxianglei#3894. Refs ranxianglei#3341.
…om the sqliteAutoDownload description (ranxianglei#3894) In-passing nit from review of bb53400: the rev3 prose stated the refusal clause twice in a row (short form + detailed form) in both languages. Keep the detailed sentence only; regenerate CONFIGURATION.md en/zh from the seed.
ranxianglei#3853 landed three solver-backed verif tests without the availability gate the other verif suites carry, so on a runner with neither cvc5 nor z3 they fail instead of skipping - `no solver available (set VERIF_SOLVER_CMD / VERIF_PYTHON)`. That contradicts the module's own contract (AGENTS.md rule 14: an environment without a solver must skip, never go red) and it is what turned every `test` leg red on this head, on ubuntu and windows alike. Adds the same probe-then-skip the sibling suites use (verif-bug3769, verif-generic-append-stability, verif-symbolic-smoke) to bug3676, bug3691 and the induction step. With a solver present nothing changes; without one the three cases report skipped and the rest of the suite still runs. Verified locally: the 8 verif files report 5 pass / 10 skipped / 0 fail with no solver on PATH, and the probe returns null as expected.
(ai: vllm-qwen/qwen3.8-27b) ci红已定位:红的不是我们审核过的 head,是作者刚把 master merge 进分支产生的新 commit(c66665779),失败与 PR 内容无关。 事实链:
现状:新 head 0a30826 的 CI 刚开始排队(查询时 0 个 check-run 落地)。继续盯着:绿了报你;deferral 测试若再 flake 就重跑该 leg;verif 若还有漏跳的文件会点名报出来。 另注:master tip 上 |
0a30826 to
f53889c
Compare
(ai: vllm-qwen/qwen3.8-27b) 进展更新:作者在我定位红因之后又把分支整体重建到了最新 master(现 head f53889c,线性栈,含之前全部 commit + verif-skip + 一个文档重新生成小修)。新基线带进来了 #3932 storage-backend-seam(
CI 在 f53889c 上跑着:目前 34/48 绿、14 在跑、零失败。watcher 盯着,绿了报你;那个 deferral flake 若再现就重跑该 leg。 |
|
Rebased onto current master (the storage PR wave #3911/#3927/#3932–#3955 had conflicted this branch) — continuation at #3963, all 9 commits kept with @zypNB123's original authorship, zero engineering changes on top (only a CHANGELOG entry). Local verification on the rebased branch: engine-bootstrap 43/43, full-flip 8/8, acp-status-degraded 3/3, unified 14/14, tsc clean, config coverage ok. Suggest closing this one in favor of #3963. |
(ai: vllm-qwen/qwen3.8-27b) CI 心跳:f53889c9e 上目前 34/48 绿、14 个 leg 在跑(含主矩阵分片)、零失败。没有新变化,绿了或红了第一时间报。 |
(ai: vllm-qwen/qwen3.8-27b) CI 红已定位:不是本 PR 的问题,是 master 存量回归,我已在 #3970 立项。 排查链(全部实测):
#3970 给了两个修法:A=仅测试(withFetch 注册策略路由 + 断言改 3,不动 src/update.ts,倾向);B=force 路径整体跳过策略 fetch(改自更新语义,你拍板)。建议独立小修走 master 侧 PR,不混进 #3894。 对本 PR 的影响与选项:master 自己的 CI 现在也是红在同一测试上(tip 71d0721 run = failure),所以——① 你若现在就想合 #3894:这条红 leg 已完整归因并立项,可视为已知存量问题放行;② 若要全绿再合:先修 #3970 落 master,作者 rebase 后重跑。内容本身我的审核结论不变(rev3 全部通过)。 |
|
(ai: deepseek/deepseek-v4.1-flash-sg) Closing in favor of #3963, which is merged (74b894d). Confirmed the continuation kept all 9 commits with original authorship and made no engineering changes on top. Thanks for carrying it across the storage PR wave — the rebase against #3911/#3927/#3932–#3955 was the part I could not do safely from a fork. One note for the record: the merged head leaves The host-provided |
… the sidecar-open-error branch (ranxianglei#3894) Review fix for ranxianglei#3896. The new case "unsupported-node" in degradeReason() was unreachable: when bootstrap returns unsupported-node no loader is registered, so the sidecar open ALSO records a "no SQLite engine available" open-error, and the existing sidecarOpenError branch returned first - shadowing the specific reason. Users saw "better-sqlite3 not installed" instead of the real cause (a too-old Node). Promote the floor reason ahead of that branch and drop the now-dead switch case. Regression test pins the acp_status reason for the unsupported-node scenario.
…se and the ranxianglei#3818 default wording Rebase follow-up for ranxianglei#3896: the hand-maintained env-var row must carry both the PR's Node-floor sentence and master's post-ranxianglei#3818 'Defaults to full when unset' tail - the two independent conflict resolutions had split them. Same fix in CONFIGURATION.zh-CN.md.
Fixes #3894.
Problem
better-sqlite3@13.0.3declaresengines: { "node": ">=22" }, but the self-bootstrap pin carried onlyversion+sha512Base64, andtryRegisterFromCache()treated a successfulrequire()as "usable". On Node 20 the binding is outside its declared engine range, so loading it is undefined behavior, not a clean failure:process.dlopen(access violation, exit3221225477)require()returns the constructor and the fault happens on the firstnew Database()(Node 20 Docker startup segfaults after SQLite self-bootstrap #3341)Reproduced deterministically on this machine:
This is not the graceful degrade of #3338/#3385 — the process dies, and the retry loop turns it into a crash loop (1485 consecutive proxy-child crashes over 8h on the reporter machine, model traffic silently going direct the whole time).
A
try/catchcannot help (verified: wrapping bothrequire()andnew Database()on Node 20 prints nothing and exits 139), so an in-process probe is not a fix — the guard has to run before the binding is loaded at all.Fix
Give the pin the artifact's own Node floor and enforce it in
runBootstrap():EngineBootstrapSpecgainsminNodeMajor: number;DEFAULT_ENGINE_SPECgetsminNodeMajor: 22(from 13.0.3'sengines.node). The pin now moves version + digest + floor together.nodeMajorSatisfiesFloor(minNodeMajor, nodeVersion)— unparseable versions count as satisfied (fail-open:process.versions.nodeis semver by contract, and bricking unified storage on an exotic runtime is the worse failure).runBootstrap()returns{ status: "unsupported-node" }with an explicit upgrade reason below the floor. Placement is load-bearing: after the builtin/host probes (a host-installedbetter-sqlite3@12on Node 20 is perfectly valid and must not be blocked) and beforecacheUsable()(a cached 13.0.3 copy is exactly the crash source — a cache hit would otherwise crash too, which is precisely what the reporter's machine did).runtime-status.tsdegradeReason()gains anunsupported-nodecase so the diagnostics blob explains the degrade instead of falling back to the generic "no engine" line.Restores pre-#2833 behavior on Node 20 (legacy JSON storage) instead of crashing.
Config surface
None. No new config key, no new
BILI_*env var, no CLI flag, no persistence-format or wire change. The floor lives next to the version + digest it belongs to, so a future engine bump cannot forget it (both are bumped in the same PR by construction).Tests
tests/storage-engine-bootstrap.test.ts, both directions per the gate discipline (#3617):nodeMajorSatisfiesFloor— below/at/above the floor, a floor other than 22 (predicate follows its argument, doesn't hardcode), and the unparseable fail-open case.unsupported-node, matching detail,reg.requests() === 0(the ~11 MB download never starts), no cache dir written, no.bootstrap-failed.json(no cooldown armed), andopenSqliteDatabase()still throwsno SQLite engine available.cacheUsable()-passing cache + floor above any runnable Node →unsupported-node, no re-download, the cache files survive, and the loader is not registered.downloadedpath, engine opens asbetter-sqlite3/self-downloaded.Existing fixtures were updated with
minNodeMajor: 20(a neutral value that never triggers the gate on any CI Node), so they keep asserting "the gate is not what these tests are about".Docs
CONFIGURATION.md/CONFIGURATION.zh-CN.mdregenerated fromwebsite/config-reference/process.yaml(node tools/gen-config-docs.mjs generate, i18n check green) — the seed yaml is the only edited source.Verification (local)
tests/storage-engine-bootstrap.test.ts— 34/34 passtests/storage-diagnostics-lines.test.ts+tests/acp-status-storage-degraded.test.ts+tests/web-storage-banner.test.ts— 10/10 passtests/storage-engine-proofs.test.ts+tests/snapshot-render.test.ts— 24/24 passtsc --noEmit --project tsconfig.json— cleannode scripts/check-test-import-graph.mjs— ok;check-unused-exports.mjs— only the pre-existingmaskUrlForPublishfindingensureSqliteEngine()now logsskipped — better-sqlite3@13.0.3 needs Node.js >= 22, this is 20.19.5; a self-downloaded engine would crash this process on loadand returns{"status":"unsupported-node"}; the process survives (exit 0) instead of segfaulting, and the cache is left empty.The full-suite verdict is the remote CI on this head, per §7.2.
Notes
kernel/change, nosrc/update.tschange, no config schema change.