Repository navigation
[PR] fix(ci): non-ci:full label events no longer cancel in-flight CI runs - #3828
Merged
Merged
Conversation
Contributor
📦 Built Package ArtifactBranch: Option A — Install this exact build (recommended)npm install -g billion-context@0.0.4530-pr.3828.a424191This exact version is immutable and reproducible. The rolling Option B — Download artifact
tar xzf billion-context-pr3828.tgz
npm install -g packageInstall instructions are refreshed on each push. |
#3772) A `labeled` event for any non-ci:full label starts a run whose gate/plan job immediately decides skip, but it shared the per-ref concurrency group of in-flight real runs with cancel-in-progress=true — so the vacuous skip-run cancelled the real matrix mid-flight and then recorded success with an empty matrix (false green + 40+ cancelled runs per label burst; #3770 repro). Append a `-skip` suffix to the concurrency group for exactly those trigger-time events (pull_request + labeled + label != ci:full — the same predicate each gate/plan job already uses), so skip-runs can never cancel in-flight runs; they finish in ~20s as a harmless trace. ci:full labeled runs stay in the base group and still supersede in-flight core runs (#3295); schedule/dispatch/push events are unaffected (suffix is ''). All 13 workflows with a labeled trigger AND a cancel-in-progress group: ci.yml, ci-image.yml, ci-e2e.yml, ci-registry.yml, ci-zcode-real.yml, ci-e2e-dsh.yml, ci-e2e-dsh-native.yml, ci-e2e-codex-persona.yml, ci-e2e-native.yml, ci-e2e-native-opencode.yml, ci-e2e-pi-ws.yml, ci-windows-codex.yml, ci-e2e-fake.yml. ci-theorem.yml excluded: no concurrency block, nothing to cancel there.
ranxianglei
force-pushed
the
2026-10-19_label-skip-concurrency
branch
from
October 19, 2026 12:40
80e5d1b to
6d76e56
Compare
Contributor
📦 Merged Build PublishedThis merge to master was published as npm install -g billion-context@0.0.606-master.85c27f0 # this exact build
npm install -g billion-context@master # always the newest merged build
|
This was referenced Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3772
What & why
Any
labeledevent on a PR for a label other thanci:full(the label-sync pipeline mirrors issue labels bug/p2/scope/... onto PRs, so this fires routinely) starts a workflow run whose gate/plan job immediately decides skip — but that run shared the per-ref concurrency group of in-flight real runs, withcancel-in-progress: true(#3331). The vacuous skip-run therefore cancelled the real matrix mid-flight and then recorded success with an empty matrix: a false green plus 40+ cancelled runs per label burst (repro timeline in #3772, from the #3770 review).Fix (option A from the issue)
Append a
-skipsuffix to the concurrency group for exactly the skip-scoped events, computed at trigger time from context:The suffix predicate is the same one each gate/plan job already uses to decide skip, so the group name cannot drift from the gating logic. Effects:
ci:fulllabeled runs stay in the base group → still supersede in-flight core runs (feat!: remove image pre-compression and the image_full tool (#3266) #3295 widening semantics unchanged);'', groups byte-identical to before.Rejected alternative (keep the base group, conditionally disable cancel-in-progress): skip-runs would queue behind in-flight runs for up to ~30min instead of finishing immediately.
Files — all 13 workflows with a
labeledtrigger AND a cancel-in-progress groupci.yml, ci-image.yml, ci-e2e.yml, ci-registry.yml, ci-zcode-real.yml, ci-e2e-dsh.yml, ci-e2e-dsh-native.yml, ci-e2e-codex-persona.yml, ci-e2e-native.yml, ci-e2e-native-opencode.yml, ci-e2e-pi-ws.yml, ci-windows-codex.yml, ci-e2e-fake.yml
ci-theorem.ymldeliberately untouched: it triggers onlabeledbut has no concurrency block, so nothing there can be cancelled.Behavior change (disclosed per policy)
Old: a non-ci:full label event on a PR cancelled that PR's in-flight CI runs (core matrix + every matching lane) and left a vacuous skip-green behind. New: such events leave in-flight runs alone; the resulting skip-run is isolated and completes immediately. No change to what runs when — opened/synchronize/reopened/ci:full/schedule/dispatch semantics are identical.
Verification
python yaml.safe_load).