Repository navigation
[PR] fix: replay incremental cold history from ordered raw row pointers - #3802
Closed
yanhuojiyusheng wants to merge 1 commit into
Closed
yanhuojiyusheng wants to merge 1 commit into
yanhuojiyusheng wants to merge 1 commit into
Conversation
Owner
|
ework接单拿 |
Owner
(ai: vllm-qwen/qwen3.8-27b) 查重: 不重复 —— #3798 是该机制(增量车道冷重建丢共享前缀)的唯一 issue;open PR 里其余 incremental 相关项各管别的切面(#3797 system 传播、#3440 wire 契约、#3257 前缀快路径、#3466 GC、#3473 消息 id),没有第二个动冷重建/baseSeq 机制的。 审核过程(独立于 #3798 线程的早前分析,重新做过)
结构化八问
行为变更披露(有意变更,旧值 → 新值)
结论可合(人工合并;agent 不能 merge)。rebase 到当前 master 已验证干净,定向测试全绿,CI 绿,无回归发现,验收标准逐条有测试钉住。 |
Owner
|
(ai: zhipuai-lb/glm-5.3) 陈旧票清理(第三批动作①):目标 issue #3798 已关。为避免重复劳动关闭本 PR;如判断有误请直接 reopen 并留言。 感谢 @yanhuojiyusheng 的贡献与排查——这条修复路径已被其他方式覆盖;欢迎认领其他 open issue。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3798
After an incremental client resyncs
[A, B, C](or edits onlyC), a cold canonical rebuild slices the audit table after its old row count. The store deduplicates shared message identities, so the acknowledged three-message history becomes empty or contains only the edited row. The nextsinceSeq: 3request incorrectly returns 409.Persist the ordered raw tail row pointers in the existing session extension table, in the same transaction as full and delta raw ingests. Cold replay follows this list, preserving reused rows, order and repeated slots. Folded/envelope-only saves retain the last raw list; older sessions can use the existing tail pointers or legacy epoch fallback. Invalid or dangling pointers request resync, and an explicit full resync can replace that state. Keep the pre-resync write fence so an outgoing branch save cannot overwrite its replacement.
Validation:
node --import tsx --test tests/incremental-lane.test.ts: 24 passed.node --import tsx --test tests/storage-ingest-watermark.test.ts: 16 passed.node --import tsx --test tests/storage-save-path.test.ts tests/storage-json-writer-off.test.ts tests/issue3406-writenow-concurrent.test.ts: 8 passed.npm run typecheck,npm run build, andgit diff --checkpassed. Full-suite results are left to the remote CI lanes.This affects the opt-in incremental lane. It adds an internal ordered-view extension value without a database schema migration or configuration change. Persistence/replay behavior needs human review; no kernel changes.