Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,11 @@ jobs:
# pi-lane component — its own unit suite against its TS source.
- run: npm --prefix pi-subagents test
- run: npm run build
# #3617-C: thin-install smoke — install ONLY the packed tarball into a
# scratch dir (no repo node_modules) and run it: catches ANY undeclared
# runtime dependency in the bundles at import time (the #3511 zod class;
# generalizes #3519's static-only check).
- run: node scripts/check-dist-thin-install.mjs

version-guard:
runs-on: ubuntu-latest
Expand Down
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
"typecheck": "tsc --noEmit --project tsconfig.json",
"check:unused-exports": "node scripts/check-unused-exports.mjs",
"check:test-import-graph": "node scripts/check-test-import-graph.mjs",
"check:dist-thin": "node scripts/check-dist-thin-install.mjs",
"pretest": "node scripts/test-suite-lock.mjs gate && npm --prefix kernel run build && npm --prefix pi-subagents run build",
"test": "node scripts/test-suite-lock.mjs run",
"start": "node dist/index.js",
Expand Down
86 changes: 86 additions & 0 deletions scripts/check-dist-thin-install.mjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,86 @@
// Thin-install smoke (#3617-C, generalizes the #3511 zod class): pack the
// current tree, install ONLY the tarball into a scratch dir with no repo
// node_modules, then prove the artifact actually runs:
// 1. `node dist/index.js --version` exits 0 (the CLI entry loads);
// 2. every Node-consumed dist/agent/*.js entry IMPORTS in its own process
// without throwing — an undeclared runtime dependency fails here at
// import time, exactly where it would fail in a real consumer's process
// (static analysis like check-dist-external-zod can only see one known
// offender; this catches any future one).
// Run after `npm run build` in CI (static-gates). Deliberately NOT part of
// the local build chain or the prepare gate: it needs registry access for
// the package's declared deps and must never slow a consumer install.

import { execFileSync, spawnSync } from "node:child_process";
import { existsSync, mkdirSync, mkdtempSync, readFileSync, readdirSync, rmSync, writeFileSync } from "node:fs";
import os from "node:os";
import path from "node:path";
import process from "node:process";
import { fileURLToPath, pathToFileURL } from "node:url";

const root = path.resolve(path.dirname(fileURLToPath(import.meta.url)), "..");
// NOTE: spawning npm.cmd on Windows requires shell:true (Node >= 18.20/22
// hardening, CVE-2024-27980) — EINVAL otherwise. Same pattern as
// scripts/run-ci-tests.mjs:141.
const npmCmd = process.platform === "win32" ? "npm.cmd" : "npm";

function fail(msg) {
console.error(`dist-thin-install: FAIL — ${msg}`);
process.exit(1);
}

if (!existsSync(path.join(root, "dist", "index.js"))) {
fail("dist/index.js missing — run `npm run build` first");
}
const repoVersion = JSON.parse(readFileSync(path.join(root, "package.json"), "utf8")).version;

const scratch = mkdtempSync(path.join(os.tmpdir(), "bili-thin-install-"));
try {
// 1. Pack + install the tarball alone (declared deps come from the
// registry; nothing from this checkout).
execFileSync(npmCmd, ["pack", "--pack-destination", scratch, "--loglevel=error"], { cwd: root, stdio: "pipe", shell: process.platform === "win32" });
const tarball = readdirSync(scratch).find((f) => f.startsWith("billion-context-") && f.endsWith(".tgz"));
if (!tarball) fail("npm pack produced no tarball");
const installDir = path.join(scratch, "install");
mkdirSync(installDir, { recursive: true });
writeFileSync(path.join(installDir, "package.json"), JSON.stringify({ name: "bili-thin-smoke", version: "0.0.0", private: true }, null, 2));
execFileSync(npmCmd, ["install", path.join(scratch, tarball), "--no-audit", "--no-fund", "--loglevel=error"], { cwd: installDir, stdio: "pipe", shell: process.platform === "win32" });
const pkgDir = path.join(installDir, "node_modules", "billion-context");
if (!existsSync(path.join(pkgDir, "dist", "index.js"))) fail("installed tarball has no dist/index.js");
const installedVersion = JSON.parse(readFileSync(path.join(pkgDir, "package.json"), "utf8")).version;
if (installedVersion !== repoVersion) fail(`installed version ${installedVersion} != repo version ${repoVersion}`);

// 2. CLI entry runs and reports its version.
const cli = spawnSync(process.execPath, [path.join(pkgDir, "dist", "index.js"), "--version"], { encoding: "utf8" });
if (cli.status !== 0 || !/\d+\.\d+\.\d+/.test(cli.stdout ?? "")) {
fail(`dist/index.js --version exited ${cli.status}: ${(cli.stderr ?? "").slice(0, 400)}`);
}

// 3. Every agent entry imports standalone (own process each: a real host
// loads exactly one bundle, so cross-bundle interference is not a signal).
const agentDir = path.join(pkgDir, "dist", "agent");
const entries = readdirSync(agentDir).filter((f) => f.endsWith(".js") && !f.endsWith(".map")).sort();
if (entries.length === 0) fail("no dist/agent/*.js entries found in the tarball");
const imported = [];
const parsed = [];
for (const name of entries) {
const file = path.join(agentDir, name);
if (name === "dsh-native-client.js") {
// Browser bundle by design (tsup platform:"browser", cjs,
// window.__ModuleLoader__ format, react external): it cannot be
// imported in Node. Parse-check it instead — a broken build still
// fails here, and it has no Node-visible externals to miss.
const chk = spawnSync(process.execPath, ["--check", file], { encoding: "utf8" });
if (chk.status !== 0) fail(`parse check failed for ${name}: ${(chk.stderr ?? "").slice(0, 400)}`);
parsed.push(name);
continue;
}
const probe = `await import(${JSON.stringify(pathToFileURL(file).href)});`;
const r = spawnSync(process.execPath, ["--input-type=module", "-e", probe], { encoding: "utf8" });
if (r.status !== 0) fail(`import failed for ${name}: ${(r.stderr ?? "").slice(0, 400)}`);
imported.push(name);
}
console.log(`dist-thin-install: OK — cli ${installedVersion}; imported ${imported.length} agent bundle(s) [${imported.join(", ")}]; parse-checked browser bundle(s) [${parsed.join(", ")}]`);
} finally {
rmSync(scratch, { recursive: true, force: true });
}
Loading