Repository navigation
[PR] test: threads-lane fake upstream strictification + side-call 404 contract (#3617 B) | test: threads-lane 假上游严格化 + side-call 404 契约(#3617 B) - #3627
Conversation
📦 Built Package ArtifactBranch: Option A — Install this exact build (recommended)npm install -g billion-context@0.0.4272-pr.3627.47351f7This exact version is immutable and reproducible. The rolling Option B — Download artifact
tar xzf billion-context-pr3627.tgz
npm install -g packageInstall instructions are refreshed on each push. |
(ai: vllm-qwen/qwen3.8-27b) 查重: 不重复——本 PR 是 #3617 六项中的 B(threads-lane 假上游严格化 + side-call 404 契约);同 issue 的兄弟 PR A(#3620)、D(#3625)、F(#3626)各管各的条目,open/closed 检索无同签名(threads-lane fake strict / sideCallFailStatus)条目。 初审发现一个必须先处理的问题:基线落后(stale base)。分支从 按 §7.2(rebase 到当前 master 再谈 mergeable):我现在把分支 rebase 到 |
…act (#3617-B) The threads-lane test fake answered 200 for ANY request url — the exact permissiveness that let #3569 (summary side-call sent to the bare origin, permanent 404 in production) ship green: the side-call 'succeeded' in every test while failing forever in prod. Two changes:\n\n1. Strict mode: unknown paths now get a real anthropic-shaped 404 (not_found_error); only POST /v1/messages answers. A wrong-path side-call regression now lands as a genuine failure — both the forwardedPaths pin (#3569 assert) and the dependent reforge asserts (no SUMMARY head → no reforged create) go red.\n2. New contract test for the #3569 production signature: the side-call receives 404 (harness gains sideCallFailStatus, default stays 500) → the lane must fail open (client continue forwarded untouched) AND cool down (no doomed retry re-uploading the transcript), same discipline as the existing 500 cooldown test.\n\nFirst of the incremental fake-strictness migration proposed in #3617-B ('逐个 fake 迁移'); the shared e2e fakes (fake-upstream.mjs / fake-upstream-chat.mjs) are already strict. Test-only.
d7668e7 to
6920b18
Compare
📦 Merged Build PublishedThis merge to master was published as npm install -g billion-context@0.0.552-master.c987c60 # this exact build
npm install -g billion-context@master # always the newest merged build
|
(ai: vllm-qwen/qwen3.8-27b)
Part of #3617 item B(fake upstream 严格模式)。纯测试 PR,无源码改动。
背景
#3569:threads lane 的 summary side-call 打到了裸 origin(没有路径),生产 anthropic 恒 404——但
tests/threads-lane.test.ts的假上游对任何 url 都回 200,side-call 在测试里永远「成功」,于是带病发版。这就是 #3617 说的「假绿绝根」对象。改动
not_found_error),只有POST /v1/messages应答。路径回归一旦复发:side-call 拿到真 404 → fail-open → reforge 断言(SUMMARY head 缺失 → 没有 reforged create)和forwardedPaths钉点同时红。sideCallFailStatus(默认仍 500,既有用例不动),新用例按 [Bug][threads lane] reforge summary side-call always 404s: executeThreadsReforge receives the upstream origin instead of /v1/messages, compression never completes (0.1.198) | [Bug][threads lane] reforge 摘要 side-call 恒 404:executeThreadsReforge 收到的是上游 origin 而非 /v1/messages,压缩从未完成(0.1.198) #3569 的生产签名(404 not_found_error)验证:side-call 失败后 continue 原样转发(fail-open)+ 冷却期内不重传(cooldown,与既有 500 用例同纪律)。范围说明
#3617-B 说「逐个 fake 迁移,不需要一次全改」。本 PR 迁的是造成 #3569 假绿的那个 fake;两个共享 e2e fake(
tests/e2e/fake-upstream.mjs、fake-upstream-chat.mjs)核查过已经是严格的(未知路径 404)。其余单测内联 fake 的迁移留作后续(可按同样模式逐个做)。验证
node --import tsx --test tests/threads-lane.test.ts→ 10/10 通过(9 既有 + 1 新);npm run typecheck干净;Closes 无——本 PR 是 #3617 六项之一,issue 待六项全部合入后关闭。