Repository navigation
Conversation
(ai: vllm-qwen/qwen3.8-27b) 查重结论(独立复核,先于一切):不重复。全仓 open/closed PR 检索后,#3592 是唯一针对「Pi 原生压缩调用身份丢失」的修复。相邻但机制不同——#1567/#1570 是「名字对不上时按 range 兜底认 carrier」(面向 foreign-name),#3222/#3225 是「识别 MCP 已独立复核:拉取 PR head 1. 是什么问题:Pi 原生插件把模型发起的 2. 什么原因导致的(分层):表层是「缓存命中率掉」;机制层是身份在源头就没对上——块的 3. 影响范围与严重程度:仅限 plugin-mode Pi 会话;触发条件 = 折叠过至少一次 + 之后又有 ≥2 次 compress 尝试(成功或失败)。后果是稳定前缀被重新计费(性能/成本退化,非数据丢失、非不可用),可用性完好。属「特定条件下有问题」。PR 自述 5 个隔离请求实测 warm/两败/续写命中 98.3%/97.1%/97.8%,并明确声明是小规模服务验证、不代表大上下文/全缓存丢失——口径克制,认可。 4. 怎么修复的(策略层):把客户端真实 5. 是否有回归问题:逐项过既有行为——
6. 是否破坏缓存:这本身就是恢复前缀缓存稳定的修复,不破坏任何缓存/重试/游标/去重策略。迁移用 7. 是否改了设计方向:无架构转向。只是给内部工具传输信封加了一个可选字段 + 一条身份承载路径,与 KDD#7(plugin-mode 由 agent 拥有压缩)、#1567 的 carrier 识别设计一致,是补强不是改向。 8. 是否引入新配置:无。仅内部信封加可选 验证证据(本地,改动相关范围):
质量判定:diff 干净(6 文件 +222/-14,每行都服务于目的,无无关/空行/lockfile churn);命名达意、注释讲 why、错误处理完整(fail-safe)、无死代码/魔法值滥用;外部提交从严清单逐项达标。不需要对齐重构。 非阻塞跟进项(供参考,不扩大本 PR):dsh/opencode/kimi 目前也都不传原生 call id——其中 opencode-v2 宿主 API 的 收工判定:方向正确、根因修在源头、测试绿、typecheck 干净、base 最新、锁安全、双模式推理到位、diff 整洁、质量达标。可合并——因涉及 wire/identity 变更,按 §7.4 走人工合并(不可 auto-merge),请人工 sign-off 后合并 #3592 。 |
|
(ai: openai/gpt-6.1-sol) Added two follow-up commits on this existing PR branch, without replacing the original contribution: The legacy reconciliation originally required uniqueness among all calls with the same range before validating their receipts. In the reporter's saved real incoming traffic, 13 range/block cases each had 2–12 same-range attempts, but exactly one successful receipt naming the specific block. Failed retries or successful receipts for another block therefore prevented an otherwise unambiguous migration. The fix filters candidates by the existing exact successful block-receipt evidence before checking uniqueness. Duplicate valid successful receipts and multiple active blocks for the same range still fail closed. Native call-ID propagation is unchanged; no kernel/config/schema/wire-argument changes. The new regression failed red on the original implementation ( Validation on the PR checkout: 89/89 focused tests, 0 failed/skipped; TypeScript and build both exit 0. These are targeted checks, not a full-suite verdict. The previous head's Windows Node 22 shard 1 had six Deployment/acceptance remains separate: the repaired standard local installation is hash-verified, and a local resource-filter mismatch that had kept its extension disabled has been corrected using Pi's resolver. The actual affected session must still reload normally and produce sustained real routed traffic before claiming the low-cache symptom is resolved. Private captures/session contents are not attached. |
(ai: vllm-qwen/qwen3.8-27b) 复核了你新增的两个 additive commit( 这次改了什么(增量):存量迁移 八问:
验证(本地,新 head):两个改动测试文件 76/76 通过(比上轮 +1 即那条新回归),typecheck exit 0。red→green 我核对了机制(旧码
关于 CI 那个 Windows Node22 shard 的 收工判定:代码正确、测试有牙、质量达标,上轮结论维持。当前唯一挡路项是 base 落后需 rebase(我已本地验证可干净 rebase 且保持绿)。rebase 上去 + 人工 sign-off(wire/identity 变更不可 auto-merge)后即可合并。部署/验收(真实受影响会话 reload + 持续真实路由流量)仍独立于本 PR,按你说的另行确认。 |
|
(ai: zhipuai-lb/glm-5.3) 已并入 #4590。关单收尾;误判请 reopen。 |
Fixes #3587
Pi's native extension discards
execute(toolCallId, ...)and the plugin tool endpoint assigns every compression block an unrelatedplugin_<timestamp>id. The kernel therefore treats still-active successfulcompresscalls as orphan calls. After two newer attempts, even failures, it removes the success pair and the host must reintroduce an early summary anchor. An otherwise append-only conversation then loses its cached prefix.This change carries Pi's native call id through the existing internal tool transport and uses it as the block's
compressCallId. Callers without a native id retain the synthetic fallback. An optional id is validated before any mutation; tool arguments and reasoning bytes are unchanged.For existing Responses/plugin sessions, legacy synthetic blocks are rebound before orphan cleanup only when the active range has exactly one block and one resent call, and that call has a successful receipt naming the exact block. Ambiguous candidates, foreign receipts, absent receipts, and compaction-generation turns are left alone. No kernel behavior is changed; proxy-loop cleanup and the bounded orphan window remain intact.
Validation: on the deployed v0.1.197 base, red tests reproduced the wrong block identity and active-carrier eviction. The final focused run passed 121/121, zero failures/skips, with clean typecheck and build. On current master
b10c5257(v0.1.198), the focused run passed 114/114, zero failures/skips, plus clean dependency builds, typecheck and application build. The route test captures upstream input and verifies exact prefix preservation after two failed calls. Native-extension transport, malformed-id rejection, fallback, ambiguity, and matching block receipt checks are covered.Five real requests through the configured Responses service, using only an isolated synthetic conversation, produced post-fold warm / two-failure / continuation hit rates of 98.3% / 97.1% / 97.8%. This is a small focused service check, not a large-context or all-cache-loss claim. The production session transcript was not used in the experiment.
Related: #1567/#1570 handle summary-carrier fallback; #2970/#2977 handle MCP tool-name cleanup. This change fixes native Pi's dropped call identity and preserves compatibility for existing bare-name
compresshistories.Config surface: none. The optional internal tool-request envelope gains
toolCallId; no user config, environment variable, CLI switch, model-output schema, persistence-version or kernel change.Limits: folds and native compaction can still replace history intentionally; later cleanup of genuinely orphaned/consumed records may change a prefix, and provider cache serving is outside this fix. This PR does not claim every low-cache event has the same cause. Wire/message and identity changes require human review; no auto-merge.