Repository navigation
CI flake backstop: graceful-close legs get a timeout budget + one fresh-port retry (#3454) - #3458
Merged
Merged
Conversation
… retry (#3454) windows-latest intermittently wedges a leg's transport in the connect/handshake phase under load; the suite had no recovery, so one stall hard-failed CI and blocked merge. Add load-tolerant per-phase budgets (CONNECT/handshake 5s, response 8s->15s, READY 30s), classify pure transport stalls as TransportTimeout, and on one such stall re-run the whole scenario on a fresh child + fresh ports. Behavior assertions and lifecycle-line waits stay non-retriable so a real regression fails fast. Teardown try widened so a READY-stall also cleans up. Server side untouched. Closes #3454
Contributor
📦 Built Package ArtifactBranch: Option A — Install this exact build (recommended)npm install -g billion-context@0.0.4075-pr.3458.4b3eed0This exact version is immutable and reproducible. The rolling Option B — Download artifact
tar xzf billion-context-pr3458.tgz
npm install -g packageInstall instructions are refreshed on each push. |
Contributor
📦 Merged Build PublishedThis merge to master was published as npm install -g billion-context@0.0.508-master.896e734 # this exact build
npm install -g billion-context@master # always the newest merged build
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3454
What & why
The
windows-latestshard intermittently wedges a leg's transport in the connect/handshake phase under load, andtests/graceful-close.test.tshad no recovery: a single timeout-class failure hard-failed the suite with no retry, so one stall blocked the merge (it stalled #3425 for a rerun cycle). The hang is a platform-load flake, not a code regression — local Linux rerun was 8/8 green, same-day master went red on other suites then self-healed, and zero server/graceful-close paths changed in the window. What was actually missing is test-side resilience.Change (test-only —
tests/graceful-close.test.ts)TransportTimeout; on one such stall the entire scenario re-runs on a fresh child + fresh ports before failing.tryso a READY-stall also tears down its child + mock upstreams (prevents a cross-attempt resource leak into the retry).Server side is untouched — the listen/close semantics are the verified #1982 behavior contract and out of scope for flake-hardening.
Behavior-change disclosure (test-side only)
No product/runtime behavior change. No config surface added.
Verification
tsc --noEmitclean; targetednode --import tsx --test tests/graceful-close.test.tsgreen (all five graceful-close steps, ~5.3s).testlanes).查重: 无 — searched open+closed issues/PRs for the graceful-close / windows-connect-flake family; none found (distinct from #3449 / #3420 / #3237, which are different test files and assertions).