Repository navigation
Lane decisions: single resolver for the four wire adapters — observed tool reachability fixes #3401 (#3417) - #3427
Conversation
📦 Built Package ArtifactBranch: Option A — Install this exact build (recommended)npm install -g billion-context@0.0.4082-pr.3427.3b6b29cThis exact version is immutable and reproducible. The rolling Option B — Download artifact
tar xzf billion-context-pr3427.tgz
npm install -g packageInstall instructions are refreshed on each push. |
(ai: vllm-qwen/qwen3.8-27b) 查重结论:不重复,但存在同根因双 PR。 检索 open+closed 后确认:#3403(最小门控修复:lane 名 → wire 可达性判定)与本 PR #3427(#3417 v2 计划 Steps 1–3 的单 resolver 重构,含 #3403 的修复语义)都指向 #3401。这不是简单重复——#3427 范围更大且吸收了 #3403 的行为变更;但按「一个 issue 最多一个 PR」纪律,若本 PR 合入,#3403 应作为被取代项关闭(反之亦然)。此点会写进最终审查结论,处置等你拍板。 开始按规范审本 PR:方向关(原 issue #3401/#3417)→ 整体回归清点 → 逐段 diff → 测试有效性 → CI 状态。本地只跑定向套件,全量交给远程 CI。稍后回结构化八问结论。 |
…nses (#3427 review) All responses-wire reads migrated to laneDecisions.compressSurfaceOn, leaving the alias an unused local (noUnusedLocals not enabled). Removes the dead line and its now-stale comment clause.
(ai: vllm-qwen/qwen3.8-27b) 审查结论:可合并(一处小修已直接修掉并推上分支,见下)。 查重:不重复;同根因双 PR 情况维持首条回复判定——#3403 范围被本 PR 严格吸收,本 PR 合入后 #3403 应关闭(等你拍板)。 方向关(原 issue):方向正确,打的是根因。#3417 的病因是「lane 名当可达性代理 + 同一门控四份拷贝各自漂移」,本 PR 落地了 v2 计划(#3417 comment 6217747677)的三层终态:① HostProfile 注册表(名字比较只活在这一个地方)② WireObservation(按请求实测 wire 上声明了哪些 bili 工具,点名 precision)③ 回归清点(逐项既有行为):
行为变更披露(旧 → 新): 代码级发现与处置:
验证证据:
结构化八问:
收工判定:可合并。建议顺序:等新 head 4536e12 CI 绿 → 合并 → 关闭 #3403(被取代)。PR 留出的后续(willInjectNudge 归一、B-class 站点迁移)按 #3417 清单继续即可。 |
(ai: vllm-qwen/qwen3.8-27b) CI 跟进(修复 commit
已触发该 run 的 failed-job 重跑(run 38926853126)。若重跑转绿即结案;若同一断言再红,那就不是 flake,会按真回归排查。 |
(ai: vllm-qwen/qwen3.8-27b) 重跑结果: 两点收尾说明:
审核侧无遗留待办:回归清点、行为变更披露(① #3401 目标行 surface off→on;② anthropic wire + injectTool=false 时 nudge 与其余三 wire 对齐;③ resolveHostProfile trim 的无害 nit)、F1 死变量已修( |
fixes #3401 (#3417) - src/server/lane-decisions.ts: HostProfile registry (only name-comparison point) + WireObservation (per-request declared bili tools) + resolveLaneDecisions() consumed by all four prepares - #3401 fix: dsh profile declaring compress on the wire keeps the compress surface (observation overrides the host-scope default) - biliToolsDeclaredOnWire: named-tool precision (#3403 follow-up) - dsh compact-rebase gate x4 -> profile.compactsClientSide - tests/lane-decisions-matrix.test.ts: 4-wire x 4-row truth table (16 rows, #3401 row pinned green after the fix) + structural no-name-comparison guard
…nses (#3427 review) All responses-wire reads migrated to laneDecisions.compressSurfaceOn, leaving the alias an unused local (noUnusedLocals not enabled). Removes the dead line and its now-stale comment clause.
…rix (#3427 review) The disclosed anthropic-wire convergence (injectTool=false now suppresses the nudge on all four wires) had no truth-table row. One row per wire, expected {nudge:false, standingPrompt:false} — red on pre-fix master [anthropic], green here.
ca6ae2f to
63ec5fb
Compare
📦 Merged Build PublishedThis merge to master was published as npm install -g billion-context@0.0.501-master.2164823 # this exact build
npm install -g billion-context@master # always the newest merged build
|
…i#3600) PTC presets collapse every tool into a single run_code omnibus (SDK bindings nested inside), so the top-level tools array carries no compress entry. The ranxianglei#3427 reachability gate read that shape as unreachable and suppressed the compress surface on every dsh PTC session in released 0.1.198 — nudge suppressed to the 100% window (89x ARMED-SUPPRESSED), output clamped, session effectively dead, while standard-mode sessions kept compressing. An omnibus declaration now reads as reachable: top-level absence is not evidence of unreachability when the omnibus swallows everything. The ranxianglei#3177 true negative keeps its suppression (a bare single tool that is neither compress nor the omnibus still drops the surface). Truth-table rows added: run_code omnibus keeps the surface on all four wires; single non-omnibus tool still drops it.
Fixes #3401. Implements #3417 Steps 1–3 (v2 plan, comment 6217747677).
Why
The four wire adapters each carried their own copy of the lane gates, and the copies drifted twice (#3293 prompt/tool gate drift, #3401 lane name used as a reachability proxy — a dsh profile that DOES surface
compresson the wire still had the model-side compress surface dropped). 22 rawpluginAgent === "..."comparisons across 8 files.What
src/server/lane-decisions.ts— the three-layer terminal state from the plan:dsh/pi/omp/opencode): the ONLY place lane names are compared. Properties:toolsHostScopedByDefault,wantsBillingBlock,compactsClientSide.biliToolsDeclaredOnWire(parsed, proto, "compress")— fix: DSH 压缩面抑制改为按工具实际可达性判定 (#3401) #3403 review follow-up: the nudge advertisescompressspecifically, a lane with onlyacp_statusstays off).resolveLaneDecisions(): the one gate.compressReachable = !pluginMode (proxy injects structurally) || declaredTools.has("compress") (observation overrides the dsh default, #3401) || !profile.toolsHostScopedByDefault (host exposes by design, #3177). Frozen decision object; the four prepares consumecompressSurfaceOn/Off.Migrations in this PR:
dshCompressSurfaceOffcopies →laneDecisions.compressSurfaceOff#2432) →profile.compactsClientSideBehavior change (intended, exactly #3401)
compress+ host tools declaredacp_status+ host toolscompress.injectTool: falseinjectNudge, notinjectTool)compress; without the tool it is noise)Tests
tests/lane-decisions-matrix.test.ts17/17: 4 wires × 4 rows truth table (characterized BEFORE the fix — the [bug] #3177 的 DSH compress-surface 抑制在「agent 能看到 bili 工具」的 DSH 环境下误伤:nudge 与 compress 系统提示被永久关闭 #3401 row was pinned red on master first), the fix flips exactly that row, + structural no-name-comparison guard.Deliberately NOT here
willInjectNudge's 7-conjunct expression still lives per-prepare (reads the resolver's alias; centralization needs the loop-config inputs threaded — follow-up).handle.tsdsh title-sidecar evidence checks, pi/omp transport stamps) — kept per 根本原因立项:按 lane 名的大面积特判拷贝在 4 张 wire 适配器里各自漂移(#3293/#3401 同形 bug 家族),需要抽象重构 #3417 v2 classification, each with its evidence discipline.Rollout
None needed: the changed shape (dsh + tool-declaring) had the surface wrongly off — turning it on for that shape is the fix itself. Hosts that never declare tools see zero change, except sessions running with
compress.injectTool: false: on master their nudge could still fire against a tool that was never injected; post-fix it stays off everywhere for them (row above; added during the #3331 range-audit review).