Repository navigation
fix+docs: dsh sessions default to renderTags=none — no env var needed (#3198) - #3208
ranxianglei wants to merge 2 commits into
Conversation
📦 Built Package ArtifactBranch: Option A — Install this exact build (recommended)npm install -g billion-context@0.0.3687-pr.3208.5c60e65This exact version is immutable and reproducible. The rolling Option B — Download artifact
tar xzf billion-context-pr3208.tgz
npm install -g packageInstall instructions are refreshed on each push. |
…3208) The original commit edited the diagnostics.renderNone param row inside the generated bili:gen param-ref block without updating the single source of truth (website/config-reference/diagnostics.yaml, #2107); the docs-sync CI job (generate + git diff --exit-code) would revert the row and go red. Seed now carries the row text and regeneration reproduces the committed artifacts byte-for-byte (verified locally).
f6c36a0 to
cb93f6c
Compare
(ai: vllm-qwen/qwen3.8-27b) PR #3208 审核结论(方向关 / 回归关 / 代码关 / 测试关全过,发现并修复 1 处缺陷)① 原 issue 方向核实:#3198 的 A/B 数据与 OP 原文一致(对照 85.6% → 实验 91.2%,seam 消失);机制成立——dsh 在自己重发的历史里重渲染 bili 注入的标签,字节漂移产生缓存缝, ② 回归审查(既有行为逐项):
③ 发现并已修复的缺陷(独立标注 commit ④ 基线与验证:分支落后 master 181 个提交(其中 行为变更披露(旧→新+原因):
结构化八问
判定:修复后可合——待推送 head 上的 CI(docs-sync + test lanes)转绿即可由你合并。 |
(ai: vllm-qwen/qwen3.8-27b) CI 状态补充(接上条「待 CI 转绿」):run 38608883073 上 40 个 check 38 绿 2 红——红的两个( 判定:与本草稿无关的既有 CI 故障,非本 PR 引入——依据:
本 PR 自身验证面全部通过:docs-sync(seed 修复后绿)、static-gates ×4(typecheck/build)、kernel-guard / pi-subagents-guard / lane-guard / config-surface-guard / version-guard / lock-sync / docs-coverage / unused-exports、全部 e2e lane(registry×2、codex×5、dsh/opencode/pi native、image billing、OC V2 WS)、本地定向 5 套件 50/50。 收工判定更新:代码面可合;红灯是 #3206 家族的既有误红。两条出路任选——① 等 #3197 落地后本 PR 自然转绿;② 若你判断本 PR 验证面已足够,可忽略这两个已知误红 job 直接合并(合并后 master 的红灯与本 PR 无关)。按规则我不自行合并。 |
dsh re-serializes tag-shaped bytes in its own persisted history non-byte-stably, so every newly-tagged message breaks the upstream prefix cache on first resend (A/B: hit rate 85.6% -> 91.2% with renderTags=none). Make the validated treatment the DEFAULT for dsh-stamped sessions (x-bili-plugin: dsh -> sticky session.metadata.pluginAgent): renderNone resolution is now env > file > host-default(dsh:true, else false); an explicit diagnostics.renderNone (true OR false) or ACP_RENDER_NONE always beats the host default. All ten strategy/prompt-decision sites follow the same effective value (#1881: the NEVER-echo prompt follows the rendered tags). Refs stay assigned internally, so growth-gated folds keep working; cost is losing per-message ref citation in the model view for dsh sessions. One-time re-pay on upgrade for affected dsh sessions (~23K tok in the A/B), then stable. Docs: CONFIGURATION.md en+zh.
cb93f6c to
3d4b9bc
Compare
|
触碰红线 |
Closes #3198 (implements @Dog's item 3 「在不设置环境变量情况下修复」 plus the original suggestion 1 「document ACP_RENDER_NONE」).
Commits
f2226ff48docs — document ACP_RENDER_NONE as the dsh render-seam mitigation (CONFIGURATION.md en+zh,/acp-cacheclient-bucket hint in formatSeam(), web tooltip).3d4b9bca5fix — make the validated treatment the DEFAULT for dsh-stamped sessions.Behavior change (explicit disclosure)
ACP_RENDER_NONE > diagnostics.renderNone > falsefor ALL hosts; dsh users had to set the env var per host to avoid seams.ACP_RENDER_NONE > diagnostics.renderNone > host-default(dsh:true, else false). A dsh-stamped session (x-bili-plugin: dshheader → stickysession.metadata.pluginAgent) rendersnonewith NO variable set; every other host is byte-for-byte unchanged; an explicit file/env value (including explicitfalse) always beats the host default.What changed where
src/knobs.ts:renderNone(dshHost = false)— 4-tier resolution; an explicit file boolean is now honored both ways (previously only=== truemattered).tests/issue3198-dsh-render-default.test.ts(wire-level e2e: dsh default none / non-dsh unchanged / explicit-false wins) + knobs precedence tier test.Verification
Typecheck clean; build clean; targeted suites 59/59 green locally (issue3198-dsh-render-default, knobs-config-precedence, issue2483-render-strategy, cache-friendly-proxy, cache-seam-client-insert, cache-seam-detector, web-i18n). Full-suite verdict = the CI
testlanes on this head.Note: the investigation side of #3198 (exact byte-level break pattern) still awaits the reporter's raw seam-sample lines + control bili version; if those ever show SEAM-bucket attribution on ≥v0.1.197 builds, a follow-up issue will be filed per the escalation rule stated in-thread.