Repository navigation
test: regen storage-render goldens — #3093 live-stamp 字段进入会话 metadata - #3120
Closed
ranxianglei wants to merge 1 commit into
Closed
ranxianglei wants to merge 1 commit into
ranxianglei wants to merge 1 commit into
Conversation
…de in session metadata (#3093) Justification (required by tests/golden-storage-render.test.ts header): 64b50fd (#3093, merged via #3094) deliberately changed persisted state — createSession now initializes metadata with { biliVersion, storageMode } instead of {}, so the web detail panel can show provenance stamps for never-persisted sessions. That is an intentional persisted-state contract change, which per the S1 workflow permits regeneration. Verified the regenerated diff touches ONLY stateDigest + sectionDigests.metadata in each of the four wire goldens; wire bodies, state, blockContents and stats sections are byte-identical to before. The old claim in 64b50fd's message ('canonical.ts masks/drops these keys so digests are undisturbed') does not hold for this digest path.
Contributor
📦 Built Package ArtifactBranch: Option A — Install this exact build (recommended)npm install -g billion-context@0.0.3547-pr.3120.80a91ffThis exact version is immutable and reproducible. The rolling Option B — Download artifact
tar xzf billion-context-pr3120.tgz
npm install -g packageInstall instructions are refreshed on each push. |
This was referenced Oct 14, 2026
Owner
Author
(ai: vllm-qwen/qwen3.8-27b) 审核结论:不合并。 本 PR 已被 #3119(已合入 master)取代;合入它会把刚修好的 master CI 再次打红。以下结论为独立审核产出,已实测验证。 八问
处置(已执行):
判定:关闭,不合并。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
是什么问题
master 上 S1 storage-render golden(
tests/golden-storage-render.test.ts,四条 wire)全部失败:只有 metadata 段摘要漂移,wire body / state / blockContents / stats 与快照完全一致。所有后续 PR 的全量 CI 因此变红,无法区分 PR 回归与既有失败。根因
64b50fd48(#3093,经 #3094 合入)把createSession初始 metadata 从{}改为{ biliVersion, storageMode }(有意的持久化状态变更:live-stamp,让 web 详情页对未落盘会话也能显示来源戳)。最后一次金快照再生(2c0e3f32f,#3090 follow-up)早于该变更;该 commit message 中「canonical.ts masks/drops these keys so digests are undisturbed」的断言对这条 digest 路径不成立。详见 #3118。再生理由(tests/golden-storage-render.test.ts 文件头要求)
这是有意的持久化状态契约变更(live-stamp),按 S1 工作流「only a deliberate render contract change may regen」属于允许再生的情形。已验证再生 diff 只动四个 golden 文件的
stateDigest+sectionDigests.metadata(4 files, +8/-8),其余各段字节不变 —— 漂移范围与 #3093 的改动面完全吻合。验证
node --import tsx --test tests/golden-storage-render.test.ts5/5 ✅(再生前 4/4 红)Closes #3118