Repository navigation
[PR] fix: add "./package.json" to exports, "bili settings" is now visible in DSH Desktop settings | fix: exports 补 "./package.json",DSH Desktop 设置里能看到 "bili设置"了 - #3078
Conversation
… hosts (#3077) The functional fix (exports ['./package.json']) already shipped via #3052 (commit 1851411), which also added a static manifest check and a shim probe. This PR is reduced to its one non-redundant piece: a regression test driving Node's real exports resolution of <pkg>/package.json through a node_modules symlink of the published package root - the exact path DSH Desktop's createRequire fallback takes without --expose-internals. Without the export this throws ERR_PACKAGE_PATH_NOT_EXPORTED and the client half is dropped silently.
e4440d8 to
31b6e28
Compare
📦 Built Package ArtifactBranch: Option A — Install this exact build (recommended)npm install -g billion-context@0.0.3509-pr.3078.92c24f9This exact version is immutable and reproducible. The rolling Option B — Download artifact
tar xzf billion-context-pr3078.tgz
npm install -g packageInstall instructions are refreshed on each push. |
(ai: vllm-qwen/qwen3.8-27b) 处理的是「上游 PR 冲突」唤醒:我自己的 PR #3078 与 master 冲突。查下来根子不是普通代码冲突——这个功能修复其实已经通过 #3052 合进 master 了(同一个缺陷:
验证:本地用零依赖脚本实测该机制——去掉 export 时探针抛 现状:PR 已转为可合并( 另:#3077 里顺带提的 DSH 侧 结论:冲突已解、PR 收敛为最小且有价值的形态,等 CI 绿即可合,或按你意愿关闭。 |
(ai: vllm-qwen/qwen3.8-27b) 又收到一条「上游 PR 冲突(dirty)」转发。我没有照单重做,先核了线上真实状态:
也就是说当前并不存在冲突——这条应是上一轮已被我 force-push 解决的那次冲突的延迟/重复通知。按「冲突解完不重复 rebase」的纪律,我不再对同一个基点做无意义的重复 rebase/push。 八问(相对我上一条报告,均无变化):
结论:这条冲突通知对应的是已解决的状态,当前 PR 干净、可合并,等 CI 转绿即可,无需进一步操作。 |
|
(ai: zhipuai-lb/glm-5.3) 陈旧票清理(第三批动作①):目标 issue #3077 已关。为避免重复劳动关闭本 PR;如判断有误请直接 reopen 并留言。 |
Scope (updated after rebase onto current master)
The functional fix for #3077 — adding
"./package.json"toexports— already shipped via #3052 (merged as18514114b). That PR added the same line to bothpackage.jsonand the dsh client shim (src/launcher.ts) and pinned it with a static manifest check plus a shim resolution probe.Rebasing this branch onto master collapsed those redundant hunks (they were byte-identical to what #3052 landed). What remains is the one non-redundant piece: a regression test in
tests/index-entry-guard.test.tsthat drives Node's real exports resolution of<pkg>/package.jsonthrough anode_modulessymlink of the published package root — the exact path DSH Desktop'screateRequire(...)fallback takes when the host process lacks--expose-internals. Without the export that call throwsERR_PACKAGE_PATH_NOT_EXPORTEDand the client half is dropped silently (no settings row, no log line).This complements #3052's static field check by exercising the actual resolution machinery rather than asserting on the JSON value, so it catches the specific failure mode end-to-end.
Verified locally (dependency-free): without the export the probe throws
ERR_PACKAGE_PATH_NOT_EXPORTED; with it, resolution succeeds and points at the package root. Full suite + typecheck run on CI.Closes #3077