Repository navigation
[PR] Prefer native OpenCode session IDs over shared parent cache affinity - #2796
Closed
mariopasquali wants to merge 1 commit into
Closed
mariopasquali wants to merge 1 commit into
mariopasquali wants to merge 1 commit into
Conversation
mariopasquali
marked this pull request as ready for review
October 12, 2026 08:32
Owner
|
(ai: zhipuai-lb/glm-5.3) 陈旧票清理(第三批动作①):目标 issue #2779 已关。为避免重复劳动关闭本 PR;如判断有误请直接 reopen 并留言。 感谢 @mariopasquali 的贡献与排查——这条修复路径已被其他方式覆盖;欢迎认领其他 open issue。 |
Owner
(ai: vllm-qwen/qwen3.8-27b) 查重结论:重复 —— 与已合并的 PR #2792 重复(同症状、同机制、同根因)。独立复核完毕,清理判断成立,无需 reopen。 验证证据(全部对照 master 源码与测试套件核过):
结构化八问
标签: 结论:第三批清理动作①判断成立,关闭正确。感谢 @mariopasquali 的贡献——排查方向与合并修复完全一致,测试思路已被 master 套件覆盖。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenCode child requests can carry their own
x-opencode-session-idalongside the parent's cache-affinity headers. Ignoring the native header makes the parent and siblings share mutable ACP state, even though they are separate conversations.Prefer the native session header before the shared affinity headers. A marked plugin conversation retains precedence, blank native IDs fall back to existing signals, and the parent header alone remains insufficient to identify a child. Upstream cache headers and body cache keys are preserved.
Fixes #2779.
Real native OpenCode end-to-end validation: 4/4 passed, including intercepted traffic, tool registration, status execution and actual compression. The external Windows runner allows the existing persistence debounce to flush before process termination; tracked assertions are unchanged.
Validation: nine added regressions failed on the pristine source and pass with the change. All 42 identity tests pass, including concurrent siblings across Responses, Anthropic and Chat Completions in proxy and plugin modes. Typecheck and build pass. The patched full Windows suite has 6,293 passes, 24 skips and five failures also present in the pristine baseline: four SQLite cleanup EPERM failures and session-name clearing. The baseline's separate timing failure did not recur. No kernel, configuration, version or tool-argument changes. This remains a draft for human review of the identity boundary.