Repository navigation
test: account for the #2592 rebase ref-floor pin in the #2658 rig (unred master) - #2747
Merged
Merged
Conversation
#2742 (93c53e8) pins the ref floor after a native-compaction rebase (reserveRefsThrough adds the REF_FLOOR_RAW_ID sentinel to byRaw). The three newer sibling rigs adopted the 'N+ref-floor' convention; this older rig kept the pre-pin counts, so master's test matrix is red on all four legs (the same four failures were already visible on #2742's own head). Fix the two stale counts (3->4 at the rebase, 4->5 after the follow-up turn). Refs #2592, #2742
Contributor
📦 Built Package ArtifactBranch: Option A — Install this exact build (recommended)npm install -g billion-context@0.0.2997-pr.2747.ae7f3ceThis exact version is immutable and reproducible. The rolling Option B — Download artifact
tar xzf billion-context-pr2747.tgz
npm install -g packageInstall instructions are refreshed on each push. |
Contributor
📦 Merged Build PublishedThis merge to master was published as npm install -g billion-context@0.0.266-master.92bc2ab # this exact build
npm install -g billion-context@master # always the newest merged build
|
ranxianglei
added a commit
that referenced
this pull request
Oct 11, 2026
This was referenced Oct 11, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Master's
testmatrix is red on all four legs since #2742 merged (93c53e8, fix #2592 F5). #2742's own head already showed the same four failures. Two stale assertions intests/issue2658-dsh-anthropic-google-compaction.test.tspredate the ref-floor pin:assertRebased:byRaw.length === 3→ 4 (checkpoint + 2 retained + ref-floor)=== 4→ **5` (4 with ref-floor + 1 new), in both the anthropic and google scenariosWhy this is the right fix (not a product bug)
93c53e8 pins the pre-rebase ref high-water mark via
reserveRefsThrough, which adds theREF_FLOOR_RAW_IDsentinel (bili:ref-floor) tobyRaw— same discipline asapplyCompactionArchive(#395) and fork adoption. The three newer sibling rigs already adopted theN + ref-floorconvention after the same pin:=== 4 ... + ref-floor)=== 4 ... + ref-floor)=== 4 ... + ref-floor)Only the oldest rig (#2658) kept pre-pin counts. The floor pin itself is correct and load-bearing (refs are never reused within a session; without the pin a rebase could re-allocate a ref the model still remembers onto different raw content).
Verification
tests/issue2658-dsh-anthropic-google-compaction.test.ts6/6 green on this branch (2 red on master)Unblock
Every open PR inherits the red matrix (#2743, #2744, ...). Merging this first turns master green; PRs rebase onto it.
Refs #2592, #2742, #2658.