Skip to content

test: account for the #2592 rebase ref-floor pin in the #2658 rig (unred master) - #2747

Merged
ranxianglei merged 1 commit into
masterfrom
2026-10-11_fix-2658-refloor-pin
Oct 11, 2026
Merged

ranxianglei merged 1 commit into
masterfrom
2026-10-11_fix-2658-refloor-pin

Conversation

@ranxianglei

Copy link
Copy Markdown
Owner

What

Master's test matrix is red on all four legs since #2742 merged (93c53e8, fix #2592 F5). #2742's own head already showed the same four failures. Two stale assertions in tests/issue2658-dsh-anthropic-google-compaction.test.ts predate the ref-floor pin:

  • assertRebased: byRaw.length === 3 → 4 (checkpoint + 2 retained + ref-floor)
  • post-rebase append check: === 4 → **5` (4 with ref-floor + 1 new), in both the anthropic and google scenarios

Why this is the right fix (not a product bug)

93c53e8 pins the pre-rebase ref high-water mark via reserveRefsThrough, which adds the REF_FLOOR_RAW_ID sentinel (bili:ref-floor) to byRaw — same discipline as applyCompactionArchive (#395) and fork adoption. The three newer sibling rigs already adopted the N + ref-floor convention after the same pin:

  • tests/issue2451-dsh-responses-compaction.test.ts:212 (=== 4 ... + ref-floor)
  • tests/issue2432-dsh-local-compaction.test.ts:240 (=== 4 ... + ref-floor)
  • tests/codex-local-compaction.test.ts:195 (=== 4 ... + ref-floor)

Only the oldest rig (#2658) kept pre-pin counts. The floor pin itself is correct and load-bearing (refs are never reused within a session; without the pin a rebase could re-allocate a ref the model still remembers onto different raw content).

Verification

  • tests/issue2658-dsh-anthropic-google-compaction.test.ts 6/6 green on this branch (2 red on master)
  • sibling rigs re-run green: issue2451 + issue2432 + codex-local-compaction → 26/26 total
  • typecheck clean
  • diff = 2 assertion lines (counts + messages), nothing else

Unblock

Every open PR inherits the red matrix (#2743, #2744, ...). Merging this first turns master green; PRs rebase onto it.

Refs #2592, #2742, #2658.

#2742 (93c53e8) pins the ref floor after a native-compaction rebase
(reserveRefsThrough adds the REF_FLOOR_RAW_ID sentinel to byRaw). The three
newer sibling rigs adopted the 'N+ref-floor' convention; this older rig kept
the pre-pin counts, so master's test matrix is red on all four legs (the same
four failures were already visible on #2742's own head). Fix the two stale
counts (3->4 at the rebase, 4->5 after the follow-up turn).

Refs #2592, #2742
@github-actions

Copy link
Copy Markdown
Contributor

📦 Built Package Artifact

Branch: 2026-10-11_fix-2658-refloor-pin (8975419)

Option A — Install this exact build (recommended)

npm install -g billion-context@0.0.2997-pr.2747.ae7f3ce

This exact version is immutable and reproducible. The rolling pr tag tracks the newest test build across all PRs.

Option B — Download artifact

  1. Download the artifact from the Actions run
  2. Extract the tarball and install:
tar xzf billion-context-pr2747.tgz
npm install -g package

Install instructions are refreshed on each push.

@ranxianglei
ranxianglei merged commit 92bc2ab into master Oct 11, 2026
15 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

📦 Merged Build Published

This merge to master was published as 0.0.266-master.92bc2ab (rolling master tag).

npm install -g billion-context@0.0.266-master.92bc2ab  # this exact build
npm install -g billion-context@master  # always the newest merged build

npm view billion-context@master prints the current version at any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant