Repository navigation
Rework image-request-budget suite against the #2688 stripImages removal (#2700) - #2712
Closed
ranxianglei wants to merge 1 commit into
Closed
ranxianglei wants to merge 1 commit into
ranxianglei wants to merge 1 commit into
Conversation
… removal (#2700) #2688 (a9fdc53) removed compress.stripImages / stripImagesKeepRecent; #2613 (ae7d9c0) merged tests/image-request-budget.test.ts written against the old strip surface, leaving 2 typecheck errors + 2 red tests on master >= ae7d9c0. Rework against the #2607 fold-by-default surface: drop the stripImages refs; an over-budget history carrying a huge historical image (message or tool-screenshot form) is now refused at the forward stage (413 request_too_large, no upstream contact) instead of being strip-reduced; the admission-slots retry is admitted past the decode gate then refused at the forward budget. Refs #2700
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebuilds
tests/image-request-budget.test.tsagainst the post-#2688 surface. This file was merged by #2613 (ae7d9c0b) written against the OLDcompress.stripImagessurface, and #2688 (a9fdc537) then removedstripImages/stripImagesKeepRecent— a merge-order collision that leaves master ≥ae7d9c0bwith 2 typecheck errors (file lines 49 & 111) and 2 red runtime tests, breaking clean CI for every PR branched from master.What changed (test-only — no runtime source touched)
stripImages/stripImagesKeepRecentfrom the fixturecompressobject.compress.stripImages默认开启——否则带图消息不可压缩会形成只升不降的输入地板撑爆上下文 #2607/Archive-then-fold: default folding for archivable media (Closes #2607, Fixes #2609) #2640) and recovers viadecompress({ imageRef }). In this budget lane a fresh over-budget request carrying a huge historical image (message form and tool-screenshot form) is therefore refused at the forward stage —413 request_too_large,stage=forward, 0 upstream calls — instead of being strip-reduced to fit. Pins that media is neither silently dropped nor forwarded upstream.413/forward) instead of the old strip-to-fit200; small traffic still bypasses the large slots.reduce historical images or content before retrying).Verification (on rebased head
origin/master=6064a0e7)npm run typecheck: clean (was 2 errors).node --import tsx --test tests/image-request-budget.test.ts: 6/6 pass (was 2 red).Test-only change — no source/config/wire/kernel changes, no behavior drift.
Closes #2700