Skip to content

Rework image-request-budget suite against the #2688 stripImages removal (#2700) - #2712

Closed
ranxianglei wants to merge 1 commit into
masterfrom
2026-10-11_fix-image-budget-2700
Closed

ranxianglei wants to merge 1 commit into
masterfrom
2026-10-11_fix-image-budget-2700

Conversation

@ranxianglei

Copy link
Copy Markdown
Owner

Rebuilds tests/image-request-budget.test.ts against the post-#2688 surface. This file was merged by #2613 (ae7d9c0b) written against the OLD compress.stripImages surface, and #2688 (a9fdc537) then removed stripImages/stripImagesKeepRecent — a merge-order collision that leaves master ≥ ae7d9c0b with 2 typecheck errors (file lines 49 & 111) and 2 red runtime tests, breaking clean CI for every PR branched from master.

What changed (test-only — no runtime source touched)

Verification (on rebased head origin/master = 6064a0e7)

  • npm run typecheck: clean (was 2 errors).
  • node --import tsx --test tests/image-request-budget.test.ts: 6/6 pass (was 2 red).

Test-only change — no source/config/wire/kernel changes, no behavior drift.

Closes #2700

… removal (#2700)

#2688 (a9fdc53) removed compress.stripImages / stripImagesKeepRecent; #2613 (ae7d9c0) merged tests/image-request-budget.test.ts written against the old strip surface, leaving 2 typecheck errors + 2 red tests on master >= ae7d9c0.

Rework against the #2607 fold-by-default surface: drop the stripImages refs; an over-budget history carrying a huge historical image (message or tool-screenshot form) is now refused at the forward stage (413 request_too_large, no upstream contact) instead of being strip-reduced; the admission-slots retry is admitted past the decode gate then refused at the forward budget.

Refs #2700
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] tests/image-request-budget.test.ts broken on master: references compress.stripImages removed by #2688 — 2 typecheck errors + 2 runtime failures

1 participant