Repository navigation
docs(#2602): pin deferred MINOR intents from the v0.1.190 release review (#2581) - #2603
Conversation
📦 Built Package ArtifactBranch: Option A — Install this exact build (recommended)npm install -g billion-context@0.0.2811-pr.2603.20d2f8fThis exact version is immutable and reproducible. The rolling Option B — Download artifact
tar xzf billion-context-pr2603.tgz
npm install -g packageInstall instructions are refreshed on each push. |
[bot] 🏷 PR #2603 review — docs(#2602): pin deferred MINOR intents from the v0.1.190 release review (#2581) Reviewed the full branch ( 核心判定:纯注释改动、零行为变更,且每条文档声明都对照源码逐条核实无误。 逐项核验(不是只看 diff,是把每条声明对照源码验证): Finding 1(#2490 ledger floor)— 全部属实
Finding 2(addStaticHosts 空 host guard)— 数字精确
Finding 3(transport trio)— 关键不变量正确钉住
测试有效性: CI:22 pass / 4 in-progress(主 结构化八问
收工判定:可合。改动干净(4 文件 +32/-4 全注释、线性 3 个 |
📦 Merged Build PublishedThis merge to master was published as npm install -g billion-context@0.0.223-master.1dfed37 # this exact build
npm install -g billion-context@master # always the newest merged build
|
Closes #2602
Documentation-only PR: pins the three deferred MINOR findings from the #2581 (v0.1.190) release review at their code sites. No behavior change — every diff line is a comment/docstring; no thresholds, defaults, timing, wire shapes, or output formats move.
Path correction (finding 1): the issue cites
src/prompt-cache/budget.ts:243— that path does not exist in this repo's history (git log --all -- 'src/prompt-cache/*'is empty). The actual site issrc/server/budget.ts(the #2490 dsh-compaction-refused ledger floor; nothing to do with prompt caching). The review comment's own citation (src/server/budget.ts:243–244) matches.Finding 1 — ledger floor never decays + cap<1024 surrender (
src/server/budget.ts,src/server/handle.ts)Verified both behaviors are deliberate, and documented WHY at all three sites:
dshLedgerFloorTokens()(budget.ts) and at the write site (handle.ts).cap < OUTPUT_CLAMP_FLOORmeans the host's own counter already sits at the window wall; bili folds cannot shrink it, so no output budget recovers the session — a sub-floor clamp would only starve a terminal turn. Documented inclampOutputBudget()(budget.ts); already test-pinned intests/issue2490-ledger-floor-doomed-probe.test.ts.allowDshCompactionon mid-session lets checkpoints land and shrink the ledger, but the floor stays at its old high until session eviction (fail-closed over-tightening, accepted — noted in the docstring).Finding 2 —
addStaticHostsempty-host guard (src/launcher.ts)Kept the guard and documented the invariant rather than dropping it or adding a warn log: all eight callers resolve hosts before calling (constant tables or
nonEmpty()-gated config values), so the branch is structurally unreachable today. Dropping the guard would make a future unresolved list PUSH""into the SNI whitelist (worse than skipping), and a warn log doesn't fit this pure discovery helper (no log channel; branch unreachable by construction). The docstring now states both facts so the next reader makes the same call with evidence.Finding 3 — transport trio (
src/loop/core.ts; others informational)roundBodymust stay byte-identical: the retry re-issues the SAME logical request, and rebuilding the body would shift prompt-cache leading-edge markers and break prefix cache reuse.leading-*markers (cosmetic inefficiency) and the opencode-v2 stale-manifest observation: informational per the issue, no action taken.Verification
npm run typecheckclean.tests/issue2490-ledger-floor-doomed-probe.test.ts+tests/discover.test.ts→ 36/36 pass (the former pins exactly the two behaviors now documented; the latter is the route-discovery differential harness covering the launcher file touched).