Skip to content

[PR] test: pi-subagent-registry fake pi keeps per-event handler arrays like real pi (#2234) - #2237

Closed
ranxianglei wants to merge 1 commit into
masterfrom
2026-10-06_pi-fake-handler-array
Closed

ranxianglei wants to merge 1 commit into
masterfrom
2026-10-06_pi-fake-handler-array

Conversation

@ranxianglei

Copy link
Copy Markdown
Owner

Closes #2234

What

Test-only fix for the master-red on tests/pi-subagent-registry.test.ts (factory wiring test) caused by the #2186 + #2209 semantic merge: each PR was green alone; combined, #2186's wirePiSubagents(pi, agent) (src/agent/pi.ts:939 → src/agent/pi-subagents.ts:90) registers a SECOND session_start handler after pi.ts's own (src/agent/pi.ts:891). The test's fake pi stored ONE handler per event (events.set(event, handler)), so the later subagents wiring shadowed the factory's selfRegister handler and registry().bySession never filled → assertion at tests/pi-subagent-registry.test.ts:275.

Real pi stores an ARRAY of handlers per event and awaits each in registration order (pi-coding-agent runner.js emit(): for (const handler of handlers)), so production runs both handlers — only the test fake was wrong. Same defect class as #2072 (tests/issue2072-native-caller-stamping.test.ts already uses handler arrays).

Fix

makeFakePi now stores Map<string, PiHandler[]> (on() appends), and every call site invokes all registered handlers in order (for (const handler of … ?? []) await handler(…)), mirroring the #2072 fake and real pi semantics. Zero src changes.

Verification

  • Reproduced red on master HEAD bd33b11 before the fix (exact assertion from the issue).
  • After fix: node --import tsx --test tests/pi-subagent-registry.test.ts → 10/10 pass.
  • Targeted pi-lane files (pi-subagent-registry, issue2072-native-caller-stamping, pi-native, pi-subagents-wiring, update-pi-self-refresh): 47/47 pass.
  • tsc --noEmit --project tsconfig.json clean.
  • Full suite left to CI.

@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

📦 Built Package Artifact

Branch: 2026-10-06_pi-fake-handler-array (720f66d)

Option A — Install this exact build (recommended)

npm install -g billion-context@0.0.2306-pr.2237.ea47506

This exact version is immutable and reproducible. The rolling pr tag tracks the newest test build across all PRs.

Option B — Download artifact

  1. Download the artifact from the Actions run
  2. Extract the tarball and install:
tar xzf billion-context-pr2237.tgz
npm install -g package

Install instructions are refreshed on each push.

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

收到,开始 review:拉取分支核对代码、复现/定向验证、确认 CI 状态,完成后按七问体例给结论。

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

[bot] 🏷 Review 完成,结论:可合并(CI 全绿、base 即最新 master、无需 rebase)。

审查过程(不止跑测试):

  • 原 issue 方向:master red: pi-subagent-registry factory test broken by #2209 + #2186 semantic merge (fake pi Map shadows selfRegister handler) #2234 根因分析正确——生产路径确实注册了两个 session_start handler(src/agent/pi.ts:891 含 selfRegisterForSession;src/agent/pi-subagents.ts:90 经 pi.ts:939 wirePiSubagents 注册在后),真实 pi 每事件是 handler 数组按注册序逐个 await,坏的只是测试 fake 的 Map-of-one。修法方向=fake 向真实宿主语义对齐、零 src 改动——成立,是「疏」不是「堵」:生产行为本来就对,不需要动。
  • 逐项验证(本地复现+定向,非全量):
    • master HEAD bd33b11 复现红:test 9「factory wiring」AssertionError,与 issue 原样一致;
    • PR 分支:目标文件 10/10;定向五件套(pi-subagent-registry / issue2072-native-caller-stamping / pi-native / pi-subagents-wiring / update-pi-self-refresh)47/47;tsc --noEmit --project tsconfig.json 干净;
    • CI(head 720f66d):全部 job success——含 ubuntu/windows test matrix、real pi package-native e2e lane(真实 pi 宿主跑通,即真实双 handler 路径的活证据)、kernel-guard / lane-guard / version-guard / docs-sync / docs-coverage;mergeable=True。
    • 交叉核对:文件内全部 events 使用点(类型声明、makeFakePi、两个测试体)无遗漏;模式与 Host-native agent tool forwarding lacks nativeCaller stamping: stale outbound witness misroutes ACP tool calls across subagent sessions #2072 已修 fake 逐字同型(tests/issue2072-native-caller-stamping.test.ts:148-152 注释 + :199/:210 调用点)。

回归审查(diff 触碰的既有行为清单,逐项):
diff 仅 tests/pi-subagent-registry.test.ts(21+/11−),src、wire、配置、持久化全未动:

  1. 同文件其余 8 个测试不经过 events fake → 保持;
  2. 测试 9(factory wiring):此前 fake 只执行最后注册的 subagents handler(主 handler 被影子化),现两个 handler 按注册序都执行 → 断言真正咬住它声称的行为(registry 条目出现/消失)。有意强化,PR 描述已披露;
  3. 测试 10(kill switch):此前实际跑的是影子化的 subagents handler(碰巧不碰 registry 所以"通过"),现在主 handler 也真实执行(BILLION_CONTEXT_PLUGIN=0 → selfRegister skip → 断言仍成立)。有意强化,PR 描述已披露;
  4. 执行顺序=注册序(pi.ts:891 先、subagents 后),与真实 pi emit() 一致;主 handler 内 void registerTools(...) 为 fire-and-forget 且自带 .catch,无 unhandled-rejection 风险(10/10 干净通过实证)。
    高危模式(fail-fast→吞错、阈值/时序/输出格式漂移):逐项过,均未命中。

测试有效性:修后的测试是真回归测试——未来若有人把 fake 改回单 handler 或删掉 selfRegister handler,:275 断言立即抓住;非恒真断言,非只测 mock。

diff 整洁度:单 commit、单文件,每一行都与 PR 目的相关,test: 前缀、分支命名合规、Closes #2234。review 中未发现需顺手修的小问题。

结构化七问:

  1. 是什么问题:master 四个 test job 全红,唯一失败是 tests/pi-subagent-registry.test.ts 的 factory wiring 测试——fake 触发 session_start 后 registry().bySession 无条目(:275 断言)。
  2. 什么原因导致的:非生产缺陷,是测试 fake 缺陷。[pi] 内置 billion-context-pi-subagents(acp_delegate)进 Pi lane:官方自有 subagents 支持 #2186 在 pi.ts 自身 handler(含 selfRegisterForSession)之后注册了第二个 session_start handler;fake 用 events.set(event, handler) 每事件只存一个,后注册覆盖先注册 → selfRegister handler 被影子化。真实 pi 每事件 handler 数组逐个 await,生产两个都执行。两 PR 各自 CI 全绿、无人见过组合(fix: reject stale in-memory snapshots that would roll back persisted session state (#405) #517 式语义合并冲突)。
  3. 怎么修复的:test-only。makeFakePi.events 改 Map<string, PiHandler[]>(on() 追加),所有调用点按注册序 for … await——与真实 pi 语义对齐,沿用 Host-native agent tool forwarding lacks nativeCaller stamping: stale outbound witness misroutes ACP tool calls across subagent sessions #2072 同款模式。零 src 改动。
  4. 是否回归问题:无。仅一个测试文件;其余 8 测试行为保持,两处工厂测试的执行强化是有意的且已披露(见上清单);高危模式未命中。
  5. 是否破坏缓存:不涉及。
  6. 是否改了设计方向:不涉及——生产行为(双 handler 均执行)本来就对,fake 向真实宿主对齐。
  7. 是否引入新配置:不涉及。

判定:可合并。合入后连带红的 open PR(如 #2233)rebase 到 master 即恢复。

@ranxianglei

Copy link
Copy Markdown
Owner Author

(ai: zhipuai-lb/glm-5.3)

陈旧票清理(第三批动作①):目标 issue #2234 已关。为避免重复劳动关闭本 PR;如判断有误请直接 reopen 并留言。

@ranxianglei ranxianglei changed the title test: pi-subagent-registry fake pi keeps per-event handler arrays like real pi (#2234) [PR] test: pi-subagent-registry fake pi keeps per-event handler arrays like real pi (#2234) Oct 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

master red: pi-subagent-registry factory test broken by #2209 + #2186 semantic merge (fake pi Map shadows selfRegister handler)

1 participant