Repository navigation
feat(dsh): mount the bili panel at plugins.bundle.config on the plugin detail page - #2127
Conversation
📦 Built Package ArtifactBranch: Option A — Install this exact build (recommended)npm install -g billion-context@0.0.2252-pr.2127.8fa9d59This exact version is immutable and reproducible. The rolling Option B — Download artifact
tar xzf billion-context-pr2127.tgz
npm install -g packageInstall instructions are refreshed on each push. |
Review 结论:PR #2127(feat(dsh): mount the bili panel at plugins.bundle.config)① 是什么问题:dsh 插件详情页为每个 bundle 预留了配置槽 ② 什么原因导致:不是缺陷,是注册缺失——client 侧只注册了 ③ 怎么修复的:把单一 section 组件改成 ④ 是否有回归问题:无。逐项清点既有行为:
⑤ 是否破坏缓存:不涉及(未触碰任何缓存/重试/增量游标/去重逻辑)。 ⑥ 是否改了设计方向:否。数据流不变( ⑦ 是否引入新配置:manifest 新增 验证证据(超出 CI 的部分):
判定:可合。 单一 commit、diff 收敛于 3 文件且每行都与本 issue 相关;未顺手发现需修的小问题。等最后一个 CI 作业(windows-latest 22)跑完即可合并。 |
补充:最后一个 CI 作业(windows-latest 22)已跑完,全部 check-runs 绿。结论不变——可合,可以合并了。 |
7948d10 to
226219c
Compare
…n detail page Register the existing origin-probe panel under the plugins.bundle.config slot so it renders between the description and the component rows on the plugin detail page (view:'page'), per #2125. Reuses the origin polling/bound-state logic already present for settings.section; the legacy entry is kept as the fallback for launcher postures where no bundle page exists. No manifest change: deliberately do NOT add dsh.client.inject for @deepseek-ai/dsh-client-ui-plugin-manager. The host ships built into dsh-web-app on 0.2.x, so the injection is redundant there; on the older 0.1.x dsh the unknown inject target stalls the client-module scanner and turns the whole web app into an endless spinner. A test locks this in: the manifest must not declare dsh.client.inject. Closes #2125
226219c to
2c907b7
Compare
📦 Merged Build PublishedThis merge to master was published as npm install -g billion-context@0.0.52-master.e5a0066 # this exact build
npm install -g billion-context@master # always the newest merged build
|
Closes #2125
What
The dsh plugin page gives every bundle its own config area —
plugins.bundle.config(keyed by package name, rendered between the description and the rows whenledger.bundles.has(pkg.name)). billion-context never occupied it, so the plugin page showed no bind status / Web UI entry while the settings bar carried a product-level entry.This registers the existing origin-probe panel at that slot:
src/agent/dsh-native-client.ts: the singlesectioncomponent becomes apanel(titled)factory.settings.sectionkeeps rendering byte-identically (titled = true, same flat DOM: h3 + button/degraded + hint). The newplugins.bundle.configregistration uses{ name, key: "billion-context", locale }(keyed shape verified against@deepseek-ai/dsh-client-ui-plugin-manager@0.2.0-rc.2slot-contract and the official voice-input reference registration) and renderstitled = false— the plugin page draws its own title.package.json: addsdsh.client.inject: ["@deepseek-ai/dsh-client-ui-plugin-manager"]so the client scanner co-loads the slot host. Same declaration the reference implementation carries; previously undeclared even forsettings.sectionownership.tests/dsh-settings-ui.test.ts: harness now captures both registrations. All prior assertions preserved (settings options incl. id/order/label, both render branches, polling upgrade/degrade/cancel); new assertions pin the keyed options shape (exactlykey/locale/name— no list-slot fields), the missing h3, and the shared probe wiring through the bundle registration.Deliberately not changed
src/agent/dsh-native.ts(host half) — untouched per issue scope; data already flows via__BILI__/GET /bili/origin.settings.sectionstays registered: under thebili dshlauncher posture (patch injection, package not installed as a profile bundle) there is no bundle page for this package, so the settings entry remains the only UI there. In bundle posture both entries exist; the plugin page is now the canonical one.writeDshClientShimFiles) does NOT gaininject: it is only consulted in launcher posture, where the panel can never render (no ledger bundle entry), and in mixed postures the profile-installed real package resolves first, carrying the new field./__bili/) / b (own main+sidebar page) are future work, out of scope here.Behavior notes
dsh.client.inject(dsh host-reads-it declaration, not bili user config): default is the fixed array above; no migration needed.Verification
configuredgate, reference registration shape).npm run typecheckclean; targetedtests/dsh-settings-ui.test.ts7/7 green locally. Full suite/build/e2e via CI.Update (rebased + old-client compat): rebased onto latest master (
4e3ba1e). Dropped the planneddsh.client.injectfor@deepseek-ai/dsh-client-ui-plugin-manager: on dsh ≥ 0.2.0-rc.x the slot host ships inside dsh-web-app, so the injection is redundant (verified: panel renders without it, clean console), while on older 0.1.x dsh the unknown inject target stalls the client-module scanner and freezes the whole web UI into an endless spinner. Without it, this bundle degrades gracefully on old clients — the legacy settings.section entry stays intact, the new detail-page panel simply doesn't appear.Update (dropped my duplicate web-index fix): while this PR was in flight the same #2152 root cause landed upstream as #2180/#2182 (
ef404a85serve empty web index on pristine install,0d30cec0keep the #1937 stale snapshot when the data root vanishes later,695f5c72hermetic advisory-parity test). Their distinction is stricter than my blanket ENOENT-tolerant walk (pristine only when no override AND absent XDG data root; misconfigured explicit dirs stay loud), so my second commit was dropped and this PR is rebased onto current master. Remaining scope is exactly two files:src/agent/dsh-native-client.ts+tests/dsh-settings-ui.test.ts. Local verification on the rebased tree:web-sessions16/16,advisory-endpoint-parity1/1,dsh-settings-ui8/8, typecheck clean.