Repository navigation
release v0.1.184 (critical: #2082 desktop tool loss) - #2097
Conversation
📦 Built Package ArtifactBranch: Option A — Install this exact build (recommended)npm install -g billion-context@0.0.2147-pr.2097.cc4bc7aThis exact version is immutable and reproducible. The rolling Option B — Download artifact
tar xzf billion-context-pr2097.tgz
npm install -g packageInstall instructions are refreshed on each push. |
bd54781 to
1f07db1
Compare
…ation must not be re-poisoned by a stale ctx capture The #2082 fix reset register.dead on re-activation and armed a detached recovery timer, but two async paths still resolved their PluginContext from a capture taken when the retry was armed or started: the timer tick (armRecoveryTimer captured the first ctx that saw the broken state) and an in-flight registration landing after a mid-fetch re-activation (registerTools captured ctx at call time). If dsh deactivated that context in between (profile switch / settings toggle / desktop copy swap), the stale path registered into it, cordis threw 'inactive context', and register.dead was re-poisoned until dsh restarted — exactly the failure this fix removes, in a narrow interleaving. Track the latest context in module state (apply() + maybeRetry update it; _resetRegisterForTest clears it). The timer tick and the single-flight registration landing now resolve activeCtx ?? ctx at landing time. Regression tests pin both facets: they fail on the pre-fix code and pass with the fix.
1f07db1 to
997c1fd
Compare
…INTERVAL_MS in CONFIGURATION.md en+zh The #2091 recovery knobs shipped without CONFIGURATION.md entries while every sibling dsh-plugin knob (incl. the adjacent BILI_MODEL_INFO_RETRY_MS) is documented — 'document or don't ship' (env-var discipline #2030, hard rule 4). Both are test/ops hooks with unchanged defaults; production behavior is untouched.
997c1fd to
0bec76c
Compare
Review 结论 — release v0.1.184(#2097)审查方式:按版本区间回归审计规则,把 v0.1.183..HEAD 的全部变更作为一个整体综合审阅(不逐分支拼结论),覆盖五个功能域:#2049 master 滚动 tag、#2053 website、#2073/#2080 docs、#2072 nativeCaller stamp、#2082 desktop tool loss(critical 主体)。release commit 本身干净:仅 version + lockfile + release-notes entry(tier critical,summary 合格)。 审查中发现两个问题,均已在分支上顺手修掉(独立标注 commit):
CI:最终 head 结构化七问
判定:✅ 可合。critical-tier 内容端到端验证完毕(回归测试 red→green 实证、CI 21/21 绿、release commit 隔离干净)。合并后 CI 自动 publish latest + tag + GitHub Release + release-notes companion;OP 里的 post-publish 建议(canary dispatch ref=master)照做即可。 |
A re-activation after a HEALTHY registration used to leave the bili tools dead until dsh restarted — the same #2082 symptom reached from the success ordering. apply() reset register.dead and activeCtx, but not register.toolsReady: the tools registered into the deactivated context die with it, while every registerTools()/maybeRetry() early-returns on the stale stamp, so the new context never re-registers (and headersFor keeps stamping plugin mode for a lane whose dsh side has no tools). Clear toolsReady (and retryAt, per #1783's fresh-activation rule) when apply() sees a context change. Scoped to a context CHANGE: a same-context re-apply keeps its registration (the attach verify path already re-checks on its own). tests/issue2101-dsh-reactivation.test.ts: the success-ordering re-activation test times out on the unfixed tree (verified) and passes with the clear; a same-context re-apply stays healthy.
|
重新review一次 |
重新review完成。自上一轮以来 PR 只有一个新提交:fbc7f03(你把 #2101 的修复折叠进本 PR);其余提交未变,第一轮的版本区间审计(v0.1.183..HEAD)结论继续有效。以下是对 fbc7f03 的独立复核(不是照抄 #2101 线程的结论): 代码核对
结构化七问
行为变更披露:旧行为——健康启动后的一次重激活会永久性丢工具直到重启;新行为——重激活清锁存、触发一次 manifest 拉取+重注册(数十毫秒量级),期间 gate 压住首请求。这是修复目标本身,非附带漂移。 CI:head fbc7f03 —— 20 绿 + 1 skipped(version-guard,release 分支正常跳过)+ 0 失败;PR mergeable。 判定:✅ 可合。合入后 CI 发布 0.1.184(含 #2101 修复)+ companion package;建议发布后照常 dispatch |
版本发布 PR:v0.1.184,带 critical 级 release note(下游会在 acp_status /
/acp面板看到 CRITICAL UPDATE READY/AVAILABLE)。本版内容(自 v0.1.183)
register.dead复位、respawn fallback、自清恢复定时器,旋钮 BILI_DSH_RECOVERY_INTERVAL_MS / BILI_DSH_RETRY_INTERVAL_MS);node <main> --version,失败回滚旧版);Release note 条目(release-notes/package.json, schema 1)
合并即发布
*_release-v*匹配):typecheck+test+build → npm publish latest + tag v0.1.184 + GitHub Release(auto notes)。release-notes/**→ release-notes.yml 发布 companion 包(update-notes.ts 可见面)。ci-release-canary(ref=master) 走自更新收敛链路。定级说明
#2082 属"serious defect users must act on"(可用性类:桌面端压缩/工具永久失效直至重启,用户需升级+重启 dsh),低于 advisory 强升门槛(advisories/ 保留给 force-upgrade 级缺陷),故走 critical tier 而非 advisory——符合 #1870/#1977 政策。#1632(install-dir)已随 0.1.183 发布。
按惯例 release PR 由 owner 合并。
Update (2026-10-04): folded in
fix(#2101)— a re-activation after a healthy registration also re-registers the tools now (the same #2082 symptom from the success ordering). Fixes #2101. Regression test verified to time out on the unfixed tree; all #2082 recovery tests still green, typecheck + build clean.