Repository navigation
docs(configuration): Server Settings parity with src/config.ts surface (#2062) - #2064
Conversation
…#2062) releaseNotesCheck/releaseNotesUrl/imageTokenCap/plugin were read by loadOptions/knobs but absent from the known-key set, so users setting them got a spurious 'ignoring unknown top-level config key(s)' warning although the keys work. Add them to the set and extend the issue1815 full-surface test to pin every FileConfig field (A/B-verified: the extended test fails on the pre-fix set).
…onseLingerMs (#2062) #1982's post-response close linger budget landed after the #2037 knob migration and stayed env-only (server.ts read process.env directly), violating the #2030 discipline that pure-behavior knobs get a config-file key. The issue names the target shape network.postResponseLingerMs (owner sign-off). Now resolved env > file > default through knobs.ts with the historical parseInt parsing preserved byte-exact (set-but-empty/ garbage env falls back to the default without consulting the file). Default stays 5000; env semantics unchanged — additive file tier only.
…level keys + linger knob file tier (#2062)
📦 Built Package ArtifactBranch: Option A — Install this exact build (recommended)npm install -g billion-context@0.0.2142-pr.2064.2bc71b2This exact version is immutable and reproducible. The rolling Option B — Download artifact
tar xzf billion-context-pr2064.tgz
npm install -g packageInstall instructions are refreshed on each push. |
[bot] 🏷 已独立 review PR #2064(拉分支核对代码 + 本地定向验证 + A/B 回归钉住 + CI 状态),非复述作者自报,以下结论均附证据。 ① 方向关(原 issue #2062):方向正确、打到根因。手册 §Server Settings 落后于 src/config.ts 配置面是真实缺陷(我独立 diff FileConfig 顶层字段 vs KNOWN_TOP_LEVEL_KEYS 确认漂移属实);同一失败域里三个独立漂移源(增量落地未回填 / linger 漏迁 knobs / 白名单落后)分层清晰,合并为一个 checklist 处理合理,未把症状当病因。 ② 回归审查(逐项既有行为):
③ 代码审查:两个 code commit 小而收敛。KNOWN_TOP_LEVEL_KEYS 补 4 键——我独立 AST 抽取确认修复后 FileConfig 48 字段 == KNOWN 48 项,零缺失零多余(非仅靠测试字段列表)。postResponseLingerMs 迁入 ④ 测试有效性(真测试,有牙):本地实跑 knobs 9/9、issue1815 4/4、graceful-close 1/1;typecheck exit 0。A/B 钉住:临时撤掉 fix commit 的 4 键,issue1815 full-surface 用例即挂于 ⑤ diff 整洁度:7 文件 +389/-33,base = 当前 master(3a7308ab,fresh 无 stale-base)。每行都与本 PR 目的相关;顺手小修(死链锚点 结构化七问
CI 与判定CI 5/6 绿(PR Build Artifact / E2E real codex / e2e-fake-codex / ci-image / e2e-native-pi 均 success),主 判定:主 CI 套件转绿后即可合。 两个 code commit 小、收敛、有牙测试钉住且 A/B 证明必要且充分;docs commit 纯增量、默认值准确。注:本 PR 触及配置面(新增 config 字段)且含 |
|
冲突 |
[bot] 🏷 冲突已解决并推送到分支( 七问
判定:冲突已消除,PR diff 对 master 仍保持原 7 文件范围(GitHub 按 merge-base 计算,diff 整洁度不受 merge commit 影响)。新 head |
[bot] 🏷 CI 全绿,PR 已就绪可合并。 新 head PR 状态: 收工判定:冲突解决后的分支与原 PR 内容逐字节等价(union 解法零语义取舍,双向 diff 已验证),加上此前 review 的全部结论(tInt 严格语义保留、KNOWN_TOP_LEVEL_KEYS 48/48 完整面、A/B 测试咬合)在新基线上依然成立——可以合并。按 §7.4 需人工合并(触碰 config surface + 含 feat 提交,自动合并不适用):#2064 |
📦 Merged Build PublishedThis merge to master was published as npm install -g billion-context@0.0.9-master.dda1689 # this exact build
npm install -g billion-context@master # always the newest merged build
|
Closes #2062
改动
CONFIGURATION.md(en + zh-CN)§Server Settings 补齐相对 src/config.ts 配置面的全部缺失条目:23 个新键条目 +
network小节扩展。issue 清单内(18 项,全部覆盖)
upstream、logFile、maskHosts、subagentSplit、forkAdoption、resumeInheritance、chainContentDetection、chainEgressStamp、stableSystemAnchor、autoUpdate、autoRestartOnUpdate、updateTag、advisoryCheck、advisoryUrl、releaseNotesCheck、releaseNotesUrl、upstreamProxy、network.postResponseLingerMs同机制补差(6 项,实现时系统性 diff FileConfig vs 文档标题发现)
upstreamProxyMode(upstreamProxy 的配套模式键)、providersPath、顶层modelContextLimit、promptCache、claude、native另有:#2030 env 映射表补
BILI_POST_RESPONSE_LINGER_MS行;主 env 表补ACP_AUTO_RESTART_ON_UPDATE行(此前 README 有文档但两版手册 env 表均无)。顺手小修(独立标注):CONFIGURATION.md 既有
BILI_NATIVE_ATTACH_EXTERNALenv 行的 TECHNICAL-NOTES 锚点缺-1660(死链),修正为实际标题 slug。config surface(AGENTS.md 强制节)
新增字段:
network.postResponseLingerMs(number,默认5000,env twinBILI_POST_RESPONSE_LINGER_MS)。network.postResponseLingerMs(owner 签核,Configuration Surface Discipline 第 3 条)。network进程级块(同为传输时序语义,与keepAliveTimeoutMs/clientErrorBackstopMs同族),不新建块或新形状。parseInt+isFinite && > 0;set-but-empty/garbage env 回落默认而非文件值 —— 定向测试钉住该 tInt 严格语义);默认值不变;无迁移步骤。行为变更披露(旧 → 新)
BILI_POST_RESPONSE_LINGER_MSenv;现按 env > file(network.postResponseLingerMs) >5000解析。默认值与 env 语义完全不变,纯增量。releaseNotesCheck/releaseNotesUrl/imageTokenCap/plugin四个本来就生效的键此前误报[acp-config] ignoring unknown top-level config key(s)(KNOWN_TOP_LEVEL_KEYS 白名单落后于 FileConfig 接口)。修复后不再告警、照常生效。仅告警输出变化,功能行为不变。测试
本地定向(全量回归交 CI):typecheck 干净;
tests/knobs-config-precedence.test.ts13/13(含新键 default / file-tier / env-wins / junk-parse 4 例);tests/issue1815-unknown-top-level-keys.test.ts4/4(已扩展为钉住 FileConfig 全字段面,A/B 验证:撤掉 fix commit 即挂于ignoring unknown top-level config key(s): releaseNotesCheck, releaseNotesUrl, imageTokenCap, plugin);tests/graceful-close.test.ts1/1(其子进程 env pin 在迁移后仍优先生效)。