Skip to content

test: derive #1870 surface-test fixtures from the running version (fixes red master) - #1922

Merged
ranxianglei merged 1 commit into
masterfrom
2026-10-02_update-notes-test-rot
Oct 2, 2026
Merged

ranxianglei merged 1 commit into
masterfrom
2026-10-02_update-notes-test-rot

Conversation

@ranxianglei

Copy link
Copy Markdown
Owner

master is red on f7cc681 (#1870 merge): tests/update-notes.test.ts has two surface tests whose fixtures hardcode 0.1.179/0.1.180/0.1.181 while the code under test derives the running version from package.json at runtime. v0.1.180 shipped (10:58Z) between the PR's green run and its merge (12:15Z), so spanNotes (strictly-greater-than running) dropped the 0.1.180 span line and both tests fail — on master's own CI and on every PR rebased onto it (#1857 currently).

Fix: the two surface tests now derive their fixtures from VERSION via semver.inc (NEXT/NEXT2), so they survive every future release. The explicit-version unit tests stay hardcoded — they pin spanNotes/getUpdateVisibility logic against fixed inputs, independent of this repo's current version.

Verified:

  • suite green on this branch (6/6) with current package.json (0.1.180);
  • rot simulation: bumped package.json to a future version locally → suite stays 6/6 green;
  • typecheck clean.

Test-only change, no runtime code touched.

 follow-up)

The two surface tests (acp_status section + /acp panel line) exercise the
real running version — package.json read at runtime — but their fixtures
hardcoded 0.1.179/0.1.180/0.1.181. v0.1.180 shipped between the green PR
run and the #1870 merge, so spanNotes (> running) dropped the 0.1.180
line and master's CI went red on f7cc681 (and every PR rebased onto it,
e.g. #1857).

Fix: derive SURFACE_ENTRIES from VERSION via semver.inc (NEXT/NEXT2),
keeping the explicit-version unit tests hardcoded (they pin spanNotes
logic, not this repo's version). Verified rot-proof by bumping
package.json to a future version locally — suite stays green across the
simulated release.
@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

📦 Built Package Artifact

Branch: 2026-10-02_update-notes-test-rot (65834d6)

Option A — Install this exact build (recommended)

npm install -g billion-context@0.0.1916-pr.1922.10c6e3d

This exact version is immutable and reproducible. The rolling pr tag tracks the newest test build across all PRs.

Option B — Download artifact

  1. Download the artifact from the Actions run
  2. Extract the tarball and install:
tar xzf billion-context-pr1922.tgz
npm install -g package

Install instructions are refreshed on each push.

@ranxianglei
ranxianglei merged commit e753203 into master Oct 2, 2026
13 checks passed
@ranxianglei
ranxianglei deleted the 2026-10-02_update-notes-test-rot branch October 15, 2026 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant