Repository navigation
test: derive #1870 surface-test fixtures from the running version (fixes red master) - #1922
Merged
Merged
Conversation
follow-up) The two surface tests (acp_status section + /acp panel line) exercise the real running version — package.json read at runtime — but their fixtures hardcoded 0.1.179/0.1.180/0.1.181. v0.1.180 shipped between the green PR run and the #1870 merge, so spanNotes (> running) dropped the 0.1.180 line and master's CI went red on f7cc681 (and every PR rebased onto it, e.g. #1857). Fix: derive SURFACE_ENTRIES from VERSION via semver.inc (NEXT/NEXT2), keeping the explicit-version unit tests hardcoded (they pin spanNotes logic, not this repo's version). Verified rot-proof by bumping package.json to a future version locally — suite stays green across the simulated release.
Contributor
📦 Built Package ArtifactBranch: Option A — Install this exact build (recommended)npm install -g billion-context@0.0.1916-pr.1922.10c6e3dThis exact version is immutable and reproducible. The rolling Option B — Download artifact
tar xzf billion-context-pr1922.tgz
npm install -g packageInstall instructions are refreshed on each push. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
master is red on f7cc681 (#1870 merge):
tests/update-notes.test.tshas two surface tests whose fixtures hardcode 0.1.179/0.1.180/0.1.181 while the code under test derives the running version frompackage.jsonat runtime. v0.1.180 shipped (10:58Z) between the PR's green run and its merge (12:15Z), sospanNotes(strictly-greater-than running) dropped the 0.1.180 span line and both tests fail — on master's own CI and on every PR rebased onto it (#1857 currently).Fix: the two surface tests now derive their fixtures from
VERSIONviasemver.inc(NEXT/NEXT2), so they survive every future release. The explicit-version unit tests stay hardcoded — they pinspanNotes/getUpdateVisibilitylogic against fixed inputs, independent of this repo's current version.Verified:
Test-only change, no runtime code touched.