Skip to content

docs(agents): external contributors' PRs — review, don't take over; post-merge supplements go to follow-up PRs - #1825

Merged
ranxianglei merged 1 commit into
masterfrom
2026-10-01_agents-external-contributor-prs
Oct 1, 2026
Merged

ranxianglei merged 1 commit into
masterfrom
2026-10-01_agents-external-contributor-prs

Conversation

@ranxianglei

Copy link
Copy Markdown
Owner

把今天 #1765 事件的教训固化进 AGENTS.md(§4 Git Safety Rules 之下新增两小节):

1. External Contributors' PRs — Review, Don't Take Over

  • 外部贡献者的 PR,Agent 只做 review + 验证:不 push 到他们的分支、不用 Agent 名义的 PR 去替代、不建议关闭——需要动时先向 owner 说明、由 owner 决定
  • 首次贡献者的署名与 PR credit 本身就是交付物的一部分
  • 两个易误判的机制:
    • 头分支被删 ≠ PR 死了:GitHub 把 PR head 冻结在 refs/pull/N/head,重建同名分支也不会重新挂上,但冻结的 head 仍可能 MERGEABLE 且检查全绿——先查 mergeable/mergeStateStatus 再下结论
    • BEHIND 不是阻塞:PR 不需要包含最新 master,合并按钮会处理

2. Supplements After a Merge — Follow-up PR, Never the Merged PR

  • 合并后发现缺东西/有问题 → 开小 follow-up PR,正文引用原 PR 号;绝不往已合并的 PR 里塞、不 rebase 到它上面、不追加提交
  • 保持原贡献历史完整(commits、diff、author)
  • 先确认补充是否真的必要:把同一个提交在新 master 上重放属于验证,不是内容

背景:#1765(InCerryGit 首次贡献)分支被删后 PR 仍 mergeable,Agent 却开了替代 PR #1822 并建议关闭原 PR;现已回滚(替代 PR 关闭、分支还原、留言撤回),教训入档。

纯文档改动(AGENTS.md +29 行),无代码。

…ost-merge supplements go to follow-up PRs

Lesson from #1765 (2026-10-01): a first-time contributor's PR whose head
branch was deleted was still MERGEABLE, but the Agent opened a replacement
PR and suggested closing the original. Pin the rules:

- external PRs: review + verification only — never push to their branch,
  never replace with an Agent-owned PR, never suggest closing; owner decides
- deleted head branch ≠ dead PR (refs/pull/N/head freezes; check mergeable)
- BEHIND is not a blocker
- post-merge supplements: small follow-up PR referencing the original PR
  number, never appended to the merged PR
@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

📦 Built Package Artifact

Branch: 2026-10-01_agents-external-contributor-prs (0160f35)

Option A — Install this exact build (recommended)

npm install -g billion-context@0.0.1803-pr.1825.b712480

This exact version is immutable and reproducible. The rolling pr tag tracks the newest test build across all PRs.

Option B — Download artifact

  1. Download the artifact from the Actions run
  2. Extract the tarball and install:
tar xzf billion-context-pr1825.tgz
npm install -g package

Install instructions are refreshed on each push.

@ranxianglei
ranxianglei merged commit 939c7c9 into master Oct 1, 2026
12 checks passed
@ranxianglei
ranxianglei deleted the 2026-10-01_agents-external-contributor-prs branch October 15, 2026 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant