Repository navigation
fix(release): make one-click fallback PRs mergeable — explicit CI dispatch on fallback branch - #1746
Conversation
📦 Built Package ArtifactBranch: Option A — Install this exact build (recommended)npm install -g billion-context@0.0.1694-pr.1746.f25883eThis exact version is immutable and reproducible. The rolling Option B — Download artifact
tar xzf billion-context-pr1746.tgz
npm install -g packageInstall instructions are refreshed on each push. |
[bot] 🏷 PR #1746 审查结论(自查):修复了 one-click fallback PR 因 GITHUB_TOKEN push 不产生事件而永远等不到 required checks 的问题(fallback 步骤改为显式 dispatch ci.yml),核对代码与 CI 后可以合并——待主 CI run 变绿后我会再确认一次。 Review walkthrough (per repo review discipline): ① Original issue #1744 — direction check. Root cause was established with evidence before this PR (exhaustive 21-day history scan: all three ② Regression review — existing behaviors touched:
③ Code review. Dispatch URL uses ④ Test validity. Workflow-file changes have no unit-test surface; the right test is the live mechanic, and it was done end-to-end on this very branch: negative control (dispatch without trigger → 422) + positive control (dispatch with trigger → 204, run 36677794487 created, head_sha matches). That run is executing right now and its check runs are precisely what the fallback path will produce. ⑤ Diff cleanliness. One commit, three files, every line related to the stated purpose. No churn. CI status at time of writing (head Also confirmed the follow-up promised in #1744 floor 3: stale branch |
[bot] 🏷 CI 全绿确认:head The dispatched run going green is the load-bearing proof: it is exactly the check-run set the one-click fallback path will now produce on a release head sha, so once this PR lands, future fallback PRs get their required checks without manual approval of gated runs (dispatch failure remains the documented manual-approval escape hatch). |
Fixes #1744
Problem
Under the current master protection (4 required test checks + PR-only), one-click release fallback PRs were not immediately mergeable:
ci.ymlpush trigger never fired on any-HHMMSS-suffixed fallback branch (verified across full history: three such branches, zero push runs);action_requiredfor its pull_request runs;The #772 mechanism ("push CI on release branches satisfies required checks") only ever worked for release branches pushed with a real account token (agent-driven standard flow) — never for the one-click path. AGENTS.md §5 overstated this.
Changes
.github/workflows/ci.yml: add aworkflow_dispatchtrigger (without it the dispatch API call is rejected — see verification below) + rewrite the trigger comments to state the true mechanics..github/workflows/release-manual.yml: grantactions: write; after the fallback branch push succeeds, explicitlyPOST …/actions/workflows/ci.yml/dispatcheswithref=<fallback branch>(best-effort step; on failure warns that manual approval of the gated runs is required). The dispatched run's check runs attach to the same head sha → once green, required checks pass and the auto-PR is mergeable without approving itsaction_requiredpull_request runs.AGENTS.md§5: replace the incorrect "immediately mergeable via push CI" claim with the true mechanics (GITHUB_TOKEN pushes deliver no events; explicit dispatch compensates; manual approval is the documented escape hatch when dispatch fails).Behavior changes (disclosure)
ci.ymlrun on the fallback branch (old: no automatic CI at all on that branch) — this is the intended fix.ci.ymlgains aworkflow_dispatchsurface: anyone with Actions access can manually dispatch CI on any ref (no inputs). Standard practice; required seam for the fix.Verification
2026-09-30_release-v0.1.175(no new trigger) → HTTP 422 rejected — confirms the trigger addition is load-bearing;