Repository navigation
docs: declare shared-state-dir multi-instance security boundary (#1724) - #1745
Conversation
Record in TECHNICAL-NOTES (en/zh-CN) that all instances share one state dir whose control plane is lane-aware but whose data plane is not partitioned — no per-session owner, no per-lane isolation. State the two consequences (cross-instance session visibility in every instance's web UI; the restart drain race and its #1737/#1742/#405 mitigations) and the current security posture: only the admin loopback gate + filesystem permissions, i.e. no per-session authorization. Sufficient single-user, insufficient multi-user (must partition). Issue direction #5. Docs-only.
📦 Built Package ArtifactBranch: Option A — Install this exact build (recommended)npm install -g billion-context@0.0.1695-pr.1745.4d5068eThis exact version is immutable and reproducible. The rolling Option B — Download artifact
tar xzf billion-context-pr1745.tgz
npm install -g packageInstall instructions are refreshed on each push. |
[bot] 🏷 Reviewing PR #1745 now. Verified the core claims against master: shared unpartitioned per-host storage ✓, Web UI re-scans the whole disk store ( |
…ed-state security section
Reviewed the PR against live master — direction is right, all factual claims check out, but the diff had three accuracy problems which I fixed directly on the branch (commit Verified against master (all hold):
Fixes made in
Regression surface: none — docs-only diff, no code path touched; existing lane-aware #394 warning text untouched. CI runs the full suite on the PR regardless. Merge order: with fix #2 the wording no longer asserts #1737/#1742 have landed, so this PR can merge independently of them (no longer needs to wait behind either). Status: CI running on head 中文摘要:审查了共享 state 目录安全边界文档 PR,核实了全部事实性声明(存储无会话属主、Web UI 全量重扫、回环门禁、#405 守卫均在 master 上成立),并直接在分支上修正了三处错误——目录归属写错(sessions 实际在 XDG data 目录而非 state 目录)、"已落地缓解"措辞超前(#1737/#1742 尚未合并,已改为带 PR 编号的中性表述)、#811 误引(自重启顺序修复实为 #1742);纯文档改动无行为回归,CI 绿后可合并。 |
CI update: all 12 checks green on head |
Rebased onto master (post #1713 NO_RANGE manifest locals, post #1745): goldens now reflect zero-injection manifests — every conversation_id param block removed (routing param, search_context cross-session param, one tool left with empty properties). Regenerated via scripts/update-wire-contract-goldens.ts; manifest arrays keep the NO_RANGE-aware locals instead of the pre-rebase plain BILI_ACP_TOOLS_* arrays.
Rebased onto master (post #1713 NO_RANGE manifest locals, post #1745): goldens now reflect zero-injection manifests — every conversation_id param block removed (routing param, search_context cross-session param, one tool left with empty properties). Regenerated via scripts/update-wire-contract-goldens.ts; manifest arrays keep the NO_RANGE-aware locals instead of the pre-rebase plain BILI_ACP_TOOLS_* arrays.
Part of #1724 (issue direction #5 — security declaration). Docs-only; no code change.
Documents the actual security posture of the shared state dir in
TECHNICAL-NOTES(en + zh-CN), which previously only carried the lane-aware #394 coexistence warning without stating what that implies for the data plane:__bili/sessionsre-scans the whole shared store), and the restart drain race — with the mitigations already shipped in fix: multi-instance shared-state hardening — activePack round-trip + affinity clobber guard (#1724) #1737 / fix: flush durable state before spawning self-restart replacement (#1724) #1742 plus the pre-existing ACP_PASSTHROUGH 一键静默关死全部压缩:无日志/无横幅/面板不可见且不可清除,同族 env 旋钮全部生效于无声 #405 guard.This is issue direction #5 verbatim in intent: "在文档中写明共享 state dir 的安全边界当前仅由 loopback gate + 文件系统权限承担,多用户宿主必须分区". It records the boundary as-is; it changes no behavior and adds no config surface.
Pre-flight
typecheck ✓ · build ✓ · full test suite unaffected by a docs-only diff (CI still runs it on the PR).