Skip to content

test: fix undefined rmSync left behind by the tmp-rm.ts sweep — unbreak master CI - #1710

Merged
ranxianglei merged 1 commit into
masterfrom
2026-09-30_fix-test-rmsync-undefined
Sep 29, 2026
Merged

ranxianglei merged 1 commit into
masterfrom
2026-09-30_fix-test-rmsync-undefined

Conversation

@ranxianglei

Copy link
Copy Markdown
Owner

Unbreaks master CI. The latest master run (8293a54) is red: #1101 T9: BILI_CHAIN_CONTENT env parse fails with ReferenceError: rmSync is not defined (tests/issue1086-chain-self-exemption.test.ts:728).

Root cause: the tmp-rm.ts sweep (#1646) replaced fs.rmSync cleanups with the rmrf() helper but missed two bare rmSync() calls whose node:fs imports no longer existed:

  • tests/issue1086-chain-self-exemption.test.ts:728 — uncovered → the CI breaker above.
  • tests/tunnel-guard.test.ts:385 — wrapped in a best-effort try/catch, so the ReferenceError is swallowed silently and the scratch dir leaks instead (latent, same bug).

Fix: both call rmrf() now, consistent with the rest of the sweep (and picking up its ENOTEMPTY retry semantics, #1646).

Both test files verified locally: 36/36 green. Discovered while triaging a CI failure on #1670 (the two files are byte-identical on master).

…defined

The #1646 sweep replaced fs.rmSync cleanups with the rmrf() helper but
missed two bare rmSync() calls whose node:fs imports no longer existed:

- tests/issue1086-chain-self-exemption.test.ts:728 — uncovered, so
  "#1101 T9: BILI_CHAIN_CONTENT env parse" dies with
  ReferenceError: rmSync is not defined (this is the current red master).
- tests/tunnel-guard.test.ts:385 — wrapped in a best-effort try/catch,
  so it fails silently and leaks the scratch dir instead.

Both now call rmrf(), consistent with the rest of the sweep (and pick
up its ENOTEMPTY retry semantics). Found via a CI failure on #1670;
the files are byte-identical on master, which is red on its latest
run (8293a54) with the same error.
@github-actions

Copy link
Copy Markdown
Contributor

📦 Built Package Artifact

Branch: 2026-09-30_fix-test-rmsync-undefined (526350a)

Option A — Install this exact build (recommended)

npm install -g billion-context@0.0.1661-pr.1710.54e5d44

This exact version is immutable and reproducible. The rolling pr tag tracks the newest test build across all PRs.

Option B — Download artifact

  1. Download the artifact from the Actions run
  2. Extract the tarball and install:
tar xzf billion-context-pr1710.tgz
npm install -g package

Install instructions are refreshed on each push.

@ranxianglei
ranxianglei merged commit dcbc944 into master Sep 29, 2026
12 checks passed
@ranxianglei
ranxianglei deleted the 2026-09-30_fix-test-rmsync-undefined branch October 15, 2026 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant