Repository navigation
test: fix undefined rmSync left behind by the tmp-rm.ts sweep — unbreak master CI - #1710
Merged
Merged
Conversation
…defined The #1646 sweep replaced fs.rmSync cleanups with the rmrf() helper but missed two bare rmSync() calls whose node:fs imports no longer existed: - tests/issue1086-chain-self-exemption.test.ts:728 — uncovered, so "#1101 T9: BILI_CHAIN_CONTENT env parse" dies with ReferenceError: rmSync is not defined (this is the current red master). - tests/tunnel-guard.test.ts:385 — wrapped in a best-effort try/catch, so it fails silently and leaks the scratch dir instead. Both now call rmrf(), consistent with the rest of the sweep (and pick up its ENOTEMPTY retry semantics). Found via a CI failure on #1670; the files are byte-identical on master, which is red on its latest run (8293a54) with the same error.
Contributor
📦 Built Package ArtifactBranch: Option A — Install this exact build (recommended)npm install -g billion-context@0.0.1661-pr.1710.54e5d44This exact version is immutable and reproducible. The rolling Option B — Download artifact
tar xzf billion-context-pr1710.tgz
npm install -g packageInstall instructions are refreshed on each push. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unbreaks master CI. The latest master run (8293a54) is red:
#1101 T9: BILI_CHAIN_CONTENT env parsefails withReferenceError: rmSync is not defined(tests/issue1086-chain-self-exemption.test.ts:728).Root cause: the tmp-rm.ts sweep (#1646) replaced
fs.rmSynccleanups with thermrf()helper but missed two barermSync()calls whose node:fs imports no longer existed:tests/issue1086-chain-self-exemption.test.ts:728— uncovered → the CI breaker above.tests/tunnel-guard.test.ts:385— wrapped in a best-efforttry/catch, so the ReferenceError is swallowed silently and the scratch dir leaks instead (latent, same bug).Fix: both call
rmrf()now, consistent with the rest of the sweep (and picking up its ENOTEMPTY retry semantics, #1646).Both test files verified locally: 36/36 green. Discovered while triaging a CI failure on #1670 (the two files are byte-identical on master).