Skip to content

fix: pin acp-kernel 0.0.98 (content salvage + one-string batch) - #1552

Merged
ranxianglei merged 1 commit into
masterfrom
2026-09-28_kernel-0.0.98
Sep 28, 2026
Merged

ranxianglei merged 1 commit into
masterfrom
2026-09-28_kernel-0.0.98

Conversation

@ranxianglei

Copy link
Copy Markdown
Owner

Bumps the bundled acp-kernel pin 0.0.97 → 0.0.98 (exact, npm live; verified npm view acp-kernel version = 0.0.98).

What 0.0.98 ships (acp-kernel #473 release)

bili-side changes in this PR

  • package.json / lockfile: exact pin 0.0.98
  • tests/golden/wire-contract/* regenerated via scripts/update-wire-contract-goldens.ts — the pack text changed (test: fix pipePluginChatWithStrip call order after #466 signature swap #472); 4 golden files, content-only diff
  • tests/compress-prompt-pack.test.ts — two inline expectations updated to the lean one-liner that now teaches ONE-call batching

Verification

  • Combined build (release v0.1.72 #471+test: fix pipePluginChatWithStrip call order after #466 signature swap #472) validated live by the owner in a real bili pi session: one-string 3-block batch compressed m00059–m00060 / m00083–m00090 / m00098–m00099 → 3 block(s), ~14818 tokens saved, and the per-summary cap was proven NOT shared across a batch (3 × 19 000-char summaries parse fine; cap is per-entry maxSummaryLength: 20000).
  • Local: typecheck clean, targeted suites green (wire-contract, compress-tool, prompt-pack, lean).
  • Full matrix: remote CI.

Fixes #1495

…g batch teaching)

- acp-kernel 0.0.97 -> 0.0.98 (exact pin, npm live)
- wire-contract goldens regenerated (pack text change, acp-kernel #472)
- compress-prompt-pack expectations updated to the lean one-liner that now
  teaches ONE-call batching (acp-kernel #472)

Fixes #1495 (kernel-side root: single-entry object salvage acp-kernel #470/#471,
batch form taught + pinned acp-kernel #472)
@github-actions

Copy link
Copy Markdown
Contributor

📦 Built Package Artifact

Branch: 2026-09-28_kernel-0.0.98 (b5b367d)

Option A — Install this exact build (recommended)

npm install -g billion-context@0.0.1490-pr.1552.da6ef1d

This exact version is immutable and reproducible. The rolling pr tag tracks the newest test build across all PRs.

Option B — Download artifact

  1. Download the artifact from the Actions run
  2. Extract the tarball and install:
tar xzf billion-context-pr1552.tgz
npm install -g package

Install instructions are refreshed on each push.

@ranxianglei

Copy link
Copy Markdown
Owner Author

🤖 Powered by ework · qwen3.8-27b

[bot] 🏷 Reviewed PR #1552 (2026-09-28_kernel-0.0.98, head b5b367d). Verdict: review passed, ready to merge — merging stays human per the auto-merge gate (acp-kernel pin = cross-repo dependency). Please merge yourself: #1552

① Original-issue direction (#1495). Correct layering: the retry-drift shape (single-entry OBJECT in content) gets its root fix kernel-side (#471 salvage + contentSalvage diagnostic), while bili's #1497 workaround normalizeCompressInput (src/compress-tool.ts:287-303, applied at :306) stays as an idempotent pre-normalizer. Verified compatibility directly: array inputs pass through untouched, object-content wrapping is idempotent, so the two layers compose without double-processing or shadowing each other.

② Version-window regression audit (0.0.97 → 0.0.98). Diffed both published tarballs file-by-file; the entire delta is:

  • dist/ bundle — pack-text teaching changes + salvage logic (verified: contentSalvage marker present exactly once; one-string batch teaching strings present in all 3 surfaces: default pack, lean pack, fold nudge)
  • dist/parse-compress-input.d.ts — additive only: optional contentSalvage?: boolean on the parse result
  • package.json — version line only
  • LICENSE / README.md — new "Additional Term — Attribution on Product Surfaces" (MIT + attribution clause). Checked compliance: billion-context's README already states it uses acp-kernel with a link (README.md:63), which satisfies the term via shipped documentation for embedded use. No action needed in this PR; flagging it here so the license delta doesn't go unnoticed.
    No other exported surface changed.

③ Code review (bili-side diff, 7 files, single commit).

  • Pin is exact 0.0.98 in both package.json and lockfile (devDependencies, resolved URL + integrity updated, lockfile in sync) — matches the pin discipline; npm view acp-kernel version = 0.0.98 (live).
  • 4 golden files (tests/golden/wire-contract/{bili,kernel,manifest-default,manifest-optin}.json) are content-only: compress tool description strings updated, schema shape byte-identical (anyOf structure unchanged).
  • tests/compress-prompt-pack.test.ts: two lean-pack description expectations updated to match the kernel's new one-liner — real assertions against the actual registry-resolved surface, not tautologies.
  • Diff is clean: every line serves the pin bump; no incidental churn.

④ Behavior changes (flagged per policy):

  • Old: compress tool description taught "Array form (preferred)" for multi-range batches. New: "Single-string form (PREFERRED for multi-range batches — plain text survives lossy gateways best)" + explicit "Batch multiple ranges into ONE call — do not split into one call per range." Reason: lean模式批量压缩丢失 #1495's lossy-gateway drops corrupted JSON structure; a bare string has nothing to corrupt. Prompt-text-only change (schema unchanged), intentional, owner-validated live in a real bili pi session (3-block one-string batch, ~14818 tokens saved; per-summary cap proven per-entry, not shared).
  • New optional contentSalvage diagnostic field — additive; absent unless salvage fired.

⑤ Evidence.

  • Branch is current with master (merge-base = master tip 9a955aa, 0 commits behind) — no rebase needed.
  • Local pre-flight on the branch head: npm ci (kernel 0.0.98 installed), typecheck clean, full suite 3029 pass / 0 fail / 12 skip, build OK.
  • CI: 13/13 check runs completed, all success — including e2e (real codex), hermetic registry e2e, real pi/codex/dsh/opencode lanes, version-guard, and the full ubuntu/windows test matrix.

中文摘要:审核了 acp-kernel 0.0.97→0.0.98 升级 PR——逐文件比对了两个已发布 tarball 确认窗口内全部变更(#471 content 单对象抢救、#472 单字符串整批教学、新增署名许可条款),本地 typecheck/全量测试(3029 过)/构建全绿,CI 13/13 成功,行为变更(批量首选形式从数组改为单字符串)已按旧值→新值披露且为有意变更,可以合并。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lean模式批量压缩丢失

1 participant