Repository navigation
feat(ci): single rolling pr tag + monotonic 0.0.<run>-pr versions - #1432
Conversation
📦 Built Package ArtifactBranch: Option A — Install this exact build (recommended)npm install -g billion-context@0.0.1394-pr.1432.7d03bcdThis exact version is immutable and reproducible. The rolling Option B — Download artifact
tar xzf billion-context-pr1432.tgz
npm install -g packageInstall instructions are refreshed on each push. |
6c56414 to
6e7e95c
Compare
[bot] 🏷 收到,开始 review。PR head |
[bot] 🏷 Review 完成,结论:可以合并(触碰 release workflow 机制,按 §7.4 属人工合并类——我不执行合并)。 ① 原 issue(#1385)方向owner 已在 #1385 floor 4 拍板批准(单滚动 ② 回归审查 —— 触碰路径的既有行为清单
文档: ③ 代码审查
④ 测试有效性 —— 本 PR 自带真实 e2e 证据(workflow 类改动最强验证)新代码在本 PR 自己身上已经跑了两次真实发布:
⑤ diff 整洁度6 文件 +48/−16,单提交,rebase 在最新 master,每行都服务 #1385;无空行/重排噪音、无 lockfile/生成物 churn。干净。 一个非阻塞观察(记录在案,不改)pull_request 事件下 中文摘要:实现了 owner 批准的"单滚动 |
…search.planAware) Re-rank search_context candidates against in-context plan state (latest planning-tool snapshots + most recent user turn) when matches exceed limit; append a [plan-aware] steering section (top fetch targets + repeat-retrieve hint). Byte-identical output when off or when no plan state is present; foreign-session searches stay read-only lexical. Retrieval-quality stats (whole-block restores vs cheaper precise path available) surface in acp_status. Default off until measured. Fixes #1336
The feature commit rewrote the historical-session note text in
executeSearchContext without gating it on compress.search.planAware.
That breaks two documented properties:
1. The PR's own contract that foreign-session searches stay
"byte-identical to before" when the new flag is off — the rewrite
fires for every foreign lookup regardless of config.
2. The pinned assertions in tests/search-context-cross-session.test.ts
("Read-only search of historical session ..."), which fail with the
new wording even though the PR does not touch that test file.
Revert to the original wording (verified byte-identical to master).
…ofile (#1279 follow-up) When no level sets compress.priceProfile, the session stamp now falls back to the request model's models.dev price row (absolute $\/Mtok: w = cost.input, r = cost.cache_read ?? 0.1*input, q = cost.output ?? 1.5*input). Known-provider hosts get their own listing; unknown relays take the first matching listing with a one-time conflict warning. Live catalog.json wins when reachable, bundled snapshot is the offline floor (snapshot rebuilt to carry 7126 cost rows). User config at any level still wins wholesale; unresolvable models keep the kernel relative defaults.
…lback to kernel 4x, legacy-disk price fallthrough, e2e teardown hygiene (review round 2)
…w B) Correct the claim in pr-artifact.yml and CHANGELOG: github.run_number is unique+monotonic per WORKFLOW; uniqueness of 0.0.x versions rests on this workflow being the sole 0.0.x publisher (rename/duplicate would restart the counter silently).
|
Deep-review complete — Approve; one doc correction applied on-branch (rebased onto current master). Verified
Fixed on-branchB (doc): " Info (no action)
No |
[bot] 🏷 Verified the updated head ( Doc fix (B) — confirmed on-branch. Final-head state:
No changes requested. Merging stays human-only (§7.4 — release-workflow machinery). 中文摘要:已核实分支上的文档修正( |
Fixes #1385
What changed
Per the approved design in #1385 (single rolling tag + globally monotonic version sequence), PR artifact publishing no longer creates one dist-tag per PR:
.github/workflows/pr-artifact.yml0.0.0-pr.<PR>.<run>→0.0.<run_number>-pr.<PR>.<sha7>, plus-a<attempt>whengithub.run_attempt > 1.run_numberis repo-wide unique + monotonic (gaps allowed) → no "read registry max + 1" race, concurrent publishes cannot collide;-a<attempt>makes a rerun of one run publish a fresh version instead of E409 (fixes a latent hole the old scheme shared).0.0.0-pr.*; the-pr…prerelease suffix keeps builds unresolvable by any semver range ([opencode 2.x] bare npm spec ("billion-context") triggers managed-service restart loop; pinning an exact version avoids it #1108 protection unchanged).--tag "pr-${PR_NUMBER}"→--tag pr— one moving pointer, the same mechanismlatestalready uses. New dist-tag growth = 0 (one-time addition ofpr); the ~640 legacypr-Ntags are frozen in place and remain installable.npm install -g billion-context@0.0.<N>-pr.<P>.<sha7>) instead of@pr-N, and notes that@prtracks the newest test build across all PRs. The version is passed viaGITHUB_OUTPUT→ step env; the fork path (publish skipped, no NPM_TOKEN) falls back to the artifact-only comment as before. Artifact tarball path (Option B,billion-context-pr<N>.tgz) is unchanged.Release drift guards (new invariant: official releases always sort above the PR-build line)
.github/workflows/release-manual.yml: the Drift guard aborts if the target version matches0.0.*..github/workflows/release.yml: the Read version step aborts if package.json's version matches0.0.*.Docs/changelog:
CONFIGURATION.md/CONFIGURATION.zh-CN.mdACP_UPDATE_TAGrow updated (rollingprsemantics + frozen legacypr-N);CHANGELOG.mdentry under[Unreleased].Behavior changes (disclosed per AGENTS.md)
billion-context@pr-N(tag)pr-Ntagspr-N)pr)0.0.0-pr.P.RUN0.0.SEQ-pr.P.SHA[-aN]< 0.1.0targets0.0.*Not affected:
latest/ release flow, auto-update default channel (latest), semver-range resolution of PR builds (still impossible — prerelease property kept), fork-PR behavior (publish skipped), artifact downloads. Instances explicitly configured withACP_UPDATE_TAG=pr-Nfreeze at that tag's final build (the tag still resolves; nothing breaks, no forced migration — see #1385 discussion).Pre-flight
30701b03); branch base verified against origin/master.npm run typecheck✅ ·npm test✅ (2851 tests: 2839 pass, 0 fail, 12 skipped) ·npm run build✅ (tsup + dist-import-annotations OK).src/changes; request pipeline untouched → e2e suite not applicable.Touches release workflow machinery → human review required (§7.4 auto-merge gate).