Skip to content

hop-by-hop 头(proxy-authorization 等)未剥离,凭据泄漏到上游 [master/pre-existing] #80

Closed

Description

@ranxianglei

问题

转发到上游时,UPSTREAM_HOP_HEADERS 集合不完整:缺少 proxy-authorization、te、trailer、upgrade,也没有按 Connection 头的值剥离命名头(RFC 7230 §6.1 要求)。后果:客户端发给"bili 作为代理"的 Proxy-Authorization: Basic <凭据> 会被原样转发到上游模型端点,凭据泄漏。

位置(master, pre-existing)

src/server.ts:55(UPSTREAM_HOP_HEADERS 定义)、:817(请求转发剥离)、:840(响应剥离)。PR #73 改动了 server.ts 但未修此集合。

// src/server.ts:55 (master)
const UPSTREAM_HOP_HEADERS = new Set([
    "host", "content-length", "connection", "keep-alive",
    "transfer-encoding", "content-encoding",
    // ← 缺: proxy-authorization, te, trailer, upgrade
    // ← 缺: 按 Connection 头值剥离的命名头
]);

当前集合只覆盖最常见的几个。proxy-authorization(客户端→代理的凭据)、te/trailer(RFC)、upgrade 均缺失;也未实现"读取 Connection 头的值并剥离其中列出的头"。

影响

  • proxy-authorization 泄漏:若用户给 bili 配了需要认证的上游代理,客户端的 Proxy-Authorization 头会被转发到模型端点,凭据外泄给第三方
  • 违反 RFC 7230 §6.1(hop-by-hop 头不应跨代理转发)
  • 被新的 MITM 隧道路径放大(隧道化请求也会经过这条转发逻辑)

建议修复

  1. 补全集合:proxy-authorization、te、trailer、upgrade、proxy-authenticate、proxy-connection
  2. 动态剥离:读取请求/响应的 Connection 头值,剥离其中列出的命名头
  3. 补测试:构造带 Proxy-Authorization: Basic ... 的请求,断言转发到上游时该头不存在

Activity

  1. added 2 commits that reference this issue on Aug 13, 2026
  2. ranxianglei commented on Aug 14, 2026

    @ranxianglei
    OwnerAuthor

    Fixed in #141 (merged). Closing as completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions