Skip to content

MITM CONNECT 隧道超时竞态导致 upstream socket 泄漏 [master/pre-existing] #76

Closed

Description

@ranxianglei

问题

MITM/CONNECT 隧道的握手超时存在竞态:15s 超时触发后只销毁 clientSocket,而仍在途的 connectThroughProxy().then() 回调没有 abort guard,慢上游(T+16s 才连上)会在超时之后继续执行——向已销毁的 clientSocket 写 200 Connection Established,并把新开的 upstream socket pipe 到死 socket,upstream socket 无人关闭 → 泄漏。

位置(master, pre-existing)

src/mitm.ts 的 tunnelThrough(~:100-126)。PR #73 未改动此段(git diff master...pr-73 -- src/mitm.ts 源码为空,仅改了测试),但 PR #73 是顺便修复的好时机。

// src/mitm.ts
const connectTimer = setTimeout(() => {
    if (!established) {
        clientSocket.write("HTTP/1.1 504 Gateway Timeout\r\n\r\n");
        clientSocket.destroy();          // ← 只销毁 clientSocket,在途 upstream 无人管
    }
}, 15000);
connectThroughProxy(...).then((upstream) => {
    established = true;                   // ← 从未在后续逻辑里 gate "定时器是否已触发"
    clientSocket.write("HTTP/1.1 200 Connection Established\r\n\r\n");  // ← 超时后仍写入已 destroy 的 socket
    upstream.pipe(clientSocket);          // ← upstream socket 泄漏
});

established 变量只用于定时器内部判断,.then 回调里没有读取它来 abort。

注:历史 commit 45ac6a1 修的是另一个 race,本竞态未被覆盖。

影响

  • upstream socket 泄漏(每个超时的 CONNECT 留一个半开连接)
  • 向已销毁 socket 写入(Node 会抛 ERR_STREAM_DESTROYED,被全局 uncaughtException 吞掉,但不干净)
  • 配合 feat: OpenAI Responses API support (/v1/responses) #4(直连无超时),504 之后半开 socket 还要挂 ~2 分钟(OS tcp_syn_retries)

建议修复

  1. .then 内加 abort guard:if (aborted) { upstream.destroy(); return; }
  2. 超时分支里保存对在途 connectThroughProxy promise/upstream 的引用,超时时主动销毁
  3. 补集成测试:模拟慢上游(T+16s 连上)+ 15s 超时,断言 upstream socket 被 destroy、无 ERR_STREAM_DESTROYED

Activity

  1. added 2 commits that reference this issue on Aug 13, 2026
  2. ranxianglei commented on Aug 14, 2026

    @ranxianglei
    OwnerAuthor

    Fixed in #141 (merged). Closing as completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions