You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
External proposal (LX666-666, PR #86): make the updater three-state — auto / notify-only / off — plus a nudge growth-interval knob.
Current state on master: the updater is always-auto (3-min checks, env kill-switch exists); nudge cadence is kernel-owned since 0.0.52 (pressure-band min-benefit gate), so the nudge-interval half of the proposal is obsolete as a host feature. The PR conflicts across 8 files against current master.
Suggested fix
If the three-state update mode is wanted: reimplement it alone against current src/update.ts (remember AGENTS.md §5 — updater changes need a no-op release first). Otherwise close the PR with thanks. Decision needed from maintainer.
[bot] 🏷 Triage verdict: close PR #86 with thanks; salvage one piece as a separate issue (filed as #609).
Duplicate screening first: searched open+closed issues/PRs for update-mode / auto-update / nudge-interval topics — no duplicates; #606 is the only tracking item for this proposal.
Verified against current master (v0.1.88, 2b510af):
1. The nudge half of the PR is already shipped.compress.nudgeGrowthTokens exists on master today: three-level merge (global → provider → model), maps to nudge.growthFloor = nudge.growthCap (src/compress-settings.ts:131-133), documented in CONFIGURATION.md, and hot-reloadable through the existing compress-settings PUT path (covered by tests/web-routing.test.ts). The PR proposes exactly this mechanism — that half is redundant against current master, independent of the kernel owning adaptive cadence since 0.0.52.
2. Two of the three states already exist. auto (default; 3-min checks) and off (config "autoUpdate": false, env ACP_AUTO_UPDATE=0, per-run bili --no-auto-update — src/config.ts:396, src/cli.ts:173-174; documented in README §Self-update). Only "notify-only" would be net-new surface.
3. The PR is dead-on-arrival mechanically. GitHub reports mergeable_state: dirty (conflicts vs current master; single commit based on an older tree, 15 files). Its body says "Closes #606", but #606 postdates the PR (issue opened 2026-09-07, PR created 2026-08-10) — stale reference, which is why nothing auto-linked.
4. One genuinely valid piece: updater egress.src/update.ts hits registry.npmjs.org and the tarball CDN with bare fetch and no undici dispatcher (src/update.ts:367, src/update.ts:494), while every model-traffic path routes through the configured upstream proxy (src/upstream-proxy.ts: resolveProxyDecision() + proxyDispatcher()). Users whose npm traffic needs a proxy (the GFW scenario bili explicitly supports for model traffic) silently fail every update check — auto-update quietly never works. Filed separately as #609 with repro/impact/suggested fix; small change, no mode semantics involved.
Recommendation:
Close PR feat: three-state update mode and fixed nudge growth interval #86 with thanks. The only new surface is one middle state on a load-bearing path: per AGENTS.md §5 the updater is the one module where a bug bricks everyone's future upgrades (hence the no-op-release-first rule), "off" already covers the "don't touch my install" segment, and notify-only's payoff is a log line plus UI state. Users who sit on notify-only keep running known-buggy versions indefinitely — auto-update here is a core reliability feature, not an annoyance. I'd hold off building it until someone actually asks for it; if you decide you want it anyway, I'll reimplement it alone against current master (not rebase the PR), no-op release first per §5. Say the word and I'll close feat: three-state update mode and fixed nudge growth interval #86 — closing an external contributor's PR is yours to do.
Activity
ranxianglei commentedon Sep 7, 2026
[bot] 🏷 Triage verdict: close PR #86 with thanks; salvage one piece as a separate issue (filed as #609).
Duplicate screening first: searched open+closed issues/PRs for update-mode / auto-update / nudge-interval topics — no duplicates; #606 is the only tracking item for this proposal.
Verified against current master (
v0.1.88,2b510af):1. The nudge half of the PR is already shipped.
compress.nudgeGrowthTokensexists on master today: three-level merge (global → provider → model), maps tonudge.growthFloor = nudge.growthCap(src/compress-settings.ts:131-133), documented in CONFIGURATION.md, and hot-reloadable through the existing compress-settings PUT path (covered bytests/web-routing.test.ts). The PR proposes exactly this mechanism — that half is redundant against current master, independent of the kernel owning adaptive cadence since 0.0.52.2. Two of the three states already exist. auto (default; 3-min checks) and off (config
"autoUpdate": false, envACP_AUTO_UPDATE=0, per-runbili --no-auto-update—src/config.ts:396,src/cli.ts:173-174; documented in README §Self-update). Only "notify-only" would be net-new surface.3. The PR is dead-on-arrival mechanically. GitHub reports
mergeable_state: dirty(conflicts vs current master; single commit based on an older tree, 15 files). Its body says "Closes #606", but #606 postdates the PR (issue opened 2026-09-07, PR created 2026-08-10) — stale reference, which is why nothing auto-linked.4. One genuinely valid piece: updater egress.
src/update.tshitsregistry.npmjs.organd the tarball CDN with barefetchand no undici dispatcher (src/update.ts:367,src/update.ts:494), while every model-traffic path routes through the configured upstream proxy (src/upstream-proxy.ts:resolveProxyDecision()+proxyDispatcher()). Users whose npm traffic needs a proxy (the GFW scenario bili explicitly supports for model traffic) silently fail every update check — auto-update quietly never works. Filed separately as #609 with repro/impact/suggested fix; small change, no mode semantics involved.Recommendation:
src/update.tsdownload logic).