Repository navigation
Conversation
Review cleanup for ranxianglei#518 (no behavior change): hoist the Set built from findOffBranchBlocks so the restore path reuses it instead of an O(n^2) Array.includes scan, and drop a redundant type assertion — CompressionBlock.expanded is already typed boolean | undefined.
24acd85 to
32ecaf8
Compare
[bot] 🏷 查重:不重复——#518 是 #516 的重新提交(#516 因分支命名不规范 + prettier 关闭,本次已改为 标签: Review 结论(独立重审,未照抄 issue 侧结论)① 方向关:合理。我独立验证了机制: 八问:
行为变更披露(Deliverables #4):不参与宿主零变化;参与宿主在被 mask 的回合:旧 = off-branch 块摘要替换在视消息(泄漏另一分支内容)→ 新 = 在视消息原文显示、摘要不注入。即修复目标本身。 Diff 整洁处置(已完成):
测试有效性(④):4 个用例是真测试——用例 1 先钉住基线泄漏(不传字段时 FUTURE_DECISION 出现在输出里),再断言带字段输出不含它 + e1 原文渲染 + mask 未持久化 + 输入未被改;masking 回归会立刻变红。非阻塞建议:后续可补一例「完全 off-branch(无任何消息在视)不应被 mask」。 热点提示:PR #515 也改 判定:可合——机制成立、实现最小、测试钉住了行为、diff 已收敛。按仓库规则 §7.4 这是 feat(新增能力面)属 human-gated,§6 另要求至少 2 个独立 agent review 后方可合并(本回复为第 1 个);当前 mergeable_state=blocked 即缺 required review。CI 除 test(Node 22) 尚在 runner 队列外全绿,owner 给 approval 即可。我不执行合并。 |
[bot] 🏷 补一行:cleaned head |
Same content as #516 (closed: branch name violated the YYYY-MM-DD_short-title convention; plus prettier formatting).
Opt-in engine support for extension-managed conversation-branch masking (needed by SeniorHan/keel-fold). Details in #516. [feat] branch-awareness · [feat] compress wiring · [test] end-to-end (4 cases, message-order matching upstream syncBlocks conventions; 1237/1237 locally).