Repository navigation
Support inventory format 110 and verify AzuCraftyBoxes 1.8.28 - #37
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Valheim 1.0.20 writes inventory format 110, which Guild Chest rejected with
Unsupported inventory format 110, blocking storage access and transfers. Accept formats 109 and 110 through Valheim's version-aware item loader while retaining the rejection of uninspected formats.AzuCraftyBoxes 1.8.28 keeps the adapter hooks unchanged. Extend the native fixture to verify its new Cookables exclusions and individual overrides, current and legacy inventory round trips, cheat-flag metadata, unchanged client-only items, and rejection of unsupported formats. Update the compatibility documentation and record the user's successful in-game test of the compatibility build.
Validation:
dotnet run --project build -- --target Test: 15 C# and 162 Python tests pass.artifacts/GuildChest-1.1.0-compat-test.zipworks in game with AzuCraftyBoxes 1.8.28. The archive checksum and detailed results are recorded indocs/VALIDATION.md.