Repository navigation
Report unavailable Hexium scans without failing publication - #35
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hexium can publish a valid package while its virus-scan result is blank, pending, or unavailable. Previously, that made the helper poll for five minutes and fail after verifying the archive and completing listing metadata. Publishing now succeeds once content and public metadata are verified, with a separate scan status and follow-up link. An explicit virus-detections badge still fails the run for review.
HTTP response-reading errors, including truncated responses, are also handled by the shared release downloader and Hexium/Nexus metadata clients. Required reads continue to fail; lost write responses require reconciliation without automatic resubmission or disclosure of response contents. Regression tests cover these boundaries and preserve the existing publication checks.
The docs record the team's immediate API publication setting and GitHub's independent publishing switch. The workspace network configuration also allows the Hexium API domain.
Validation:
Test: all 15 C# and 162 Python tests passed.No gameplay code or published release assets changed. Hexium's successful virus-scan result remains unconfirmed and is reported separately from publication.