feat(code): switch to typescript, mock zillow api calls, fix xml parser#20
Open
blaskovicz wants to merge 4 commits into
Open
feat(code): switch to typescript, mock zillow api calls, fix xml parser#20blaskovicz wants to merge 4 commits into
blaskovicz wants to merge 4 commits into
Conversation
2fb2e15 to
a71f4e3
Compare
Author
Owner
|
This looks pretty good, thanks for the PR. Can I ask the impetus for the change to typescript, etc.? Thanks. Richard |
Author
|
Hi @ralucas I'm a big fan of Typescript when it comes to developing applications at scale since it makes refactoring and bug detection a breeze! I did this since Typescript is my preferred language over raw JavaScript since I may need to implement this soon myself, unless @konsumer does: #13. Here's another repo I converted to Typescript successfully: adumont/tplink-cloud-api@36d05f5 |
Closed
Author
|
Also, I'd like to add that if you know JavaScript, you almost already know typescript! Depending on the settings of the compiler and linter, it can be pretty lax with explicitly defining types (declarations, return values, function arguments, etc). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.