Skip to content

feat(code): switch to typescript, mock zillow api calls, fix xml parser#20

Open
blaskovicz wants to merge 4 commits into
ralucas:masterfrom
blaskovicz:master
Open

feat(code): switch to typescript, mock zillow api calls, fix xml parser#20
blaskovicz wants to merge 4 commits into
ralucas:masterfrom
blaskovicz:master

Conversation

@blaskovicz

Copy link
Copy Markdown

No description provided.

@blaskovicz blaskovicz force-pushed the master branch 2 times, most recently from 2fb2e15 to a71f4e3 Compare October 17, 2018 05:32
@blaskovicz

Copy link
Copy Markdown
Author

All good!

image

@ralucas

ralucas commented Oct 18, 2018

Copy link
Copy Markdown
Owner

This looks pretty good, thanks for the PR. Can I ask the impetus for the change to typescript, etc.? Thanks.

Richard

@blaskovicz

Copy link
Copy Markdown
Author

Hi @ralucas I'm a big fan of Typescript when it comes to developing applications at scale since it makes refactoring and bug detection a breeze!

I did this since Typescript is my preferred language over raw JavaScript since I may need to implement this soon myself, unless @konsumer does: #13.

Here's another repo I converted to Typescript successfully: adumont/tplink-cloud-api@36d05f5

@blaskovicz

Copy link
Copy Markdown
Author

Also, I'd like to add that if you know JavaScript, you almost already know typescript! Depending on the settings of the compiler and linter, it can be pretty lax with explicitly defining types (declarations, return values, function arguments, etc).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants