Skip to content

Test ParseSet#19

Open
johnlockwood-wf wants to merge 7 commits into
rakyll:masterfrom
johnlockwood-wf:test-parse-set
Open

Test ParseSet#19
johnlockwood-wf wants to merge 7 commits into
rakyll:masterfrom
johnlockwood-wf:test-parse-set

Conversation

@johnlockwood-wf

Copy link
Copy Markdown
Contributor

Ensure ParseSet set's it's flags in the precedence of Environmental var > INI.

Ensure ParseSet will overwrite a flag of a registered FlagSet if it has already been set during Parse

Comment thread globalconf_test.go Outdated
}
}

// Ensure ParseSet sets and possibly overwrites already set flags of a FlagSet

@rakyll rakyll Sep 19, 2016

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto. and overwrites, not possibly.

Comment thread globalconf_test.go Outdated
}
}

// Ensure ParseSet sets and possibly overwrites already set flags of a FlagSet

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and overwrites, not possibly. This is a deterministic behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants