Skip to content

Bump rain.metadata submodule for stale OrderBuilderStateV1 doc comment#482

Closed
findolor wants to merge 1 commit intomainfrom
chore/rain-metadata-submodule-update
Closed

Bump rain.metadata submodule for stale OrderBuilderStateV1 doc comment#482
findolor wants to merge 1 commit intomainfrom
chore/rain-metadata-submodule-update

Conversation

@findolor
Copy link
Copy Markdown
Contributor

@findolor findolor commented Apr 17, 2026

Dependent PRs

Motivation

rain.metadata includes a fix for a stale OrderBuilderStateV1 doc comment. This submodule bump pulls that fix into rainlang.

Prior art: #436

Solution

  • bump lib/rain.metadata from 182db238b53895b8490ac13208b2580eab817f36 to 952b49c9181d95fd6a1bc86e0200297f35982b5a
  • no code changes outside the submodule pointer

Checks

By submitting this for review, I'm confirming I've done the following:

  • made this PR as small as possible
  • unit-tested any new functionality
  • linked any relevant issues or PRs
  • included screenshots (if this involves a front-end change)

Validation run locally:

  • nix develop -c rainix-sol-prelude
  • nix develop -c rainix-rs-prelude
  • nix develop -c rainlang-prelude
  • nix develop -c rainix-rs-test
  • nix develop -c rainix-rs-artifacts
  • nix develop -c rainix-rs-static
  • nix develop -c rainix-sol-static
  • nix develop -c forge build
  • nix develop -c test-wasm-build
  • nix develop -c forge script ./script/BuildPointers.sol
  • nix develop -c forge fmt

nix develop -c rainix-sol-test still requires CI RPC environment variables locally (CI_FORK_ETH_RPC_URL, CI_DEPLOY_*_RPC_URL, ETH_RPC_URL).

Summary by CodeRabbit

  • Chores
    • Updated metadata library dependency.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 17, 2026

📝 Walkthrough

Walkthrough

A git submodule pointer in lib/rain.metadata is updated to reference a newer commit, advancing the submodule version without modifying the parent repository's source code.

Changes

Cohort / File(s) Summary
Submodule Update
lib/rain.metadata
Updated submodule commit pointer to newer version.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A whisker twitch, a nibble here,
The metadata hops to a state more dear,
One commit hash swapped for its twin,
Progress wrapped up, tucked neatly in! 🥕

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically identifies the main change: bumping the rain.metadata submodule to fix a stale doc comment in OrderBuilderStateV1.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/rain-metadata-submodule-update

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@findolor findolor self-assigned this Apr 17, 2026
@findolor findolor force-pushed the chore/rain-metadata-submodule-update branch from a76fe46 to 8b92e19 Compare April 28, 2026 10:10
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@lib/rain.metadata`:
- Line 1: The submodule pointer in lib/rain.metadata is wrong and missing the
required interface file IDescribedByMetaV1 (imported as
rain.metadata/interface/IDescribedByMetaV1.sol), causing build failures; update
the git submodule reference to the intended commit
952b49c9181d95fd6a1bc86e0200297f35982b5a (or to the actual HEAD that contains
the interface, e.g., 8b92e198b323d908f8bfb965f3f0371fd83a991d if that is the
correct one), then verify the submodule contains
rain.metadata/interface/IDescribedByMetaV1.sol and add or restore that interface
file in the submodule if missing, or adjust the import to the correct path/name
inside the submodule so compilation succeeds.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: dba65297-0933-4b42-ba55-b7180f21748d

📥 Commits

Reviewing files that changed from the base of the PR and between e5dc868 and 8b92e19.

⛔ Files ignored due to path filters (1)
  • foundry.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • lib/rain.metadata

Comment thread lib/rain.metadata
@@ -1 +1 @@
Subproject commit 182db238b53895b8490ac13208b2580eab817f36
Subproject commit 0cfba664c5a381662ed4436979ad47e12e76c2a8
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "1) Parent repo submodule status (lib/rain.metadata):"
git submodule status lib/rain.metadata

echo
echo "2) Actual HEAD of submodule lib/rain.metadata:"
git -C lib/rain.metadata rev-parse HEAD

echo
echo "3) Check expected interface file exists in the new submodule:"
test -f lib/rain.metadata/interface/IDescribedByMetaV1.sol && echo "OK: IDescribedByMetaV1.sol exists" || (echo "MISSING: IDescribedByMetaV1.sol" && exit 1)

Repository: rainlanguage/rainlang

Length of output: 362


Submodule pointer has mismatched commits and missing required interface file—will cause build failure.

The diff shows submodule commit 0cfba664c5a381662ed4436979ad47e12e76c2a8, but:

  • PR objectives state the target commit should be 952b49c9181d95fd6a1bc86e0200297f35982b5a
  • The actual submodule HEAD is 8b92e198b323d908f8bfb965f3f0371fd83a991d

More critically, the parent repo imports IDescribedByMetaV1 from rain.metadata/interface/IDescribedByMetaV1.sol, but this file does not exist in the current submodule state. This will break compilation.

Resolve the commit mismatch and ensure the intended submodule commit contains all required interface files.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@lib/rain.metadata` at line 1, The submodule pointer in lib/rain.metadata is
wrong and missing the required interface file IDescribedByMetaV1 (imported as
rain.metadata/interface/IDescribedByMetaV1.sol), causing build failures; update
the git submodule reference to the intended commit
952b49c9181d95fd6a1bc86e0200297f35982b5a (or to the actual HEAD that contains
the interface, e.g., 8b92e198b323d908f8bfb965f3f0371fd83a991d if that is the
correct one), then verify the submodule contains
rain.metadata/interface/IDescribedByMetaV1.sol and add or restore that interface
file in the submodule if missing, or adjust the import to the correct path/name
inside the submodule so compilation succeeds.

@findolor findolor requested review from JuaniRios and hardyjosh April 28, 2026 10:13
@findolor findolor closed this Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants